From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0920C83F27 for ; Wed, 16 Jul 2025 08:52:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DBD48D0003; Wed, 16 Jul 2025 04:52:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78C3A8D0001; Wed, 16 Jul 2025 04:52:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62CAF8D0003; Wed, 16 Jul 2025 04:52:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4BEB38D0001 for ; Wed, 16 Jul 2025 04:52:30 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F2A87567FA for ; Wed, 16 Jul 2025 08:52:29 +0000 (UTC) X-FDA: 83669511618.23.704D617 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id A2D921C0007 for ; Wed, 16 Jul 2025 08:52:27 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EJiwx2++; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752655947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jDRDlU2q13d3K7zJcNpx9sql1ihNe5QWHWqfSe72+1s=; b=YG8l9tmBmjg8pQIW63kLqPLFhKc9JvpurKYjMSwHDILv8uxs+sx8rVdMFrgVRemM7dwJ4J LxNVh2xsEEsTPyWniSIHgEbLbvGP/INLs+INxujyM5E8CCWZ7aCaliBUUMV81zxldajc4u DL066r6VR3XIG/C+Sg24kFJuumHjvTM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752655947; a=rsa-sha256; cv=none; b=PRNhiZvu2/AB1e0A2iqlaaiM7UjcXC1A5jtWmaVC5lFp/gbYyund9YaKIW8a/HTRunqLNB q9jTM0JfYPdc6fOer79manDDTMx0WLHGc49Qk0tTWuiYFgI6OXXECxCuWqdXUekj/dHF5I sFePviPwY6PHLjS37zFoIldl0Il8Hh0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EJiwx2++; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752655947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jDRDlU2q13d3K7zJcNpx9sql1ihNe5QWHWqfSe72+1s=; b=EJiwx2++t/HxjoacekkYpcOYW+WZpWDsC1raVHjkRpqXUiLX+yH9TppUep1sGcvsn/Jwr1 ZhXYUqly5bvqVK4jD81B9NT9I0x5vcm6cTktRpV7s2HuI6MHU/gxFR2Btw26gM+HM3U7IH p0ij3AooX4VeQaqLQbogmDpI1h7HmvI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-284-hVLjuuMMPeu6Wi7NVNPPiA-1; Wed, 16 Jul 2025 04:52:25 -0400 X-MC-Unique: hVLjuuMMPeu6Wi7NVNPPiA-1 X-Mimecast-MFC-AGG-ID: hVLjuuMMPeu6Wi7NVNPPiA_1752655944 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45600d19a2aso34257375e9.1 for ; Wed, 16 Jul 2025 01:52:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752655944; x=1753260744; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jDRDlU2q13d3K7zJcNpx9sql1ihNe5QWHWqfSe72+1s=; b=FYOYFOeaeYOAmBH99Qpp5rsDznfvXhpMzox4YgxEnVx9YE8vYecLetQLmZT4aPZFvb FrHI3ZXvLE3jE39iP6pv/SQ/DZStV0gxw/524ww/oaxUMLblc1ZiaRRnzgP2vogxzMBU W9ZEMuhlbSuh2U4xac2QfIq8wtK/FuaE7chHXvNXB+Lj+UsS1aeGMqVQUQJg0R2Hg0Jd 1mwwoA+OTs18QZZiqEJsCMXEP2QGNDO2XSVhX9BGsfGhxt1ozTZIGBO8bXjZopNTEFur /3N8oJmiky2b9S8a1Q15FunMIS+v5J1eH1RnVGgpR/1r1LkFzCQIU1oJFAp0SNo8AwT3 wGeg== X-Gm-Message-State: AOJu0Yw5TGNAFixPcKNW2aVRfV6Doxfl8SmBEgA8lB5cwZuyQ2QfVxjV L127iyRiatKm349fCWlkLrKZGNDr31hd58prOt62JYCOpK525rW3jkfAj7Vi8vbMqGZeERWrwfZ nzldbdyN6L17BQ6Zxl4ygjd5HSRuw0Yf9npZnSc4DUp64NJn5I8J7 X-Gm-Gg: ASbGnctxHk8eAOj5jOBv7wvE7SFEjvm9WyA38VfVU/Wg85WeikUavx9ZP+IGQ2qeaWx BCLLwMxslzUDRU2rF1I3RfzgpKDcBut/hnDBmLS8YjXTCmYtn3DkfidCkf+i/q0thw4PlUeAWH2 MllAHMP1y2RPfX9dZb5TnnpvWPznGRvN+V6cyfDVww+K8mvdcKtnFvXXSD9Ou8oj1VlK9pnYxXb UX0Ogyq3/pshi2xdnCaAb5rkMpTcXvMAPrsw2nZ5GJCBB+ZhDYEtswKGx5GUHfOzgJGiGd4+J60 3Yslc9Bboa1F5cFfGHfyVD2WEJL1/lt7KXC2OSBUjhlb8KXgwRcvd7Dd1a9CclgGnnozILsYfM0 x0V+wSTpeA/HZr7ShuDE15TkX/95bBCkvMgJLsMr3zTShivK0cbqWhHCjT0wwAkVf1Hg= X-Received: by 2002:a05:600c:6299:b0:456:dc0:7d4e with SMTP id 5b1f17b1804b1-4562e36c6demr18845795e9.18.1752655943934; Wed, 16 Jul 2025 01:52:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwx61bXoA08TlWvxHoybzHTNtkl106Lym6JU3ZRCruQJ2JWSfScq5Je0HudXuiB6iHVofavw== X-Received: by 2002:a05:600c:6299:b0:456:dc0:7d4e with SMTP id 5b1f17b1804b1-4562e36c6demr18845595e9.18.1752655943543; Wed, 16 Jul 2025 01:52:23 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1d:ed00:1769:dd7c:7208:eb33? (p200300d82f1ded001769dd7c7208eb33.dip0.t-ipconnect.de. [2003:d8:2f1d:ed00:1769:dd7c:7208:eb33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc3a62sm17057728f8f.40.2025.07.16.01.52.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 01:52:23 -0700 (PDT) Message-ID: Date: Wed, 16 Jul 2025 10:52:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] selftests/mm: check a valid fd with negative value To: Wei Yang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, Lorenzo Stoakes , Rik van Riel , "Liam R . Howlett" , Vlastimil Babka , Harry Yoo References: <20250716082710.2801-1-richard.weiyang@gmail.com> <20250716082710.2801-2-richard.weiyang@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250716082710.2801-2-richard.weiyang@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cwsaOeBuGfFvEQU7mhBCChQJPP6uO3lOU5Sq6fBYbjo_1752655944 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A2D921C0007 X-Stat-Signature: cy6z7a7ncyh54uwpi5ewtj8oqnhggexf X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752655947-168413 X-HE-Meta: U2FsdGVkX1/KURx4tDdP30SdSfac/vRDNc8mQywy/Ye1uxeVE2I/JcC6pUR+AjJU1u9I4CBZ0/60BfyRYf5sWwLrhN9+PIGc7xK8EPVeuashl98quc9VeWAXKKuK7/Bt4BE8LIdUEJ2qHqFQdIf2u3F01wRajovK8A4ixXWQuBNClngpy/xuNbQBU7MBsqzCTSkUq91so1tr46Ffj0CiHSl2VH0/xUhx7PkqgCVDvHsRTexnGezhj+GMVSoa7qEJgQLZQzX00Fl+R43cnUxNN9u3h/dykxfW0K/5imQfjNvPrNmCizIlu6UHjFn3GJYAKjFigt219N0iKnhlrJZNJUSW9MTq/atGOt+99z89JfF+tuLBLcv/WNBWp8L9NNqR+FGn/Bdrr2Gk4QMDiB5FiRA8yLfz5EriM4hd2PvZkGDk2QZgXV1AEwqpG6A0NhbbU4yFPjCsNI5E1LQof5M5+SslXlGPejIDtzBQSdmzCZfg1V7tJoajHwp2qFhshDVFDe8JA2wK4gvhbiIYXeoxRoGENKZKGENNQzLy5tEs1I1tJz8D97513lhwfSkOv8tLYmb3Z9niKxTWl7VHOpP+4znFvv8gu3swivgYar72ooJTFso7XDDPNwm2P4pUOBHrYpLmV/Q4vmbulDi6cTEkvVoLuoq6M37OfxnFPPt+qW/9F4t3E1O8Bmw8D3tJq8lEnUlworD5+nZK7JtDWSNogmCDG/G47capcCjo2OYLanDfzHqoQ/GuJ4V4TXU9kosf8YV/ZxMiGiWyMtOadhwU+iUTAd2c3i+42on51wNOeQIjTqKzoQskXYWdtDhRgrZZ44zlhew9uB/BWjhugWsuquEP8lXc7rgSq674wBlOssq96PND1dB0XxSqUBnJqhctSCkV32UdP2CkXklrxlS0uN3m4BC11PHnCgafUUQBurdUNqoje4bPgvJ/ybPzQs9ja16jkyAphxttn++Dy+3 Q64anzBy /fm+pUkYGWUPcWszFe8q98Efnpjj3g89y8X76FDvEJ9XfKaI4gGyUATyqg06D78ieNU73weG6sQeA+b7EZKhjoPadfCwd5QsifDMdQv75+xU5L4yHttcITDPoFqB3Dl4/+nYyGSb7pL1ARuRRbaZjVUw/+PBY7i7A3dEwpkYHBUrCcazikBTwx5WhJQLfa4ql0WE9foqdb1+JQj11dS4Mr5NRpNOt/0kYhMLiLwOcfMzbPFL7Ya+zSNdjZiFBeqa+SoSO8yS0THfcj4M8smvYDStxdpAAUoo5EZ4AaZRYaE+vbFhRq2I/1JVQZtUS1tMCmiTh/di8VKpak8M98fNzl92sl4oEDVuULm9mOEVWDt48kFYzErqLQniDUP9T8BuI8C0yu7VEegi/vnQ+K2MpRmL2VyO+Pr/O9gnld6+RRxwlnKGeWhQZbbkVYeO9e+P1JOkPzubZC47L5GXk6arJ/XVw121qJHE4icnLb7XxKC2O++D5ijbqTCzy6NILnrMUMwF5+NhzSsKDIOzpqP9iM+fgRP56KpuYwYPjag1s16VNqGzhmpfCCxF5hAaKLkGw4xkVrdFGP28n6wGBHbfuJuncQUdm+wgAzDcKB/URWFY3Kk5mgjFagMBorg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.07.25 10:27, Wei Yang wrote: > fd 0 is usually occupied by stdin, which is not expected to be returned > by open(). But 0 is still a valid fd. > > Check the valid fd with negative value like other places. > > Signed-off-by: Wei Yang > Cc: David Hildenbrand > Cc: Lorenzo Stoakes > Cc: Rik van Riel > Cc: Liam R. Howlett > Cc: Vlastimil Babka > Cc: Harry Yoo > --- > tools/testing/selftests/mm/ksm_functional_tests.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/testing/selftests/mm/ksm_functional_tests.c > index d8bd1911dfc0..6da5c3340e10 100644 > --- a/tools/testing/selftests/mm/ksm_functional_tests.c > +++ b/tools/testing/selftests/mm/ksm_functional_tests.c > @@ -81,7 +81,7 @@ static long get_my_ksm_zero_pages(void) > ssize_t read_size; > unsigned long my_ksm_zero_pages; > > - if (!proc_self_ksm_stat_fd) > + if (proc_self_ksm_stat_fd < 0) > return 0; Only test_unmerge_zero_pages() calls get_my_ksm_zero_pages(). And there, we have if (proc_self_ksm_stat_fd < 0) { ksft_test_result_skip("open(\"/proc/self/ksm_stat\") failed\n"); return; } As the fd is opened after others, we should never get fd=0. So probably, this should just be handled as part of factoring it out, no need for this change upfront AFAIKS. -- Cheers, David / dhildenb