From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D293BC54E4A for ; Thu, 7 Mar 2024 20:04:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65C096B028D; Thu, 7 Mar 2024 15:04:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 60C7F6B028E; Thu, 7 Mar 2024 15:04:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D4B06B0290; Thu, 7 Mar 2024 15:04:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3C16C6B028D for ; Thu, 7 Mar 2024 15:04:17 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F407B4127D for ; Thu, 7 Mar 2024 20:04:16 +0000 (UTC) X-FDA: 81871319712.07.A1120DB Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 69B47C000A for ; Thu, 7 Mar 2024 20:04:14 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=0zkhqM1U; spf=none (imf22.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709841855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SaP0wPXWBZG8b4HRDLlDNgk7gu+I9jcLT+KulgNLYzI=; b=NHJGmd2oAM3IxfU240JKNla3GPO3z+hZtPsjAAaA3P0+J5tT2QgC90trdofCzqWnb9nh4B IRMrwQ/vrIRUWIOyQe6iPZeXYoq2HgjqLEq7uxyM9S9wjrUDkr60KlAb/SKXBvX1TknfFc xYjPFphdC95qkaFCNydWNHCA4pNIZKI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709841855; a=rsa-sha256; cv=none; b=pVX6Ge+0DshWN6dwB5pFy/TmmJnv+FKwjj30+d79aQ+hxJZTNT+MMSEeqVap/cm6lh2+EH 487QEfpZPf3Jk6zD+iHSXZnSKOiHpDmMuRclsZFjQ7fGU/Cy5FGxCllMIyns6Tbc1+ZmiI nxwLofdCdPT5mAs02mBfPBs5GvheKyQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=0zkhqM1U; spf=none (imf22.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=SaP0wPXWBZG8b4HRDLlDNgk7gu+I9jcLT+KulgNLYzI=; b=0zkhqM1U6lVsrsNgtBsY5dv5rV 5XFxT2KzYbBohyMSuNEnlsTGejAHaJ2Y8Q5EIo8a1wmbaRR0LftydJAduTmr2VDL8PrMmdfKywY34 8m1RdoJUV/YH1zIcV+oQmCIlX75qb5v+Opa6Bt18zBVclIzpeY1VGlCP6klouMKDPt+szWBj200Ld DQMR2+GGfFPE1qqgWcW752+i3BXsIMjRqdnA9UAVZaG0a5RfV6HXnymi7FNNauMDAFUgCWzDBRV+7 1QPdn9xnz4uNv6GI4ouUzmO/HM/OpkYYY9UfN7oh3ZddPqZnujSncFTGSGKkCku8AAHci6MpRYJwn KFcmoSgQ==; Received: from [50.53.50.0] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1riJy9-00000006C66-0IYm; Thu, 07 Mar 2024 20:03:57 +0000 Message-ID: Date: Thu, 7 Mar 2024 12:03:54 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 37/37] memprofiling: Documentation Content-Language: en-US To: Kent Overstreet Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240306182440.2003814-1-surenb@google.com> <20240306182440.2003814-38-surenb@google.com> <10a95079-86e4-41bf-8e82-e387936c437d@infradead.org> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 69B47C000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: oeeunb4s6jx6xi7bo7eywg8dqu7gyq9r X-HE-Tag: 1709841854-960058 X-HE-Meta: U2FsdGVkX19QoA/zzqq06hUrEVwsh49DfjO2lL5SZp6HlQFK5n1ZCTRNak0qDlKuvAvmktnrA5vtbmfE14RNaNXPBXJTN48t1GRujE3gJ6HhJU4oQ8UWXbgu9tqzmA2L8HGvDHuOpDFcux0Mm3B/F5+u795tKSB+HS8ncRS7cZx63EDW70JDAl6e6E2nJ8lCyfm9PlPqQtl4ZHrIzi7HVGkuLZ58dIOXlL0d2El4awuKlL0WkXxWwcK2eYcS/u2HJm8sRwrSWA+unQu8lh/CXtSlKP0jMYtgJJctfi9bOm+CtJneQtfSW940Sje9TQNkAJ4hjoMf5rxeXJFZlvm+KsB68TRUa4dlWo/H8Xh98yQZEbl0SnmDbC1EMOuxDExfjk6twSSw5fl6ypl1wrqlF02LKLtj2H3H+2+c0lacDAiGNbbUR9s9RkmWfqmwuYBzhFX0XHmoqtdcANr3wIlYB5CIHRTzdrpKjHsfLJ7zreSbwIcPqhS/YTUmtx7o0XlOPl65ulcQV+fq3xteS9I1s1wtj1+k4U8cpT3T8DjCMScAtwzunTBsDAAtFPXrJjVZdh9y4CSeLlYkfbA/+lD/8hEnN27tscCLeiB/tfQXce6piJZBcuZYsXNB5rg4spFyOsiVZ7sj7BN8GCOGOPRprVZgYsXKoAO0v39TIS6D0JKKh5F/3C3tovxV8/tJCOow12uJUXCubWIShfk4JYUpVsE/3u/zOCAMNuw29w4A6Y+pBwVEDNO3ZoJqBuPW71aUuIlRPzjcJZGRwz3I/keq2FceIQCd7zouvshL1khBxTYhiy6VyZfFVoetiHJwnuimiFqryqvo+RrJy0XmKDePPwvCEMC0Nv4htppdnsERLgf54m/7biFqaXzeWbqt3s/Nafs0ZlmOCgvnFvN/NMn65cVkxWjnXiclbNZ9qQGDd4ZcLMKj0k5VlqspA7HYb20YtKdiU6vyGID8cPd0cO7 kdEDNmhO 26w9LDyta9d3dRMw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/7/24 10:17, Kent Overstreet wrote: > On Wed, Mar 06, 2024 at 07:18:57PM -0800, Randy Dunlap wrote: >> Hi, >> This includes some editing suggestions and some doc build fixes. >> >> [snip] >>> +=================== >>> +Theory of operation >>> +=================== >>> + >>> +Memory allocation profiling builds off of code tagging, which is a library for >>> +declaring static structs (that typcially describe a file and line number in >> >> typically >> >>> +some way, hence code tagging) and then finding and operating on them at runtime >> >> at runtime, >> >>> +- i.e. iterating over them to print them in debugfs/procfs. >> >> i.e., iterating > > i.e. latin id est, that is: grammatically my version is fine > Some of my web search hits say that a comma is required after "i.e.". At least one of them says that it is optional. And one says that it is not required in British English. But writing it with "that is": hence code tagging) and then finding and operating on them at runtime - that is iterating over them to print them in debugfs/procfs. is not good IMO. But it's your document. -- #Randy