From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0499CAC5B5 for ; Mon, 29 Sep 2025 10:21:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF6028E0012; Mon, 29 Sep 2025 06:21:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA50D8E0002; Mon, 29 Sep 2025 06:21:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C44D28E0012; Mon, 29 Sep 2025 06:21:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A48B68E0002 for ; Mon, 29 Sep 2025 06:21:19 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5349813A88C for ; Mon, 29 Sep 2025 10:21:19 +0000 (UTC) X-FDA: 83941895478.07.01772CF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id C17E3C0004 for ; Mon, 29 Sep 2025 10:21:16 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="I/2ztV8i"; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1759141277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z3YKN3zIRZfonnEHUxLu7FAkkWR5YdTCLJYZ6VEYM8Y=; b=Hj1DVARME5Nju32WuM95p+VUUSFxrTNrbwo1H9VH6RbP4N9tISH/KcHXXaQzSsKLkt96jy GbjzJMhRq9VtNgpeDhFF53ickcDSSMv0a4vjTl0shmpdporSX5+vqJP7XTr1SlParxUvxX Tv31+F5Wbr8OHkTMAuVftcrrbIapBdc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1759141277; a=rsa-sha256; cv=none; b=ZrfKu2wY9Tb7J5XagTtI1MIm+6adsqotzT1vjubRW0ME54gaj8HT1RKZJWnIEfVGp7Siwq bGMQG+6bUMTrbqC3tUv6tsGK9qwfcyl+a5p6QBA4StQ7O/WADLImQaT56SRHXMH5Baazh3 7l12bj2BCsIn/A8C+pMr2K00BO29Vvs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="I/2ztV8i"; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759141276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Z3YKN3zIRZfonnEHUxLu7FAkkWR5YdTCLJYZ6VEYM8Y=; b=I/2ztV8iLJgHykIkti2567/E+eovdeTL+W4TL7WAgUCJfirK80rfu/CuTT5D46iVNMZmwF MmSqUBpwb+9qpa1jCMdaxstQXFCas9ucWviQYe6QjfowCYv8FLMIEp5A+pfFVaE0IZw9qy JKxg2k511TiN57lChuu5Sb+ZYIm8oYI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-386-5cGpY31zP6KO-pkaxYxs1w-1; Mon, 29 Sep 2025 06:21:14 -0400 X-MC-Unique: 5cGpY31zP6KO-pkaxYxs1w-1 X-Mimecast-MFC-AGG-ID: 5cGpY31zP6KO-pkaxYxs1w_1759141273 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3ef21d77d2eso2377595f8f.1 for ; Mon, 29 Sep 2025 03:21:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759141273; x=1759746073; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z3YKN3zIRZfonnEHUxLu7FAkkWR5YdTCLJYZ6VEYM8Y=; b=bnb1+bdU6+gfoanbvRBEDh8LQb5VrWB/xBrzbfuV7Wlust4GZdFrhk6FjwhmqD6Zf3 9y9dE0Z+5cU3ic1iR6j5VsWdP4Uof8BowXxrVyX/lao/ox48GlximK7ZndMy2es7Vvz6 kpTEib2qlCRqxkRRa3Iu34+LnQo+l8YPcpHAm9LsscafPeSlyR1wKPX7Mk7vYiVCJwJ5 q+W8+ha/NOrWZkNA+dZS8hrpJQrg397xN0gHj/RY64OgUEYwlJfqtZ6A8E0O2yXMec7q sGi7d9ng7VTPlujzQhEpSsH0ALmN5EvXk8JNi0oX0DFbb7Eqv6UuJjmvcLSNn4GLlyCj rQTQ== X-Forwarded-Encrypted: i=1; AJvYcCWbOXvexa8FFQvZ4DAKiE/JDZYrOukH9VeEnb0rxGSmcKyd9PiNO4ATvL/XsegZItwEQXsW+9FOOg==@kvack.org X-Gm-Message-State: AOJu0YxfpzGmm9XZTo8YnkMtOQLibfU+fP3T44S3tKBnV+Sl1s0FTDKX TiV7ca0REMPVHWGVRVylV8tUgT5z8cVBqXx7xmDCZcRoElDKIU0hb0pUrRTHSPkCGGQNWGfVkft sfvtKBKi6xrTQMEoYtwQB6X8I9T0On95bPn+dgK3DDuROK1JyymEI X-Gm-Gg: ASbGnct0xp1Y6Exqhjb2d4GmwyZfJI7F0Zb4ZzOwDpqrP77bJ0X0TcR9q/JphB9InLn wA5/MJvK28bj1AqWopmKsa1JqZ+o53T4Io+Wor3GvEWZWbTIcAP6hu878rbdxZf47mehCPREXhx 06NTLpS6AujZ6R9kPi4/euYu1bN+uOBzY++t8TyBWkwHTsRH7nBlCf5ASeOTpQcsJA8ABY+EF/h 7srjzPrIV7KEx3cE7GPnmMJ9DCPZWAk0ktEgBKq2DrB0PUPopjHeDtmSFJoR+g6KWCQygog2gEr FBQjKgkgr9deGUxHr2ERCy26hjcAE0I/2jAor7wBKK5tDKyT5CAqvANsn9pDCvuJ0XJkGRFj X-Received: by 2002:a05:6000:2410:b0:3ec:d80d:e59b with SMTP id ffacd0b85a97d-40e4354d936mr17146000f8f.10.1759141273236; Mon, 29 Sep 2025 03:21:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHseD/VRuRD8/5XkmKc+WsswLQN2PeBfIKRcSn+dzEpfuntBaoyeW14SJHlBROwxevLjLT9Aw== X-Received: by 2002:a05:6000:2410:b0:3ec:d80d:e59b with SMTP id ffacd0b85a97d-40e4354d936mr17145899f8f.10.1759141272561; Mon, 29 Sep 2025 03:21:12 -0700 (PDT) Received: from [192.168.3.141] (p4ff1fa94.dip0.t-ipconnect.de. [79.241.250.148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fc5603161sm17745080f8f.35.2025.09.29.03.21.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Sep 2025 03:21:11 -0700 (PDT) Message-ID: Date: Mon, 29 Sep 2025 12:20:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 06/12] KVM: guest_memfd: add module param for disabling TLB flushing To: Patrick Roy , Will Deacon Cc: Dave Hansen , "Roy, Patrick" , "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oliver.upton@linux.dev" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "lorenzo.stoakes@oracle.com" , "Liam.Howlett@oracle.com" , "vbabka@suse.cz" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "song@kernel.org" , "jolsa@kernel.org" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "shuah@kernel.org" , "seanjc@google.com" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "Cali, Marco" , "Kalyazin, Nikita" , "Thomson, Jack" , "derekmn@amazon.co.uk" , "tabba@google.com" , "ackerleytng@google.com" References: <20250924151101.2225820-4-patrick.roy@campus.lmu.de> <20250924152214.7292-1-roypat@amazon.co.uk> <20250924152214.7292-3-roypat@amazon.co.uk> <82bff1c4-987f-46cb-833c-bd99eaa46e7a@intel.com> <5d11b5f7-3208-4ea8-bbff-f535cf62d576@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xtulb0GBg_iVOmDW1jRGdirOMUwHPJinERK-37vnkRI_1759141273 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: no6qqigjzpygpz4fyg5og7rr973omrqj X-Rspam-User: X-Rspamd-Queue-Id: C17E3C0004 X-Rspamd-Server: rspam10 X-HE-Tag: 1759141276-934977 X-HE-Meta: U2FsdGVkX18EKJxTuqj8lPqqH5wjvqudvKwfnEOBuF8imSImju9+pTJHyIp59+g3tM0jDGu3GKdA4HgjGjHKwORTHkl897PAS7nMoBqzBy0S3adMirIITb6NPVGVVU1vehyvugZ7OzXYA3Kfu58hgZ2/IsUmxj/RmS5Jldi5eilymO6ObLpp0etTVXFW1QE7Ir7pJ1L14T6kDhpmyvZQRvyUJEqBBToSsTY5AG1gJ2yYBO2YsB12P7f6J5lM5OUo3PdaasQL2idX96cy5XbZeyx7eSMH4MJNLxOTSW2plEQfGSVEbwZMWEe93HEJ3wRJ1M9btDDiZ92l4n5pAemGQXRclBMm3epZ6hgcZ6iZtktYrnxFvRnjEiFKb0+OT8hk6oVbgJpILFNBZKv1QKNmjBYA3TWc3Usjk7rNs9Heq+lXVj4oLjM5Rvbq2h6bSRi35riGY+V9JtIq6WnLDDJ965rqIdggvlO0tU3NqiFYopr9AdDS+fM/L+kBVxfARJ1y2Z8v8PY9HpnCgmz5zA/mMJbohLiCI0sDROym+io5D81HaiVcyfiF1BKRhI+AOstqhHFr3pZS2ddR7uSE+qsWRfdxar2x/gmTqP3xyXwpIg7SLk2YJ1aCggXiRZK0Mk1Sj7pz8MJ6nVp4ZYFkmvuNN+AGFUh9DPYiZKr+hzC6kJAy3B8VwUVCsQxBL8k7vBx7ujMSOxrGRMs5cmXUeajkH2Zsfni2D2Gnan2QgkPi37ZDaTOd4gnnaJLX4ALC6XQ3w6Gf60oaaZE6Cv7oAohW/gwwtybXBtJ4/9qgZm4BsyxWOv9KM7XsDj88Z+fmuxYjGsY5ag3xTCSWoElvF6w2BgS4vAKk1b+rPnWmCR9voLxNqxMyPtyL7db5dSPDRK2dgN95i9/e9C2KIC1HSBQAwpsSnRP2VA5B0RD4gpDv7kCk35hXitSx7KOtt2bOKwdrjzcCHCcBm77C3uVBtkD Nyg0N4RM t4kVBPigCdp4Y6ebgNT7d3o5suhYZs3rZEtmUm8mAy2N8o81zrVywbCo1MI2ta03Q1ArStHhEWlC8rmNd02DZ+QZ4JCGXXiSGs0K1E0cwIeulcVy4zDbMeZnwdurH6EHOtaakE6UuQYZrbHvOQzu9mw0XaSiLNAyJgnC2wn66d03fwksmryKyvTViK1g7oY1GyV2JmH9m6M7RihfLhWELNWWhy+37bTogn+sK80rxV6chwvq6VeblFI/NK781gxXQx/hZIVohYaYhLG1bFlW5vZ35fs0GJx+IElEHGSVn56rDle6LpXk7zb+b2K0Ysj+ACyFGLc5b06WqEvL+mmaUJb4yHiN1F1fTAp+NF0rR+2yNYJYAR50lzGNiNzc0lMVPDWx5d/8aDOSjuryFrR9KycPoXfJykzZDVlu58koLqr/+/8iKahBjS56SUm+otC+oxqhRFatMMJejDz8HCwsOGbMyWh8InXGlUi0jPLtgndencyFBYI3QJBcb5r6Kc08Xw7Xttij9K9sKfhm2BcQYgdOUFiwui6+5YON2HLYflBGu/ZyBlFzJSMKKPWSQeZ9syRPtbqAnowHWKmUMAoY9Vb7RTuQQ7YhcLAVRTwHqDW1c4pQ/OmNAmB0bcgZgFFYPlYMFox7nToGraqzjaluKDadqN8qg4kf1wEaXuivdK/KErJDrbPSokl0a5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.09.25 09:38, Patrick Roy wrote: > > > On Fri, 2025-09-26 at 21:09 +0100, David Hildenbrand wrote: >> On 26.09.25 12:53, Will Deacon wrote: >>> On Fri, Sep 26, 2025 at 10:46:15AM +0100, Patrick Roy wrote: >>>> >>>> >>>> On Thu, 2025-09-25 at 21:13 +0100, David Hildenbrand wrote: >>>>> On 25.09.25 21:59, Dave Hansen wrote: >>>>>> On 9/25/25 12:20, David Hildenbrand wrote: >>>>>>> On 25.09.25 20:27, Dave Hansen wrote: >>>>>>>> On 9/24/25 08:22, Roy, Patrick wrote: >>>>>>>>> Add an option to not perform TLB flushes after direct map manipulations. >>>>>>>> >>>>>>>> I'd really prefer this be left out for now. It's a massive can of worms. >>>>>>>> Let's agree on something that works and has well-defined behavior before >>>>>>>> we go breaking it on purpose. >>>>>>> >>>>>>> May I ask what the big concern here is? >>>>>> >>>>>> It's not a _big_ concern. >>>>> >>>>> Oh, I read "can of worms" and thought there is something seriously problematic :) >>>>> >>>>>> I just think we want to start on something >>>>>> like this as simple, secure, and deterministic as possible. >>>>> >>>>> Yes, I agree. And it should be the default. Less secure would have to be opt-in and documented thoroughly. >>>> >>>> Yes, I am definitely happy to have the 100% secure behavior be the >>>> default, and the skipping of TLB flushes be an opt-in, with thorough >>>> documentation! >>>> >>>> But I would like to include the "skip tlb flushes" option as part of >>>> this patch series straight away, because as I was alluding to in the >>>> commit message, with TLB flushes this is not usable for Firecracker for >>>> performance reasons :( >>> >>> I really don't want that option for arm64. If we're going to bother >>> unmapping from the linear map, we should invalidate the TLB. >> >> Reading "TLB flushes result in a up to 40x elongation of page faults in >> guest_memfd (scaling with the number of CPU cores), or a 5x elongation >> of memory population,", I can understand why one would want that optimization :) >> >> @Patrick, couldn't we use fallocate() to preallocate memory and batch the TLB flush within such an operation? >> >> That is, we wouldn't flush after each individual direct-map modification but after multiple ones part of a single operation like fallocate of a larger range. >> >> Likely wouldn't make all use cases happy. >> > > For Firecracker, we rely a lot on not preallocating _all_ VM memory, and > trying to ensure only the actual "working set" of a VM is faulted in (we > pack a lot more VMs onto a physical host than there is actual physical > memory available). For VMs that are restored from a snapshot, we know > pretty well what memory needs to be faulted in (that's where @Nikita's > write syscall comes in), so there we could try such an optimization. But > for everything else we very much rely on the on-demand nature of guest > memory allocation (and hence direct map removal). And even right now, > the long pole performance-wise are these on-demand faults, so really, we > don't want them to become even slower :( Makes sense. I guess even without support for large folios one could implement a kind of "fault" around: for example, on access to one addr, allocate+prepare all pages in the same 2 M chunk, flushing the tlb only once after adjusting all the direct map entries. > > Also, can we really batch multiple TLB flushes as you suggest? Even if > pages are at consecutive indices in guest_memfd, they're not guaranteed > to be continguous physically, e.g. we couldn't just coalesce multiple > TLB flushes into a single TLB flush of a larger range. Well, you there is the option on just flushing the complete tlb of course :) When trying to flush a range you would indeed run into the problem of flushing an ever growing range. > > There's probably other things we can try. Backing guest_memfd with > hugepages would reduce the number TLB flushes by 512x (although not all > users of Firecracker at Amazon [can] use hugepages). Right. > > And I do still wonder if it's possible to have "async TLB flushes" where > we simply don't wait for the IPI (x86 terminology, not sure what the > mechanism on arm64 is). Looking at > smp_call_function_many_cond()/invlpgb_kernel_range_flush() on x86, it > seems so? Although seems like on ARM it's actually just handled by a > single instruction (TLBI) and not some interprocess communication > thingy. Maybe there's a variant that's faster / better for this usecase? Right, some architectures (and IIRC also x86 with some extension) are able to flush remote TLBs without IPIs. Doing a quick search, there seems to be some research on async TLB flushing, e.g., [1]. In the context here, I wonder whether an async TLB flush would be significantly better than not doing an explicit TLB flush: in both cases, it's not really deterministic when the relevant TLB entries will vanish: with the async variant it might happen faster on average I guess. [1] https://cs.yale.edu/homes/abhishek/kumar-taco20.pdf -- Cheers David / dhildenb