From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C84C47DB3 for ; Tue, 30 Jan 2024 03:39:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 798CA6B0098; Mon, 29 Jan 2024 22:39:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 747126B009E; Mon, 29 Jan 2024 22:39:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E8BB6B009B; Mon, 29 Jan 2024 22:39:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 49C3A6B00B5 for ; Mon, 29 Jan 2024 22:39:08 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 24F478030A for ; Tue, 30 Jan 2024 03:39:08 +0000 (UTC) X-FDA: 81734571576.12.3E14D29 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) by imf07.hostedemail.com (Postfix) with ESMTP id 4F29340017 for ; Tue, 30 Jan 2024 03:39:06 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="GEC/T/ea"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf07.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.161.41 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706585946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=00lo/QjQQeVff3/KwlNH4541JlMutDM7rW2whSJGlac=; b=aHKXBMOlgM9qMw7Z8q06wjGIlO6w/LC7WQXWAfq5XMLTPUwVq4VODOob7bUcPGPtZVgr0n RK5LtI5TIaVBsAQq7fEWLVX/aSQZaa4gAAogiObBr0JO+hOwlg2ZSNBGhDo1HjLIQLcOwD lxhjM+z2bvvpS81P7HLLPNXY/BY07R4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="GEC/T/ea"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf07.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.161.41 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706585946; a=rsa-sha256; cv=none; b=vFV+uwoGPzRKF7At7yp9Y88Jaf8CWygrVGILdyVycADt9nnso4o9GY0Gtd3BrxLedPZnJR 0erEzaNdLtu4aunIVQYbB9OYI1tex3ZwuM8VlAuuC7lOyZ3MIhERT0Y43J5dNgwT6GXtgf 0egc9CPe7hcDs8++TAOPX/mprt5KzCs= Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-59a0b253836so1494085eaf.0 for ; Mon, 29 Jan 2024 19:39:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1706585945; x=1707190745; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=00lo/QjQQeVff3/KwlNH4541JlMutDM7rW2whSJGlac=; b=GEC/T/ean70H3codN6k2P23WtzBQkiwcQEEXChU0sdoOZhlm9cTOFrlMlvZF/kr2TP cWnnRzgWJvbCJMTKtEgTnU3PYQRmhMTv5ePGcT5313dGiAJe27il+jvvWRMENq+OiPHK lbatkTKXS9FA03NgqRISCVidghsXupy28S+8C7qdobf7CI+w/wZ7ROgnBxsYE93nkx4u 20YmxJxWPq1zG5WCv90/PIxZDhfSl3XP9Y/v3M5ECQh+GMUicm1WcfMVb9LY60f3cvVA j37IVxnD0EA5WGIhj1d9z+PSr2vk+4yz4NFATvpYYaUJvdB06ZCYoAZxdXG+EgCQtlxj vT3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706585945; x=1707190745; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=00lo/QjQQeVff3/KwlNH4541JlMutDM7rW2whSJGlac=; b=M0CQAJa9YoW1cxUODGeIT3I0uEfLYa6WUWOPGuDZ7w1HfE4MQ8LT9Dn54QtIFFf+0V 8KRGENsIx7iq1ctmNW+6KFMoyhXq7B6Rb3lFwrs+y+4Gr54qtfaDvIE6JvviyW5IKEo6 Oj1cdP9SaqBAi+BIB5rwR1g+R+YY3cpMDvGdyIvjlE1MhE+kZh7582OtwcMjUZ1D1fgD sELe5cHFaN557CC4i8lAnK4q5T3Q6Oili28DvgM6Y2f3UdDSBIE/5RhkDAv3n/xcPEIi QePKHMTkzQdHW+GO7rVNU/PRBpWhOPb14LgEfpcK31JB+OOcfp3pOTa42K7BaOhlk2VJ cM2g== X-Gm-Message-State: AOJu0YyQqo+DGB/AIbnLrnnsX5Sf2YeifxNAQERHZtTNAv9dQq+bZgEL 70PaP60rfZ3fdd2pf1m4SEx5aloEPOtfE5x7brruJl5hvU0ny+Lb9+5sVzr1KA0= X-Google-Smtp-Source: AGHT+IEay3Qyiuk94oPutgEb+dSLkLHlgffqFbi5L8ehUfVRL9zNUJteBJfej28RaJHDEwC19jQXYw== X-Received: by 2002:a05:6358:4411:b0:176:92d1:568f with SMTP id z17-20020a056358441100b0017692d1568fmr4719844rwc.18.1706585945382; Mon, 29 Jan 2024 19:39:05 -0800 (PST) Received: from [10.4.207.234] ([139.177.225.234]) by smtp.gmail.com with ESMTPSA id y17-20020a63b511000000b005d8b481c4d3sm5561909pge.87.2024.01.29.19.39.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 19:39:05 -0800 (PST) Message-ID: Date: Tue, 30 Jan 2024 11:39:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [External] [PATCH 04/20] mm: zswap: warn when referencing a dead entry Content-Language: en-US To: Johannes Weiner , Andrew Morton Cc: Nhat Pham , Yosry Ahmed , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-5-hannes@cmpxchg.org> From: Chengming Zhou In-Reply-To: <20240130014208.565554-5-hannes@cmpxchg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4F29340017 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 6h5i47sartf4poyi1ypfcr9ddgnwwpmr X-HE-Tag: 1706585946-774500 X-HE-Meta: U2FsdGVkX1/0X1RvrDKilVwoI9BLy5MjKTrB1bFhet99CEsIfvm/VvzdgOCtrzqds4vVMWoTVDc9JAvULNZb+/zOQFxXJViHrzAJ5CY7eEqjx22xkqqW75WEByGsb/8+ziqqr79HxQkS3RKuI/yh6sr0+cvu55q27IW6tK7uuP6lWXXVNGJaFypAJOF4FUCBnOfOFc4w7SMqYtWpGrwoeUNTqCLFPo4k+HYajEFzZP86vLmsbJwyLauseNmBkEQdyfc5eBbBJ/XmzkjrG6mT1jFmO5DhQVED+x3SYD3Oh3UNQ66eGwyoPGNeykzUKK6sya3lEadZTRRJyj9LSpvsKFMH72vQpLueLkSkFJqs4GyD8CVtNDUE9Z7Brskyp0TC8W/b9D6MjbRVtoqknC1KSs4Q0E0pTkA1xVFLXyONmrW6Pedfar1gt5VHlZ6T+LitGU31pZPHPnAfSiTSFxuJ2XM2mXWS77+fg/+NuqPg0HYpwdwrc6WOPKFDCEqrE2vW09B9zEDa/1kkXXxvaoTMxpxsNbETyk7vJNkfSTqQuKmxqBemEYTJcebIqUFglUa2X5e7CcKo16vOTs3UwOVasjg/NrY6p8Rt1bTTv6zesJfY26uEI3zKoH+TxVmge2lakuxQiOp9QTpG6LugTslGi+bPfGYx5FCIGvzPhKIC7gWXLs5klpf37iRZbxglnJjbR6fW5oKR1um3Z63fKpF+Q+nr8Nxx0Kl757MB4J5jQZ+d84VW3y19G0YheghnigtvGm70IY+TJ0ID3AE3vSuwwJtF2B83FqL0aOFX6CZsWAJE06Ib12FQCUqga02yYN8Efp5yVCJ7DmiQ8d+SEqtKEqiGIwV7S5BKFBEY+ckae4L6lxjCKLTuAHRS6J0obdPH+a+hzEpUrdVnAsbhYXhebaKJkbXnf9FMyYM/8ZDEWgy1KUhWyUSPot4/T2jQbYxO4tG1jsy3Z/G9YA0psC/ M28WIWkS W46xv9i0xnyh99124odFJ4NIlVcrmz6XG77S3PmWj/4lrgn6mUJwEfNDoGrecH65/TFwAc33K70jLd0ewP6pDRCIQ9X3DZkmJye3i0raSydLhBTTCUqNVlChyLuq9CeU8e7maAGGMJzAwNzTGc+qdrbJkkOjZRAU0fA/1YZw7gZ3uY3bFIU+48keysD2XR6/8l94fQRzWvUmU6VoKPwkyzWsdw9XnZHVGM+f1H+wFKIOvaFoioquk+pkuRbAIV9yuyMHS7Kv7YZVLerxdZMYv9SOpc5iQmyGydsT8bwqlveYW8S4sarCbyYJ/yDYyoZQ48jCB95QugDHTbtyZcv+HOrtJgDVwu5yAwFaKoqWuU8SPBMkiLr8gVvdICbNJmEq3gS8JxfBK5q7JtPHGxO1K53KsH07pNENnOFPZ5YMkEt9P/iVBHa0TE4TvmFXSqLEzlaYltaUYjfZnzRwf0lnVFkGd0KeGjTFsma9AqjyHSuiSileaBmw2fu/sq23ZAXPaU0aR1X0uYxE7RO0onLR/4qn9X7/lmHdaspfj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/30 09:36, Johannes Weiner wrote: > Put a standard sanity check on zswap_entry_get() for UAF scenario. > > Signed-off-by: Johannes Weiner Reviewed-by: Chengming Zhou > --- > mm/zswap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 9f05282efe3c..0c6adaf2fdb6 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -542,6 +542,7 @@ static void zswap_entry_free(struct zswap_entry *entry) > /* caller must hold the tree lock */ > static void zswap_entry_get(struct zswap_entry *entry) > { > + WARN_ON_ONCE(!entry->refcount); > entry->refcount++; > } >