From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3E3BC3DA4A for ; Tue, 20 Aug 2024 08:15:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3223C6B007B; Tue, 20 Aug 2024 04:15:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D1D86B0082; Tue, 20 Aug 2024 04:15:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 172566B0083; Tue, 20 Aug 2024 04:15:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ECF026B007B for ; Tue, 20 Aug 2024 04:15:36 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3D1D31218A4 for ; Tue, 20 Aug 2024 08:15:36 +0000 (UTC) X-FDA: 82471914672.01.25B536E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 0A1B510001E for ; Tue, 20 Aug 2024 08:15:33 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=G5or6Ia1; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724141694; a=rsa-sha256; cv=none; b=hC2yztP6k2hrD/6VF+ip2WxxKysMaA1wRYY2WCmYD41bwFVfVBvUe+wGUrWm3CmUCrIRrk vKoi4uX1vb0eETvZDbEI/ACxJiCTWrh/OAGABss09DSD9N08eztVKs9qayCsLgZjT39VpD AWpK5aAPp2estXNlFhGWVQl/m+CXTh4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=G5or6Ia1; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724141694; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9amrvqS31P2ey+4yHRJ1V8LdGDFGb3mu9Q16JPVzu2A=; b=hh17HSMSaScz0LVONsMvf5Z8fwmVrGFhrBe6obhIGrKc1Z5AQIDXZasfRQk/88g7au28Z1 7cH1NVHJ7afVHGz91vzFwbuFYh8vT1LVIyWoQcYD+x0RqddTqcsNbhCU9xB6bKkU1Rz46U jVJGVTb+I6R+egHJx3Fgcq9crng4NuA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724141733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9amrvqS31P2ey+4yHRJ1V8LdGDFGb3mu9Q16JPVzu2A=; b=G5or6Ia1WvEchLstaggFzUR6lnSU7XyrcKKYoY9DzxAexC/gblSKZuadfjAvXqbXgj+wgR eTSyavf8wbYRm7H/oks5I3e7d3kRUUBX92wwBhI4Hk18z+IaMOGi5v8ZZ5Xz7O8qhVZbTq Gc1mZiXoXPcw5hQ3GYvCV9bVrhZOIFY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-gDD9XaUAPe6dWqqPA2IHMQ-1; Tue, 20 Aug 2024 04:15:31 -0400 X-MC-Unique: gDD9XaUAPe6dWqqPA2IHMQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37197b9e1ceso2444595f8f.1 for ; Tue, 20 Aug 2024 01:15:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724141730; x=1724746530; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9amrvqS31P2ey+4yHRJ1V8LdGDFGb3mu9Q16JPVzu2A=; b=Wv/OtTk3JZ7Bc83FDUXAcWB27VhXmkr9rnD+x/HhJCcnAL/agh7dCwAn3N1EhQ864s zTgjaPtk0yginkYqzqbqvZrpbCGA3jRuV6vbqKmrEridjwatx0WpdEQDDudEkR1TS7Qn 70XJqjFFuWoDw9KBv2ZNaiuV52mSx704ug8v8btTzOvAfWC5q5XPDgZUt+iEPG63KnZB vI2ZFXb6fd4AbmViKWIhKtim9264XYOWFx2qzlBHCO6zgEjbz5eZjTnfcwA6oxlUBbif 5Mq+LTPDUsS8/ndGh7szd/Rv08ibtNiTidiAjEh9RKG643M9ogNlSwHitg0DMh5Jhso0 FShw== X-Forwarded-Encrypted: i=1; AJvYcCW2C5T0/JP6K2PNT2r0EUaNerjZLean3oRLmYFuiXRLQ0Rjr7xYRt9XElbTKw26rBzjIj0kFQFCwQ==@kvack.org X-Gm-Message-State: AOJu0Ywp1bumPDVcvdCeiWYD7mJGB9tGyUk1G6hjbq9BptMEGn0azkwj VL2rBnQGYGsyf3uuRE0VBWDCx86rx1YpRwnL0KXxpfwWPyATQvf6wH8Tj8ZGx1VXz+IihGmPtnw gTqJmmAtyUQRlOUAcPTCl4X3qHKeIZMIKXYMY+yFYbQx8iO9e X-Received: by 2002:a5d:484d:0:b0:371:7c68:7cf2 with SMTP id ffacd0b85a97d-371946be9efmr6916742f8f.50.1724141730697; Tue, 20 Aug 2024 01:15:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG132/sePCwFNYLA9Dw+tXLfuZhVg26rpJdxruG5iN9lelpEYruL39IDbMxnWZsARoKdfVrgw== X-Received: by 2002:a5d:484d:0:b0:371:7c68:7cf2 with SMTP id ffacd0b85a97d-371946be9efmr6916721f8f.50.1724141729947; Tue, 20 Aug 2024 01:15:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:e00:9c12:cdf2:bf1c:b8ed? (p200300cbc74b0e009c12cdf2bf1cb8ed.dip0.t-ipconnect.de. [2003:cb:c74b:e00:9c12:cdf2:bf1c:b8ed]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37189897128sm12505656f8f.81.2024.08.20.01.15.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 01:15:29 -0700 (PDT) Message-ID: Date: Tue, 20 Aug 2024 10:15:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] mm: override mTHP "enabled" defaults at kernel cmdline To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, corbet@lwn.net, ioworker0@gmail.com, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, v-songbaohua@oppo.com References: <20240817045516.58037-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: fzn343rpzftin3t66861uxugj9xxmeiz X-Rspamd-Queue-Id: 0A1B510001E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724141733-278981 X-HE-Meta: U2FsdGVkX1/rAi8h4AmLhNoxDP9KQo4xNixu521YMZqQQM/Bgn5F+ydhrPhZKsxGcc5fRct1AIF8bg5a/R33oEELqWdgjmolR1MtY9KTaawyFeYLMCIPxrxvWvWy7OkPmPhNKWFvV/lJEQupyUV9I7Kladq+J6I1Si5OntBJ/ajTUFJmyygyKVJuYGHv4mvzemsLNBtIZSK9NUoQLkAsdRfCheoaEn+ZqV8LAq0IgxIE1OsRYVa25r8IVULKMDMe4zA7sHO7GxYT9UQOQ1GQQTDVIsB/B2jQl6arrBDv8gUtsIOaCSoQCCoudFnqhFAJi4qGX9CfLLLqNCw/WGM03eRHjLpkz/kRlBh0nAHs4QoRhSr2v3naQ3l1Kt0d5My1PGbsHYuKSTx0xiB3JU26AoUR775vgIdy/nz7phqlm98Xr+x2m70YZtdHoJlzXs8IARqO2VXwnkTbI2Y9tI+Ihf7+ShrMmSIfC6sYOcPGYHCCoYl2RQIY1CkvqTA9erggHe38vbvE5gcL6lYpOSC/Yopc9r+9ZG7JGzQsJx8SG347WyAkJJqKsPf4Slj5YLOpeXSEoc05iLdn6xEMsYpUkdBPF83BhzNJ8z+IBURE0J27izXEXEwGrBj5urlTzZgsu8T6OBAt8Pf3sc4IftUq+Pr5MqGklCGPP7RrEnuMxqPPYoftHvIXnEvQ6N0+J9OZjZ39YdXVUGwZU3SQX4uXsLNT5UZ9PvaVHmB1S5rFi5YSw3sgIp/7Y0SQgeDRycuSZCjPjm5IoZrlSGw1Qfvv9TSNZ0cNW1/D/7KpX69QimtPu178ilM7r4lfKirKOWHRCgFHOF3NHPX8IVSg3KXoJGkptts+4qSuNSS7l8/T64YUn83XX9h3V1ByaoAmjHwy1rixCvwklgHQ1Mi5vnE1UC6krkWRd2dA+KQ7c9BQpSmm9ux9Gf+vO8EC3Xq5kxsGhhfMhu7r6w+ZGGbMJq3 hpg1ANpB WLGin+TEoG9dqKubUOa561hhSMLhMxVQVoAlvUWIxwqDNiCBeVnptfBDrecx0xbuLDEDZf4szr+xaUvTgtp3gkb+WDU9DBZgytJENGW1wJFnzSrlb5SMWQfEDRWmRASSW21/TOgZliizdlhYHaxNqt2jtyAoP2FMgaF2tr3VJ9yqPlzxHp3otbQoEMWjrLilzT2qO3oAB2gA03ruXEV0kFlGzKJ/VR/esL92GiatrF3Cmx1Czw8+JZy//abJbrq+7grK6RigZAbw9voCQEcLJHY7NfERUO8eVWLd8OC18swyZuxqCZcSxlg1mpqFCc1GxRscQVlefjg5NH8bon2QDlppRCgHW0dyV2swQDqRqzc2hZwDmtDGAmKkflA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: long __thp_vma_allowable_orders(struct vm_area_struct *vma,>>> unsigned long vm_flags, >>> @@ -756,7 +757,10 @@ static int __init hugepage_init_sysfs(struct kobject **hugepage_kobj) >>> * disable all other sizes. powerpc's PMD_ORDER isn't a compile-time >>> * constant so we have to do this here. >>> */ >>> - huge_anon_orders_inherit = BIT(PMD_ORDER); >>> + if (!anon_orders_configured) { >>> + huge_anon_orders_inherit = BIT(PMD_ORDER); >>> + anon_orders_configured = true; > > I realized this is redundant since anon_orders_configured won't be > accessed later. > so i would like to also drop "anon_orders_configured = true" in v6. Makes sense. >>> +static char str_dup[PAGE_SIZE] __initdata; >>> +static int __init setup_thp_anon(char *str) >>> +{ >>> + char *token, *range, *policy, *subtoken; >>> + unsigned long always, inherit, madvise; >>> + char *start_size, *end_size; >>> + int start, end, nr; >>> + char *p; >>> + >>> + if (!str || strlen(str) + 1 > PAGE_SIZE) >>> + goto err; >>> + strcpy(str_dup, str); >>> + >>> + always = huge_anon_orders_always; >>> + madvise = huge_anon_orders_madvise; >>> + inherit = huge_anon_orders_inherit; >> >> Should we only pickup these values if "anon_orders_configured", >> otherwise start with 0? Likely that's implicit right now. > > My point is that, initially, those values are always 0, so copying > them won't cause any issues. Right, it's more a conceptual thing: on the first cmdline configuration, we start from scratch. Afterwards we start with the state that the previous configuration left behind. I'm fine with leaving it as is as well, whatever you prefer. -- Cheers, David / dhildenb