From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECC4BCA0FFE for ; Tue, 2 Sep 2025 07:02:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47F928E0007; Tue, 2 Sep 2025 03:02:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 408DD8E0001; Tue, 2 Sep 2025 03:02:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A9C78E0007; Tue, 2 Sep 2025 03:02:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1381C8E0001 for ; Tue, 2 Sep 2025 03:02:52 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A668513B6A4 for ; Tue, 2 Sep 2025 07:02:51 +0000 (UTC) X-FDA: 83843417742.18.21A6A24 Received: from smtp-out3.simply.com (smtp-out3.simply.com [94.231.106.210]) by imf30.hostedemail.com (Postfix) with ESMTP id 9CA6C8000E for ; Tue, 2 Sep 2025 07:02:49 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none ("invalid DKIM record") header.d=gaisler.com header.s=simplycom2 header.b=XV9R3DCg; dmarc=pass (policy=none) header.from=gaisler.com; spf=pass (imf30.hostedemail.com: domain of andreas@gaisler.com designates 94.231.106.210 as permitted sender) smtp.mailfrom=andreas@gaisler.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1756796570; a=rsa-sha256; cv=none; b=nsHmATEgFntTr2jJV+TnjY7KDzXvy74ijyULDO12HxZ7Wki+Pv9lTRDaWTBKzHf8j0cfcn jzssXF4DwMf0b5esbXrU2Nu4oy3knq68g3a+qQEiCLw5nzWsqezuzy2YfZvsTfUvPGJmKH iLLmPohfKjgIdJN+hOdktWA6/sdgJX8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none ("invalid DKIM record") header.d=gaisler.com header.s=simplycom2 header.b=XV9R3DCg; dmarc=pass (policy=none) header.from=gaisler.com; spf=pass (imf30.hostedemail.com: domain of andreas@gaisler.com designates 94.231.106.210 as permitted sender) smtp.mailfrom=andreas@gaisler.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1756796570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h7e86hl0UV9Yd9fEU7lHS/lq+4/qNkF5NKsTGqMW0Gs=; b=YmfLoYFFUxxwF6SyhCWZAvVZI138c0jfoArHS/z3S2Fz3DprmHgfc3KVUGVz6Y8Ylhc7Re 3H8oQwl0D5oxQ8Gc+fLH69looscP7Y+Dyi5mHx/csgRRa0JJ/6YUrlluRPVz7KXS8Pb1g5 3MkwzTtssvwi1M606dhpl7wudP3Ww+4= Received: from localhost (localhost [127.0.0.1]) by smtp.simply.com (Simply.com) with ESMTP id 4cGGsM6JC5z1DPkm; Tue, 2 Sep 2025 09:02:47 +0200 (CEST) Received: from [192.168.0.25] (h-98-128-223-123.NA.cust.bahnhof.se [98.128.223.123]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by smtp.simply.com (Simply.com) with ESMTPSA id 4cGGsH2GP0z1FXjK; Tue, 2 Sep 2025 09:02:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gaisler.com; s=simplycom2; t=1756796567; bh=h7e86hl0UV9Yd9fEU7lHS/lq+4/qNkF5NKsTGqMW0Gs=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=XV9R3DCgzqtpsDdLU5B6YmrRSDSwOb/e+RN3Y/eiKzfpmARJpEfk4rM3nFZX0bFUT Cgk+F60Qfnp/lcw23nKISESK50dxfqXIzcv7lABAQzI+QL2HTB89cK9os+EVA7PGjD 2JhF3WzYfsb9MEQHgbmUEpzjWOe7UaJDN1f3QJPTIjlP5MtBhYOcxRaj/x5aIgyAIx VylpL5fKm3LmJNVO1eTnB/fXzhohsODH/8iwc5vr/F7Q+FJODNFYRjy3a+H0jjVZXA zhn5kjjNaRe2tU3x5rK51dkv4aqaegmt92utDpWIUQsQcnBLirXe5OB9CcfJT7NVBK WwxEwsTBW60LQ== Message-ID: Date: Tue, 2 Sep 2025 09:02:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] arch: copy_thread: pass clone_flags as u64 To: schuster.simon@siemens-energy.com, Dinh Nguyen , Christian Brauner , Arnd Bergmann , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Kees Cook , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Guo Ren , Oleg Nesterov , Jens Axboe , Alexander Viro , Jan Kara , Tejun Heo , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Paul Moore , Serge Hallyn , James Morris , "Serge E. Hallyn" , Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner , Masami Hiramatsu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , John Johansen , Stephen Smalley , Ondrej Mosnacek , Kentaro Takeda , Tetsuo Handa , Richard Henderson , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Brian Cain , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Richard Weinberger , Anton Ivanov , Johannes Berg , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Chris Zankel , Max Filippov Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-csky@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-security-module@vger.kernel.org, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, apparmor@lists.ubuntu.com, selinux@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org References: <20250901-nios2-implement-clone3-v2-0-53fcf5577d57@siemens-energy.com> <20250901-nios2-implement-clone3-v2-3-53fcf5577d57@siemens-energy.com> Content-Language: en-US From: Andreas Larsson In-Reply-To: <20250901-nios2-implement-clone3-v2-3-53fcf5577d57@siemens-energy.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9CA6C8000E X-Stat-Signature: wm6ndyqe7srih3o3a85hgj3qzift6ecc X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1756796569-526701 X-HE-Meta: U2FsdGVkX18p0t4CASw7VkB7LC5wwd2mPnnTARacRO1Gdx6Jd/nV6lpfUCZMzrvdMmQvViwxL8yPAnq5UH/rYQ2F9Xdv6l+LAreSVLN2+1lub6taap8ABCnR99Zo/8yLKPxOMIHOhkafuhPi9C1PcsHrpaay9AU3kAyxq+LUm0XTv9sXBQ5Esu8ANA4nDT0CVubDmZotZLeWAQ0mrZ+VvDebHJNThTUFheywRxT2eGY6EwlUD+wTGZkZDI8esZBz8HxJk15jEdDxHWCoHMXTnXTwg+TfejNX2Jmck7gr3CuG1OBHh2mvJ5gzPzqHSkFLz2GI4gm1kfHuPI5PmCX7OjR2DrdgO2qN9ojvBYvu8XDeBzuN928hF+cFQQVLfNx2W1NQ1eSKny+svQ91YdSZOg4WsqrsedQMDLsS26JVR840lS6ApTfyMnnFQiHnG/nqSXQpwnZM12YSj1mg4vJYPNw44wqssicco427IH8t4bo4TVXZW8kfw9TzxIMmj9qmMRZUBrVejrJS8EkgrswlZZdON34uLJZOpkSWNmkfL/qOGB9JB8/tpvnB6UehrWhxiit2EII+TdnLkQDCuEkpuaiAhK7ELyMC1qe+GD+dEyigdNuM0DBBctbPbpCUStya/sbIzn/JVK5Lj5Hk5H0h4MZOYMfv4A7l6kV8A6xnm4a4VpZ3cfIuybLmubyuKoeIzGRBNvqTs4NQOHEr+t2QAv2tUToQWahP4lvyAoDzV9YAoCXgU2TK2wZzf1Njg9DZXOLgvdRrCdE/TVVSY86QoEizuoVbuGjDXjKEbv/Jf3knHjnmSlOxFD9x+biSL6w1ayMw+AnVCwfy6QhhH/ROd1aF2YSGY4txi6HW/g20LflU3Cz6pBD+HFgLxYhrnEY3pg4COz4TmZDGbCPTdM8RXBX1o/eq4GVyBEVhH9kEjpF3ZlawDKY6xLfE4yEz90s0nfMRa6WCVFPVf76o68r Qcp0RCwx S+9xRX49myeZjHSBZ8+YO74HmJf3MPg3SWdXZ7ggtYSfztt3YBEZPNF66N4MGK3KaRgBt3m0R0mVdZGOYBqbPPlvM940CIxkRsA9q52RioGmKWqsP1JSfQbl9zzZFkInqsxvKcKfRt8tD5CufIHPvy1b5aELMfzLV14lWc/9q7sKUcijmokyfgsfEmjvJyQwuZcwf3j4LdSnqJjjQ+zHpouHIgnabn4P3yVc5b6UIGNaMQ8A96S/rbpTxGg6dqZ0bgLaj/Im2/RyEZ5VpyiinKqW/9LADvedYLWMyZlN4P2Djnyn+t8JcGqUdeuEqWcaR+oYk4Lx6hi4gBRKUdaqktdQp/ROz5MCUpE9gfG5zBqamEAwaPc7VdK6vEVlbVUVWjpVLNVQKCVz/vz/PE9cH6zJLWmWyvxTt39D5vMCnPdn60Gf9ISh1SGmaZEPhldQo3Angoyr24LAdIF7u3oqgTmCea7VbUZS1bKmCp4Q8wtwdslOIrwN+fPzTwgUE4ZaCM9HZlHMTPLNnv/yKgIq31+obcqMQGnu5IsWV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-09-01 15:09, Simon Schuster via B4 Relay wrote: > From: Simon Schuster > > With the introduction of clone3 in commit 7f192e3cd316 ("fork: add > clone3") the effective bit width of clone_flags on all architectures was > increased from 32-bit to 64-bit, with a new type of u64 for the flags. > However, for most consumers of clone_flags the interface was not > changed from the previous type of unsigned long. > > While this works fine as long as none of the new 64-bit flag bits > (CLONE_CLEAR_SIGHAND and CLONE_INTO_CGROUP) are evaluated, this is still > undesirable in terms of the principle of least surprise. > > Thus, this commit fixes all relevant interfaces of the copy_thread > function that is called from copy_process to consistently pass > clone_flags as u64, so that no truncation to 32-bit integers occurs on > 32-bit architectures. > > Signed-off-by: Simon Schuster > --- Thanks for this and for the whole series! Needed foundation for a sparc32 clone3 implementation as well. > arch/sparc/kernel/process_32.c | 2 +- > arch/sparc/kernel/process_64.c | 2 +- Acked-by: Andreas Larsson # sparc Cheers, Andreas