From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 926E4CD4F4E for ; Thu, 5 Sep 2024 01:26:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0777C6B009C; Wed, 4 Sep 2024 21:26:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 027206B00CD; Wed, 4 Sep 2024 21:26:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E31FF6B00D2; Wed, 4 Sep 2024 21:26:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C31CC6B009C for ; Wed, 4 Sep 2024 21:26:54 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3DC32407C4 for ; Thu, 5 Sep 2024 01:26:54 +0000 (UTC) X-FDA: 82528945548.09.F7295D6 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf29.hostedemail.com (Postfix) with ESMTP id D06FB12001E for ; Thu, 5 Sep 2024 01:26:51 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725499587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6DySeCvUDK6G6kchhgaYkEHLcdxcE3urWcMk7oUumos=; b=O0A0SuUgYrRzNKSwa0aljdElBFC2kNzMXyOGK1NPfNYOzfHpDJk+ly1XQmJiVhnPDfYnlW zOOaVEhucSSERYFI3KQslEh1RbR9ZD1AkZxmuLls4tJvorDl/zxsAhuC4PaREN0KvBquFD n8LN5tulTpiQCkQ9dKzHnvaWYmEHGYo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725499587; a=rsa-sha256; cv=none; b=hvKdpHG6kYnM0PdOGrZngMQpd7KsOctfErxtkyifh6ieRR/Cnc7Q3oZlPsneHUllMeEiCK hlMwMsUM6ib7T1+8Fq+8LUIPuLBuMM+ypzIy9lQ1U86GHAnERzHKyZoiYKUEYTv329sk8b Tf3u5hkQzrqk1DMZFkAcExzHOuwekZs= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4WzhXL6Nmbz2DblQ; Thu, 5 Sep 2024 09:26:26 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 0BDF11A016C; Thu, 5 Sep 2024 09:26:48 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 5 Sep 2024 09:26:47 +0800 Message-ID: Date: Thu, 5 Sep 2024 09:26:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: migrate: remove unused includes Content-Language: en-US From: Kefeng Wang To: Andrew Morton CC: References: <20240904095849.861620-1-wangkefeng.wang@huawei.com> <20240904135422.dfb9d92a998d7bb26baa5326@linux-foundation.org> <151a4a19-552c-4e85-a4fc-897ab292a48f@huawei.com> In-Reply-To: <151a4a19-552c-4e85-a4fc-897ab292a48f@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspam-User: X-Stat-Signature: ng5xoze7ajk5maiehxzxy3qg4owubhjr X-Rspamd-Queue-Id: D06FB12001E X-Rspamd-Server: rspam11 X-HE-Tag: 1725499611-283115 X-HE-Meta: U2FsdGVkX1+a+9al5v+vVzNgVsf+AyjtXqKJHM14+e9nlMK8ZVxzo32NDESC7UJ2UqSNLrupCCQ2Pk94aZI+3807QmcG7UsEiAoA4w//5ZH60ZjrQuJAwJkG+CI9pQ1tnSEymwiMmw6CjKCAMnQ+3OEt3dLJOudVnvV1rc8XCTgxlMJCUwiKq6ZdfbhVP59d6hxR2f1PWPoITEAMk/AKQF//4O+aMOOegViqb/Lgn44CLC1lFNvyR6v9M+6s/31WlvucfRoHSf+Xkf+htQ1/aC4uAij0krAfDVZDgYoliCu9tpF9jsa0ykUZJZk//J94jkmrDtOxNyzTIjcHV09DW0rGlabkDkb5ykOnLEyXzVAA101EaJ1+SvdZlxHQ/f4/rqWUN6CJ8yNwnBurFMutkGwR1HwVNlGJXhnx1ddTU7GKfooIHEiqAW8Ydu/hfW/x4mfGLpsYAtBJ3H1+u/FoWJ/CuhqW8H5+f9bL6CC7bPbSkX3g0nRqACTbzFkCO3NAS1MTO4XXQnQN2VHMG7r6of+eoyVttAntVCdudngXmDabfB5kxMP2o53RzieasDU+ik5AcWqTtDJdzTr9kJgbfTWfhIIsKhQfUTQE8cLlrOIDi5W7rgSRt8fAG9mhfRwhBVRHu2BvLQZBq+RPnrAp0AOgkKrErcwKtfXq5gl3KME1USCORJGhloxiauxOg+iykjZXJFf969lNcI79NtHqq3HNFnkX+le/SpLE7bNb2rxbvd6pF8Z920nRiCl0Wr27t8G+BDJ537XDcFajw4OPkmp79enB4CSwOhj+37MV2vLcEx49z3fbUsPAIoalR87Bg1isZ7w0SD/H8z+/cu4E5Cfxt+z/kwNMMkX0fC22T1ZaKGaofUzt+fR2i+whp6Ma0xybnCkeRbwhfh3QDa0pl9OViDul6U6kZkAcRkGypqRSOS1x+dAThx2/vn3MW2lFzoM7jEagtn7EmQmg89b XIlLjx+B 8pFMDHgG8wzIDgt/GnUqpLk0kQPzpXXejdW/kGnI0ucCDRUJKHifHA68wvObtNEoMESqv0leRKz9kh+mHmdo0XZYO2Yhdxin6moTgvaHUZWs3suHqDsFyV88BG2LW0DgBaFt3rn5q9gxtyv0vrkB8kOornKFAGCDqXZUJ7FWgN4g1MxrEU97mPkQzFo3EVQb670O/Ziwpdm0nepN3E+ypHY//ig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/9/5 9:18, Kefeng Wang wrote: > > > On 2024/9/5 4:54, Andrew Morton wrote: >> On Wed, 4 Sep 2024 17:58:49 +0800 Kefeng Wang >> wrote: >> >>> Some includes are not need anymore, remove them. >>> >> >> Please define "not needed".  Does migrate.c simply not refer to > Agree. > >> anything which these headers provide?  Or does migrate.c already pick >> up these headers via nested includes? >> >> If the latter then that can be a problem - build breakage under rare >> configs, or as code generally evolves.  Not a *big* problem - we detect >> and fix such things quickly, but I do think general good practice is to >> directly include whatever the .c file requires. > > Yes, I could add more infos, > > random.h not needed since commit 6c542ab75714 ("mm/demotion: build > demotion targets based on explicit memory tiers"), all functions moved > into memory-tiers. > > nsproxy.h not needed since commit 228ebcbe634a ("Uninline > find_task_by_xxx set of functions"), no nsproxy, we only call > find_task_by_vpid() now. > > hugetlb_cgroup.h not needed since commit ab5ac90aecf5 ("mm, hugetlb: do > not rely on overcommit limit during migration"), move_hugetlb_state() is > called and it belongs to hugetlb.h, which is already included. > > > memremap.h, userfaultfd_k.h and oom.h are introduced for zone device > page migration, but all functions are moved into migrate_device.c, so no > needed too. and for balloon_compaction.h, we have more general movable_operations for non-lru movable page migration, so it could be dropped. > >