From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 931C5C6379F for ; Mon, 9 Jan 2023 15:32:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3386F8E0006; Mon, 9 Jan 2023 10:32:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E8C48E0001; Mon, 9 Jan 2023 10:32:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B0308E0006; Mon, 9 Jan 2023 10:32:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0C5328E0001 for ; Mon, 9 Jan 2023 10:32:05 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CBFBE1C6064 for ; Mon, 9 Jan 2023 15:32:04 +0000 (UTC) X-FDA: 80335651368.08.C7D4149 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf21.hostedemail.com (Postfix) with ESMTP id 0E4321C000E for ; Mon, 9 Jan 2023 15:32:02 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kVxekE8H; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of jlayton@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673278323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+NXESLxlbnefN7zuX0FIWAZ155M3KN+rfxfNIcmr2WU=; b=BKRa3LYYlMngxsiY/uGT9t+SofRnyBfzaD+oKepCaYmTMusGGfI9GcUB8BsJLB+aXWmUlu ywgg1BfIGCDHb5QDWBB85Y78C/q5Gjg2Mf33eGdMHrHWb/SLnO5Pp4qqRAXtMWIybYGVgI NugYE0q+2ll+itaCQpqVCBlNiSsoo1o= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kVxekE8H; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of jlayton@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673278323; a=rsa-sha256; cv=none; b=w20RHIN1uLmzGUu9Oq78xV78Xf+U5dT6D/LJjAI5ZqUUn0rzDaWK+R/k8zZ7xpe9Qrl9xd Ve7D9emVtHaiFOqnPAI6WHSwOkjM4owY12X8eg1cgPseadXDCo4lp/2y12I12pLldgAojl 0sPb7Fw1mOAY+PivAcn2aLYSmMPpCsE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 44C0DB80DE0; Mon, 9 Jan 2023 15:32:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69D13C433EF; Mon, 9 Jan 2023 15:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673278320; bh=wyx956OzqLIeQmTguifCY6ZQa55tJ2T+BHNa66v0lTo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=kVxekE8HdoHM3Vvt/+wjCSSi/dCg4ktXN9VaO+zUHY3UHbjUL8qqbxWz/GZqFAux4 aLVBQopjXGS2p9yngGl9jcjiwkwcmpiGbD0IdmnVsxhGiMWrxD164Y0GokiABk/ct1 lk8sZCl2KwTKINGxGTBadhj6CiRrQwOpYlD5aHwVIpyDA2TG1XqrQ7I9IgdpT+quID o67zLZCtWK5udyM6k0U8sot089oDMQ9h1i8G4MuQbG95fZ73yC+SExzg0mBi29lP2+ iyZZv+HaY9OThJvU6e0Mql0AQ5qJdSM0nDKHXHVXCXHI32oBwRy9y7mr/RaNIxMz0o 8wqwtkA76YFBw== Message-ID: Subject: Re: [PATCH 00/11] Remove AS_EIO and AS_ENOSPC From: Jeff Layton To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig Date: Mon, 09 Jan 2023 10:31:58 -0500 In-Reply-To: <20230109051823.480289-1-willy@infradead.org> References: <20230109051823.480289-1-willy@infradead.org> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) MIME-Version: 1.0 X-Rspamd-Queue-Id: 0E4321C000E X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ihokrrte31mfhsi19e6sgfy8ds4xtaq1 X-HE-Tag: 1673278322-922662 X-HE-Meta: U2FsdGVkX1838gVLeR6AP1kZiqtJWfGiFdTnu+nB0k3yye+dreo5ESTISkdIj68PmNJlXZP0Pvd0pfQfbA9VPCc64w38pX3xaQ5ti1FNIbjmwt5IWngEl8CBeM8FTAtxyFEK+KMXETgODnYr1HyUUCXel6DafV5Vrrj+fNjmJt2tuPdsGyjVb/PUN0GOdtKnZEqi1ssFJ2CGTV+5nheFqEByIS/zKagVS/O4P02ie0Wr7zbGEWKR1rrrOwzGkoTsgXtnA6GoCaiAz/q0RdxuJ9x7kDKYRUrUuwhrwfAIcesttyMpoHkj3fp26LqH0kxHyG1Tl++X3X1U042UrM12m2Lu66t7zs5zdW8SpgOnyrA3qqYumbvXQ/uXS1AXnm38LYI/hAsuOWGohUD8Qbwkekf1MFchnak9eyofbc/A34z5lcf/G7F1czSj0TH2f3S3Uf8eQzJbyFN8mZ/BbHvSYYB32SngDesxxA3Y9+ghZamYn/FgTfTON3P74IpaoOkS4CMeAv29rFH0/GxxWGCrTI1SEwhWKqhL9XUseMSXVsXcqxIX8LCW4jv9rYIFO8XUps01O+blLpl4Wqq5FdTmd4WhiW31GpSU23q4fffFzFy2ry10rKHgyBg5zngTCETfwS8ZaZwznrxDqp0g5TLoGaj/3fNkwiAos6pJK7HuM07Wt5y/xl/idO+0wURr/bOALnDGuu9NIoaf3glwKZPti/roZF4dx1stoYpl7WE80j7pb7oBSlm5bumRPYyxmAfqeFGl53dsAESccBU93iz91MrIo6c6WVclG2UE7u12mjiJtvaWO+HEvnp4e/wjSyi3t00Gy3whv1uo/LtEv16L4EW7Ycm4SYjG9aZe8/aSGVIVmnPMD84qYRVG1D6zEfYV8Kv6rD5w14lWHh7uC4ZC6vEbBky6RloFFlnPJamNW4hVjk8wk5gcK+d6cVsQqopVpzboMNpsHnKHdY0Q8dq MukNMvmd 9l23NvOCspL5yG+FV3c+Xz5cze3VBs9lD7WxjwnYnQRy51XkqUUgCdEdX/mEfTDFCs5F6FMRadNF9wnA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2023-01-09 at 05:18 +0000, Matthew Wilcox (Oracle) wrote: > Finish the work of converting every user to the "new" wb_err > infrastructure. This will clash with Christoph's patch series to remove > folio_write_one(), so I'll redo this after that patch series goes in. >=20 > Matthew Wilcox (Oracle) (11): > memory-failure: Remove comment referencing AS_EIO > filemap: Remove filemap_check_and_keep_errors() > f2fs: Convert f2fs_wait_on_node_pages_writeback() to errseq > fuse: Convert fuse_flush() to use file_check_and_advance_wb_err() > page-writeback: Convert folio_write_one() to use an errseq > filemap: Convert filemap_write_and_wait_range() to use errseq > filemap: Convert filemap_fdatawait_range() to errseq > cifs: Remove call to filemap_check_wb_err() > mm: Remove AS_EIO and AS_ENOSPC > mm: Remove filemap_fdatawait_range_keep_errors() > mm: Remove filemap_fdatawait_keep_errors() >=20 > block/bdev.c | 8 +-- > fs/btrfs/extent_io.c | 6 +-- > fs/cifs/file.c | 8 ++- > fs/f2fs/data.c | 2 +- > fs/f2fs/node.c | 4 +- > fs/fs-writeback.c | 7 +-- > fs/fuse/file.c | 3 +- > fs/jbd2/commit.c | 12 ++--- > fs/xfs/scrub/bmap.c | 2 +- > include/linux/pagemap.h | 23 ++------ > mm/filemap.c | 113 +++++++--------------------------------- > mm/memory-failure.c | 28 ---------- > mm/page-writeback.c | 17 +++--- > 13 files changed, 51 insertions(+), 182 deletions(-) >=20 Now that I got my understanding straight about unseen errors, I think this looks good. I think it'd be best to avoid advancing f_wb_err in ->flush operations but the rest of this looks fine. You can add this to all but #4 (and that one should be easily fixable). Reviewed-by: Jeff Layton