From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E91BC433EF for ; Wed, 20 Jul 2022 18:11:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A654D6B0073; Wed, 20 Jul 2022 14:11:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A12FD6B0074; Wed, 20 Jul 2022 14:11:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DA2A6B0075; Wed, 20 Jul 2022 14:11:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7BB396B0073 for ; Wed, 20 Jul 2022 14:11:24 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3ECF24063B for ; Wed, 20 Jul 2022 18:11:24 +0000 (UTC) X-FDA: 79708270488.28.7948249 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id C3AF3100012 for ; Wed, 20 Jul 2022 18:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658340683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J19kfipQoHZOcixHPVK0+w19cOCQBsO+YkDTCU5/NKk=; b=OzxMaWhcbjcGJDmujUyMIVmb2ygd2vA8+Py+Hmj0Scr4sZr3zTRrCemicea5h92qSoegHv 02KC6RNL4vZofBAZkq4e4Yw/LlIQL9WaPacelW/Hzi6c+8N256xUUclQhPekYG9P4ywd4t c+8TA/Pj9GUjVfuKxMl+V0iDrAovQqU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-110-7tAlPPJ6OES8Hwi3fuPTQw-1; Wed, 20 Jul 2022 14:11:22 -0400 X-MC-Unique: 7tAlPPJ6OES8Hwi3fuPTQw-1 Received: by mail-wr1-f69.google.com with SMTP id q17-20020adfab11000000b0021e4c9ca970so402403wrc.20 for ; Wed, 20 Jul 2022 11:11:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=J19kfipQoHZOcixHPVK0+w19cOCQBsO+YkDTCU5/NKk=; b=JQnnCDm5xGcSXshlPwznUfuKGPJtDTLDpOizDCxsxYfbm/Mzx2PlytUIo28dhxnx/H /tNFPN9M/dktrPo9CWbgh5RKuASgoG8ud4z9SFJrnDmoGUic8v1BbB86oWsMrQ62kcSK +KBxGi98YSyRqoIRhyMKygH6qla9rhzGheABxjN1y2aewVLLSUPNsGD501tH9xOqPaN6 KKVxSeBvc11V6bQQrL3lIhW2AwOWmHKxbpeL74VW6+HVmFYOFddZAntWYQ8TXhipA+y3 aNLU1/pUs/laYhLuGaj/Br4KqQuFRxmZ+E74uSAmRWlpQJESc3lslztKptp6wQDuwTHH TcyA== X-Gm-Message-State: AJIora/PluyOi7oBzaF+MXjsN5r/jWI1pcmJpUJ4UkJ/HiGfQa3ZqBxx Smd8qiqPN6fZsHvKWaqj/hzqa9LbvaPmst96GO26CqqGc6lAO+cGU5JUMRbce+iD0Kb6nr1sgJR W+Fsb6EPmizg= X-Received: by 2002:a5d:6b09:0:b0:21e:2eb6:2d03 with SMTP id v9-20020a5d6b09000000b0021e2eb62d03mr7709840wrw.684.1658340680823; Wed, 20 Jul 2022 11:11:20 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t+RPY7OrL5ClIPGayUaOxuBGC/vAsMkUZh9pSms3wOqtib+ulGOoTI3DS06KcDyzfJNlbHLw== X-Received: by 2002:a5d:6b09:0:b0:21e:2eb6:2d03 with SMTP id v9-20020a5d6b09000000b0021e2eb62d03mr7709823wrw.684.1658340680567; Wed, 20 Jul 2022 11:11:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:e00:8d96:5dba:6bc4:6e89? (p200300cbc7060e008d965dba6bc46e89.dip0.t-ipconnect.de. [2003:cb:c706:e00:8d96:5dba:6bc4:6e89]) by smtp.gmail.com with ESMTPSA id l14-20020adff48e000000b0021d7ad6b9fdsm16603709wro.57.2022.07.20.11.11.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jul 2022 11:11:20 -0700 (PDT) Message-ID: Date: Wed, 20 Jul 2022 20:11:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RFC PATCH 01/14] userfaultfd: set dirty and young on writeprotect To: Nadav Amit Cc: Linux MM , LKML , Andrew Morton , Mike Rapoport , Axel Rasmussen , Andrea Arcangeli , Andrew Cooper , Andy Lutomirski , Dave Hansen , Peter Xu , Peter Zijlstra , Thomas Gleixner , Will Deacon , Yu Zhao , Nick Piggin References: <20220718120212.3180-1-namit@vmware.com> <20220718120212.3180-2-namit@vmware.com> <09d84297-65d5-a3df-fdc0-a7168cdb0798@redhat.com> <99AFB0A0-B2F8-420A-8164-1705EC14B255@vmware.com> <97e82e31-2411-501e-d401-d175eb24642f@redhat.com> <18EDDBB1-255A-475F-812A-8CA947493EC8@vmware.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <18EDDBB1-255A-475F-812A-8CA947493EC8@vmware.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OzxMaWhc; spf=none (imf14.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658340683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J19kfipQoHZOcixHPVK0+w19cOCQBsO+YkDTCU5/NKk=; b=TyLq1jsO3M9ZjmFLiMV7r6a7Tu+bhhcWL1CCjVxX0UC5TjWMdddQOcXemshGXeA5r3/TOE GlZbhy4H8W89KmFqEwGLYXC+/N5oEnV689rWM9y4gv5T1t+ozK4rU7eXCCblTc8ccBrmsz +3O/mpirNQ7AOwtZTF7QyxNow7cEQdA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658340683; a=rsa-sha256; cv=none; b=r1kxac1Mank+wO7oS9ObFwqPQIXKkVPqQ6H1h0M5s89hXJ8GOts1PPCIlmSWuJ04VX+6LE djkLSkMPnXg9QpfRHCK3LOVOgcrpoa7VcPg9akafjTihksaXPaKWMhxrloEIYB3Zk6hxPI vFPwyxDko2/u16V6k75RpHgmDIyGIUA= X-Rspam-User: X-Rspamd-Queue-Id: C3AF3100012 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OzxMaWhc; spf=none (imf14.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: ktqrbmsmekei63njtxu79cci5xe9tiax X-Rspamd-Server: rspam07 X-HE-Tag: 1658340683-265707 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000444, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.07.22 20:09, Nadav Amit wrote: > On Jul 20, 2022, at 11:00 AM, David Hildenbrand wrote: > >> My patch review skills have seen better days. I thought you'd be >> removing the pte_write() check ... :( Tired eyes ... >> >>> Having said that, I do notice now that pte_mkdirty() should not be done >>> only this condition is fulfilled. Instead we should just have >>> something like: >>> >>> if (will_need) { >>> ptent = pte_mkyoung(ptent); >>> if (pte_write(ptent)) >>> ptent = pte_mkdirty(ptent); >>> } >> >> As can_change_pte_writable() will fail if it stumbles over a !pte_dirty >> page in current code ... so I assume you would have that code before the >> actual pte_mkwrite() logic, correct? > > No, I thought this should go after for 2 reasons: > > 1. You want to allow the PTE to be made writable following the > can_change_pte_writable(). > > 2. You do not want to set a non-writable PTE as dirty, especially since it > might then be used to determine that the PTE can become writable. Doing so > would circumvent cases in which set_page_dirty() needs to be called and > break things down. The I'm confused how can_change_pte_writable() would ever allow for that. Best to show me the code :) -- Thanks, David / dhildenb