From: Heiner Kallweit <hkallweit1@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Dexuan-Linux Cui <dexuan.linux@gmail.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dexuan Cui <decui@microsoft.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: "x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321
Date: Sat, 3 Mar 2018 12:46:28 +0100 [thread overview]
Message-ID: <f399b62f-984e-c693-81f0-9abe3c49d8f1@gmail.com> (raw)
In-Reply-To: <20180303100257.hzrqtshcnhzy5spl@gmail.com>
Am 03.03.2018 um 11:02 schrieb Ingo Molnar:
>
> * Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
>> Am 03.03.2018 um 00:50 schrieb Dexuan-Linux Cui:
>>> On Fri, Mar 2, 2018 at 12:57 PM, Heiner Kallweit <hkallweit1@gmail.com <mailto:hkallweit1@gmail.com>> wrote:
>>>
>>> Recently my Mini PC Zotac CI-321 started to reboot immediately before
>>> anything was written to the console.
>>>
>>> Bisecting lead to b91993a87aff "x86/boot/compressed/64: Prepare
>>> trampoline memory" being the change breaking boot.
>>>
>>> If you need any more information, please let me know.
>>>
>>> Rgds, Heiner
>>>
>>>
>>> This may fix the issue: https://lkml.org/lkml/2018/2/13/668
>>>
>>> Kirill posted a v2 patchset 3 days ago and I suppose the patchset should include the fix.
>>>
>> Thanks for the link. I bisected based on the latest next kernel including
>> v2 of the patchset (IOW - the potential fix is included already).
>
> Are you sure? b91993a87aff is the old patch-set - which I just removed from -next
> and which should thus be gone in the Monday iteration of -next.
>
> I have not merged v2 in -tip yet, did it get applied via some other tree?
>
> Thanks,
>
> Ingo
>
I wanted to apply the fix mentioned in the link but found that the statement was movq already.
Therefore my (most likely false) understanding that it's v2.
I'll re-test once v2 is out and let you know.
Rgds, Heiner
diff --git a/arch/x86/boot/compressed/head_64.S b/arch/x86/boot/compressed/head_64.S
index 70b30f2bc9e0..99a0e7993252 100644
--- a/arch/x86/boot/compressed/head_64.S
+++ b/arch/x86/boot/compressed/head_64.S
@@ -332,7 +332,7 @@ ENTRY(startup_64)
/* Make sure we have GDT with 32-bit code segment */
leaq gdt(%rip), %rax
- movl %eax, gdt64+2(%rip)
+ movq %rax, gdt64+2(%rip)
lgdt gdt64(%rip)
/*
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-03-03 11:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 20:57 "x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321 Heiner Kallweit
2018-03-02 23:50 ` Dexuan-Linux Cui
2018-03-03 0:21 ` Heiner Kallweit
2018-03-03 10:02 ` Ingo Molnar
2018-03-03 11:46 ` Heiner Kallweit [this message]
2018-03-05 8:19 ` Kirill A. Shutemov
2018-03-05 18:57 ` Heiner Kallweit
2018-03-06 8:16 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f399b62f-984e-c693-81f0-9abe3c49d8f1@gmail.com \
--to=hkallweit1@gmail.com \
--cc=decui@microsoft.com \
--cc=dexuan.linux@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).