From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B57FFC3DA4B for ; Thu, 11 Jul 2024 18:40:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12A6B6B008A; Thu, 11 Jul 2024 14:40:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DAAC6B0093; Thu, 11 Jul 2024 14:40:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E96066B0095; Thu, 11 Jul 2024 14:40:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CBB636B008A for ; Thu, 11 Jul 2024 14:40:32 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 591A3A0684 for ; Thu, 11 Jul 2024 18:40:32 +0000 (UTC) X-FDA: 82328337504.16.4D469BC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 09DAEC0007 for ; Thu, 11 Jul 2024 18:40:29 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MB+pvCOv; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720723214; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CBrkSaMFUktnswkqBLyZSrPH+Wt4VFEGzdZQMGnxyes=; b=3dRUEt6DxBMhaA8F3PVunamSzW9yFMZUlpr+mhnvGN6l5svQfkFEVnDujmYaQpT9b9bkfh c150Gn909n2K9xECz3sclYeNCPxakajM487U9DGlZrTKwFQi/VQC9+iLYvUMbTCendn4ML w4n2tdTTJwr6XdkSIKHS3WcGcj7tY+k= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MB+pvCOv; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720723214; a=rsa-sha256; cv=none; b=Ea4O6kBoKBBNSI78k8CQA7NzlFXzXp7mLdtneCy6EA8JXc+Mdr66CTlo8tF45YMjHFllrH 5J2s9573ynH2VdopvSX+QVJZsJIiqz7HaKbFdnskUcEm+raWJTUPs2/UzTlCKP47pNpNMy SwTIx7unSRyeOEudP2gn8PloLbs5Fx0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720723229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CBrkSaMFUktnswkqBLyZSrPH+Wt4VFEGzdZQMGnxyes=; b=MB+pvCOv70rXRXczm0cYQtOteDhL+O+Af7P9L98rcxIV2hR/ljz+DmwdvpQosMEWCZvE/0 eXa2Ps6L11DxElxUeVt+941zpHDh+DZ3fAWxhagqVdAqno8HJXuE5ZVZWldbF6VcA+9f7M GcpBoMA3/+3cLrD4oqMaiMw8oMecDGQ= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-474-C1WhD1odNUCCLZ33rizDlQ-1; Thu, 11 Jul 2024 14:40:27 -0400 X-MC-Unique: C1WhD1odNUCCLZ33rizDlQ-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1fb2e1dadedso8771955ad.3 for ; Thu, 11 Jul 2024 11:40:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720723226; x=1721328026; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=CBrkSaMFUktnswkqBLyZSrPH+Wt4VFEGzdZQMGnxyes=; b=T479rpKdX5qPNaprSftcphLi07dXk9Su8BKw3ClKqsX9Q0au1SIC68QqJFomXkbLj2 cQ3HqdxZOTSzfdS7GwhwkgHhVhkhnwUiReuO3Zs9+9aui2wXD2tdYED7d32SDZ4OGyP2 ohDhxbaBM35SvSsonpDjbJ4v0D5P0L0N7lpuHPM7C0SFeGKQ9g7l6BKxFQMN7+GTbRl9 CAR7dTWaJffI2le7J/gsSofNaStoQZda7rPetivNQKeu/kobxoLzr+vJls7Hoj+hlyXd ld9J3DbAE/SnCYSewj0vy+qfqOZgd0FscuCnY3c9fxfDhiE7dBRUWRbfmGk554Kb2vLq 9vwg== X-Forwarded-Encrypted: i=1; AJvYcCW2IWu092OiW4jKK76LrhOoGJlPV8gIHcgIQR1Z765H7fujYE5wz9qARikWbG4tfevJ692S/4RzPUnm4i85k/9L8hg= X-Gm-Message-State: AOJu0YwvEFIJY5/gJ2Bdbqewmi3RiuHsEieVz1kLQq3L4dImhWtKJVpj 7RjzJjZ9TKZb3Dq4EL4XEUHQYmIWif1lI73mpEzjivJ/zlJAKO7AtIaNQqzF2TJq2EW5lagVHp5 wa+juu69/taIj0zr9jskIEEWq9H8uCX0AUjujrd+WeNMRoDgZ X-Received: by 2002:a17:902:ce86:b0:1fb:451a:449b with SMTP id d9443c01a7336-1fbb6efa3d2mr83793995ad.60.1720723226244; Thu, 11 Jul 2024 11:40:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IERKKTkFYP5jTi1zKMn0fDAckQFwsUgwcejr8FFQVjvnG4tC0rpT/1dvgRc8O6UGtsDvQRelw== X-Received: by 2002:a17:902:ce86:b0:1fb:451a:449b with SMTP id d9443c01a7336-1fbb6efa3d2mr83793735ad.60.1720723225904; Thu, 11 Jul 2024 11:40:25 -0700 (PDT) Received: from [10.35.209.243] ([208.115.86.75]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6a1089dsm55103495ad.41.2024.07.11.11.40.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jul 2024 11:40:25 -0700 (PDT) Message-ID: Date: Thu, 11 Jul 2024 20:40:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm, virt: merge AS_UNMOVABLE and AS_INACCESSIBLE To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: vbabka@suse.cz, seanjc@google.com, michael.roth@amd.com, linux-mm@kvack.org References: <20240711180305.15626-1-pbonzini@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240711180305.15626-1-pbonzini@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 09DAEC0007 X-Stat-Signature: zj66epbsojzd1dgdyawxbhns7nypiwr5 X-HE-Tag: 1720723229-356741 X-HE-Meta: U2FsdGVkX19z00p0yD9PkuL7P/2VLr1LOvxC+fQG/VeVVpgUc8aFJswFo/jheiW+K+6IbgigPTjkYTVeKY7naEEZ4QilRODZ0BbALhqUmONvZg3LaGEdxl0Z15HghVwSQ4qW25jICuaviLGqlSt60+/tTpk/Wyuga0Z0UjJb3tQRN/Xuy+VQVjXbgmPzutGeL/nAIm8xy19kcLqJ3OaLLY2LoqvEOUKtOaazhC5yfAbOxqMajoziEKzCiGHo6RdnctnxT/U0R7QZ/g8v2lXkKpfuInI79zdfJ19o47wuBXOfAd9varclLpQLOhdSld572shFUzZz3YB39EvuWzKpA/p8si6s/fe8UjF1HzI6cpGVaiQXpDOkMs6JU7A1514If59qS3EMXaj8pd4iclBB2VqQqsUr0KHNl2QRsZE6v04fRWQczBaagVt5KMAjkJlXRoRdWvvswT6CZzesMp/Xp1CsTMSTUlmAeLNR7+JaJK96Jb6YJHVDwg86La4sXVscpfP34SNbuCEaOh+rDev3os5kFclkwJhbb8nP3F2uR3EkcoEVgHHGMPU/6CcwY67cCw6anfGLF4P9OVwlcT9EbEN6pLndgYdJLzy9dOVDVmTr9d7LUZuBK9ThEJyOEbzhBmrE5xG9VsGo0/9EQDhw7C2UfS+nELvhVgZmeAMeMhwV4JSxuInifkZpiEICLYk3vBB5YNhYEEry5ThbGROOx3efkHRHVtGDjHiRfzJxpjGBNjFj2n6RYmajV7T03dZU5/K5FpRUOreOoQo8mzGg86484ONgn/xFfeDgVR/qaIrlXby977GkuhbOKUf75YoowGawf6vGpqwVCteZbgfCEGdAgHdJoPo+ioh0vI7kkqe7IC87N7P2oxYFRmNCuFC8N6ybrYu998u6Ze4nrYzdBfw7j2KM7uhw8diznBYp+tT5bfzRfqQ2cw4dRk9b4+4faZWNZCJmoCAGmOCLp6l 5b1yGdKJ E9HRykT2e70NSZ8zkjMUyciqq5o6akc+vQDP9py8tcLIeC5/GjxeJGHo3g0y1qrehMy2ds+Qu7fZepJ5VCNsgKQdSJ6E/M4ggqJ2ZwNeHlspqPswzb/CxnXqv/xdqdmzLEXFzrC1oncC3b0+6NnGR9UjtNgUqiVHoKsMtFKnwKFUebMht9o9yJP1EHBdkcu6tZgGRvGOrcSDdDKKvtfMqf7VepZXF1BGIiWqvZveCiQ7z/vwfC3N8+vu8pqiGqLlG3nKrIma9yfEuBLxtbFvw517QmWiMuGRdmIfbh2NwC/zP5s/JyP1p+Sm30SMQ2JuZXsjFCOLoStZvUw5ODR+ykvtLEr4fwC72PwBC17TAoor3s9mvIRtcEaj1K2ciZ8BtCjgPB5lO5qHfb2yqkkPjl9kIvVs5gPFKGkO5jN8TnMhbXyRyul+7b8UTj8Ur0tGYLe3pMFuMTespnGkxyTZj680tQJlpe0zrsgSfrhUJvr/teO2jCdJMVCwtqiCquw3dCzgLLhcrNR5QneM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.07.24 20:03, Paolo Bonzini wrote: > The flags AS_UNMOVABLE and AS_INACCESSIBLE were both added just for guest_memfd; > AS_UNMOVABLE is already in existing versions of Linux, while AS_INACCESSIBLE was > acked for inclusion in 6.11. > > But really, they are the same thing: only guest_memfd uses them, at least for > now, and guest_memfd pages are unmovable because they should not be > accessed by the CPU. > > So merge them into one; use the AS_INACCESSIBLE name which is more comprehensive. > At the same time, this fixes an embarrassing bug where AS_INACCESSIBLE was used > as a bit mask, despite it being just a bit index. > > The bug was mostly benign, becaus AS_INACCESSIBLE's bit representation (1010) > corresponded to setting AS_UNEVICTABLE (which is already set) and AS_ENOSPC > (except no async writes can happen on the guest_memfd). So the AS_INACCESSIBLE > flag simply had no effect. > > Fixes: 1d23040caa8b ("KVM: guest_memfd: Use AS_INACCESSIBLE when creating guest_memfd inode") > Fixes: c72ceafbd12c ("mm: Introduce AS_INACCESSIBLE for encrypted/confidential memory") > Cc: linux-mm@kvack.org Yeah, if we have to bring back the separation in the future, we can revisit that. Acked-by: David Hildenbrand -- Cheers, David / dhildenb