From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC24C04FF3 for ; Mon, 24 May 2021 05:12:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6810861104 for ; Mon, 24 May 2021 05:12:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6810861104 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 59CAC940046; Mon, 24 May 2021 01:12:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54AEA940042; Mon, 24 May 2021 01:12:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08C6B940046; Mon, 24 May 2021 01:12:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by kanga.kvack.org (Postfix) with ESMTP id BEF08940042 for ; Mon, 24 May 2021 01:12:15 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C80FE8158 for ; Mon, 24 May 2021 05:12:13 +0000 (UTC) X-FDA: 78174953346.11.5152E5C Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf19.hostedemail.com (Postfix) with ESMTP id B233890009E9 for ; Mon, 24 May 2021 05:12:07 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id cu11-20020a17090afa8bb029015d5d5d2175so10560964pjb.3 for ; Sun, 23 May 2021 22:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=JebLWMT0Go/+c6aGerW7majYGlYeWtVwcKAWlcwxf8I=; b=s1qIj6Cq17y3CG1QhE7tI+l3duc+Z9YA8QhJqG0LiWlmzy3AA/Q/rROtpXfT2u02iU C4vrzM/L3jPDEsXFl0zrEkHSt0Q/SJ3tHaGIJofGBwcTQ4scFQNk3FHYpYKi6KTqIy45 BB7uOjJP69bh7kLCtMUB/6hYmBcRZ3g7IE5+NvRXaGQ+n6pQXRBzttr6ai+aUYuyebsw tsf3AJWYkN3r0dFKWaG2ctPv9D2pUOOp6INrxDFZbvgsFZhYiE+t1ZdWczug0ThC6Xh5 6lVghk9Z7Fhl/bdufS5xVfxONO8YC2dLg/LvPVhfVwIBDavWeyoQqBPZHfX48JRBjD2A 0KTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=JebLWMT0Go/+c6aGerW7majYGlYeWtVwcKAWlcwxf8I=; b=Z16GVK+qhyRVZbJzNsu3MLwPjfjUP2iOMGBMVyBYS7LqWgjCsK7uXALYAhBV3QeYMM 1iY5a4qvfLTKr8JQLH4K3HQXO3xB4EdiVYTb1OOMSNV+C/CB093oCSxuUefzSwTRx0/U rdqr+5TwqHfLGVSUW4LjeGSlJon3IAw8mq85PGt6NvTm3GhJJ9Kfhb7XEMqDJ3+ASA++ 9Ey3YdDVK/AarBOIF+xl0P+ooyquZIwnFvuANlLYP8+z4p7PK5rKMKAFeeqHwN1BEmiY lEibuWXwfw9HiLelboyAHHhObciJOALAEpSJJVUgW76bMttfi130+6zo8hQsjpPjqqZL k1pw== X-Gm-Message-State: AOAM532HHAQhFchZbsfMLROYAkTkW/q9hZIWR7pmim2379PH6To1wTQd GwD8tJwvq/JWxObG7FOIYhtRyQ== X-Google-Smtp-Source: ABdhPJyOeAfObOCV2tOeUqcW3AWSKvZL71x3qCe3JZiyC93/O47MXppqvIjlwwJvuxeeXH+vf5WNaw== X-Received: by 2002:a17:90a:b78d:: with SMTP id m13mr23571087pjr.177.1621833132465; Sun, 23 May 2021 22:12:12 -0700 (PDT) Received: from [2620:15c:17:3:9016:8a6d:7de4:aa23] ([2620:15c:17:3:9016:8a6d:7de4:aa23]) by smtp.gmail.com with ESMTPSA id s2sm11141816pjz.41.2021.05.23.22.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 May 2021 22:12:11 -0700 (PDT) Date: Sun, 23 May 2021 22:12:11 -0700 (PDT) From: David Rientjes To: Stephen Boyd cc: Andrew Morton , linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , Joonsoo Kim , Vlastimil Babka , linux-mm@kvack.org Subject: Re: [PATCH 3/3] slub: Actually use 'message' in restore_bytes() In-Reply-To: <20210520013539.3733631-4-swboyd@chromium.org> Message-ID: References: <20210520013539.3733631-1-swboyd@chromium.org> <20210520013539.3733631-4-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: B233890009E9 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=s1qIj6Cq; spf=pass (imf19.hostedemail.com: domain of rientjes@google.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam04 X-Stat-Signature: w7153ywskhmtbzteamga4abn7x4tktf8 X-HE-Tag: 1621833127-666721 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 19 May 2021, Stephen Boyd wrote: > The message argument isn't used here. Let's pass the string to the > printk message so that the developer can figure out what's happening, > instead of guessing that a redzone is being restored, etc. > > Signed-off-by: Stephen Boyd Acked-by: David Rientjes