From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CB0DC282C6 for ; Fri, 28 Feb 2025 19:17:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFBD0280003; Fri, 28 Feb 2025 14:17:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D8448280001; Fri, 28 Feb 2025 14:17:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAEA3280003; Fri, 28 Feb 2025 14:17:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 97ECA280001 for ; Fri, 28 Feb 2025 14:17:57 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3784650AA8 for ; Fri, 28 Feb 2025 19:17:57 +0000 (UTC) X-FDA: 83170313394.23.2ED87C7 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf19.hostedemail.com (Postfix) with ESMTP id 6B4EB1A0018 for ; Fri, 28 Feb 2025 19:17:54 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TJLLVDCZ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740770275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5prRrZXM9p+gbC/IAUcI1wJOGtqMh/Qd4IruQwch4zU=; b=zMDiBx6UAijDlwv1RNmBSBIQ/fOClERfuFoypkkLC8mzIqD5uCzm4z1V9g5zR2VvIMEDTS Jfsrx8/bpszs3yHlXEBvIpptnbSiUfE4/v1iOpGbADhR9tn3Ro2TWouEPjj2nEPXqFNUT7 77OacJa0nZMRaSpoVqm+32SCJBqPNpU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TJLLVDCZ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740770275; a=rsa-sha256; cv=none; b=Q0Ggf0zYaW+beLirI/yuSni84Viu1J2AfJva0AIoU6TxOlqrt7bIhyk+d+GCY4KmzxG+GI IiKIu0h84jscWWZNoRe3pa4nl5o2qgowl13U51uu16uPgaJ38SzErU9QYqEXqq10x+mytP 4Od3/lEq25zQiUaB5GCQXjbl/xUW3hU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740770274; x=1772306274; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ewdXxdmC7S1AJAxO53GRYpKq/PilSuqaBqFx+YMcKy8=; b=TJLLVDCZCY67JIZ5K+VJgT0kePAB1/QSkJA6s1bVZ8b2Z7/FZYf8DVQG p/bUfIh+9tCiPvOr5kEOrwJaqWIf5sGsFNwFl6FQVIIJ/jHiG1bBmSGFp uIoSmqUYvvmpgw7Joi0dj9zhvpZM+Tsbp414aXJKdaXT+/svnpUGOZ1JU z41aJOX7PyrzFFce6v7vMzApKCpTsi87w1iSzaT2xihwHvJ5rDoifUWrS LmZwr8SmhesE1PEikZYWKCCXpnPb8MmX99NBuxsDF8Z+XYrNdgbhDdgs7 0cE2CRnunwVI/JBPC8chxhn0tfvDlpkNhKnwUvBL0UJx/bl1FOSIAQPYp w==; X-CSE-ConnectionGUID: kbAwiuClT3W6fmWcB+L1GA== X-CSE-MsgGUID: C8eMPJ1qTVmLoQ5HSmaU/w== X-IronPort-AV: E=McAfee;i="6700,10204,11359"; a="41630389" X-IronPort-AV: E=Sophos;i="6.13,323,1732608000"; d="scan'208";a="41630389" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2025 11:17:53 -0800 X-CSE-ConnectionGUID: vO1UPoHFT6SjOnZvHu1trA== X-CSE-MsgGUID: BOiTYdPwQaO5RF9WQKGJ1Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,323,1732608000"; d="scan'208";a="122553982" Received: from dwoodwor-mobl2.amr.corp.intel.com (HELO [10.125.108.137]) ([10.125.108.137]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2025 11:17:52 -0800 Message-ID: Date: Fri, 28 Feb 2025 11:18:04 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 05/13] x86/mm: use INVLPGB in flush_tlb_all To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org References: <20250226030129.530345-1-riel@surriel.com> <20250226030129.530345-6-riel@surriel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250226030129.530345-6-riel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6B4EB1A0018 X-Rspam-User: X-Stat-Signature: hqdonam6pgcm6rgb6k93pcgf519uektj X-HE-Tag: 1740770274-801461 X-HE-Meta: U2FsdGVkX19ewU27iAYmi0IeHAa4MXgS+LmNOzP9o/jd3bFyATDrw/UsTw8P5sR0wYjLBaehX+6QEDXjYJO4MXE85iUsvLKSrzYGGjTsJ4RKZjVma3SCPavda+QTnZ6wuor8/zwyemS8ZikU0htnUxUUxStGaepBpnGZA50JdiNXGCUTs00VWoCjiEOYXMmD+5n7kgh1OxLMxz0oLhp95R10VRUuzJ1lpU4leS1/PK7QP3E5xfRL3UNGNlZoKGzBMsM3+YY8GqwROOLNdIZM+LUZtUr1uniyVm/U1i88cSXPVBBfmsnsW85LUgDRzIRYFAnAtVATvSk4LAc36RAsPiZpIIaCOR/s4Dtlet5eCoC/AMSAkJ9ffdVECarnJt6F54Ui+X0sg7ONSApwNo0v0ejkr4uquyW55eobpenBteCFtaGLy+9oCY/TZtifyPO28QiXx86eot/vHc5J4xLAiIotSVVle609mDMG4hS1uBBqcJBIuV/q8R31Xmf4l1iV98VdDUzxTRXPYNsMtQqosZHSrXjX226FIcRyXZQh3jczDG7xI9j2gsFkH0APlsR9BhegLBrHlNQToLjuTamUs/xYFt+TP5LwxiB6oMLiqOX3gvA59/qzdhTCSZhGpgVPTvMOZy2TTVvoT383xqZ3SsmKYU5XjBZLMXdOhkm2wR0vaemqADNXqs94RiqG/51ZKbR0BvPNTP7xuXy7e/n9r1IvpOOSS2RV1qjprfb88qDj4JwsR6uN4bjYJW6ulTe6G3M8wMb0Z0zpKRf6UTL+SdJAHdUNtrcUqv9gco4rswYjpWVptfLIwCoIFcy8YvTDNPv1OeCMNQGlI8NQRXa5lJJOpBT+DRZ/lQLp9mjFL8cOOVasr9DI4zoLM/KgDJMJJI6zh5Gm0PCghOT+dTyfWrWfXFQYHPMR0AgKalY0S1o5v4aNiT2ndAOHd+a4iVKq/F7vH09O/8/KO2qJ6vD cMABLL0H E1OZBJcHd6FCiO4w4fAaod9Veby5WKTWdJIVoyrKzsTGFtZX14khzvzZAAGgEhVBSxDrUfl2rSdrqlXttiGDaCobOsbeHkdfuL8kpDsTetXwtK9iEpuof1y/+ki/9gOGaJSGiDx70mw7Vz5nJcSqPW927qrDp75HJF/o+vnppY9FY8cJOmOrdlnQjjtrVjBr8kMlkgU5G8G2+/d3azTpWd7lx5OuSkj7Jmvge/F+Q7PFYY/yVyHkrRYcQaeQw3bWitWuDr8lKyZ3vO0IJ6fRboDtXIvbBqYmNPBWdJV2vah7asHFnI0NeGx8+5WIiCcE5V3kx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/25/25 19:00, Rik van Riel wrote: > void flush_tlb_all(void) > { > count_vm_tlb_event(NR_TLB_REMOTE_FLUSH); > + > + /* First try (faster) hardware-assisted TLB invalidation. */ > + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) { > + guard(preempt)(); > + invlpgb_flush_all(); > + return; > + } We haven't talked at all about the locking rules for invlpgb_flush_all(). It was used once in this series without any explicit preempt twiddling. I assume that was because it was used in a path where preempt is disabled. If it does need a universal rule about preempt, can we please add an: lockdep_assert_preemption_disabled() along with a comment about why it needs preempt disabled? Also, the previous code did: if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) invlpgb_foo(); else old_foo(); Is there a reason to break with that pattern? It would be nice to be consistent.