From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41924C3DA4A for ; Thu, 11 Jul 2024 21:03:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 785CF6B009B; Thu, 11 Jul 2024 17:03:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 735A76B00A2; Thu, 11 Jul 2024 17:03:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AEF06B00A3; Thu, 11 Jul 2024 17:03:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3CC346B009B for ; Thu, 11 Jul 2024 17:03:20 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EB1C91207F3 for ; Thu, 11 Jul 2024 21:03:19 +0000 (UTC) X-FDA: 82328697318.05.1CB3D87 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id BE07740003 for ; Thu, 11 Jul 2024 21:03:17 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Vjo3V/eK"; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720731780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QvGqQZLWXt9s2ZifTFpe/SJ61Oy0u4wSaDQQFK1SI7E=; b=C+WL9/mm1zZeKQroU0JnAPjA7euHphIzfvy24RdUw4yuOaUAyU1mSyyhTeuqRefGPHjq9+ JvBdWQJXdgW0FplxLp5t39KwUC7G4dbFnQwKVntL/cL3ey1k8yS4ryOlH5TTkFTkuFMVZk qpm1aYaEuuOcSh9xBMdOU3hmbdua8wU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Vjo3V/eK"; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720731780; a=rsa-sha256; cv=none; b=0JI2n+dBi5GExt/ea+4h1hYFMFhpDSr8GRo+1CadLaUsmIcV71sDoZ6I3fzsc8+jINmS+6 2Dl+QmfwJwCtxxM9/+hrLuCU1RpwNdmLdlDtNUK54l20S27tDcETT74eW9lui8PMeK/Pw3 aRZ0p9v4hh55/uXglIbOE1xNS8iSew4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720731797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QvGqQZLWXt9s2ZifTFpe/SJ61Oy0u4wSaDQQFK1SI7E=; b=Vjo3V/eKEk5QFSefrF5GwnV6tQa/Nz+SDmm7qv8XwHl9Yb114iZVe+Hl1eriLlX8QA18HI 3dRo9r646eBWajbUEdw7wF/beoLNhUeV0ggnPnOgxvTvCc0pcTf9Vo/m0O453//3ArRaay ccryj+r49kIFYX/E1PGvdgbBSGhVLXM= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-wKFMx2k8MjCPSI6h1swY4A-1; Thu, 11 Jul 2024 17:03:14 -0400 X-MC-Unique: wKFMx2k8MjCPSI6h1swY4A-1 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-70b05300627so1441583b3a.3 for ; Thu, 11 Jul 2024 14:03:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720731794; x=1721336594; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=QvGqQZLWXt9s2ZifTFpe/SJ61Oy0u4wSaDQQFK1SI7E=; b=aPnWvHynUbSIKsQKXKVNu5xDlrefc0pkOw+EeGnL22pYJ2yte0+S1wE1BwWveR1bZ2 ZMFAFcve3BdgSI3Okr4tgmX3IOSmUeCCBXsBls4Wv8zGPIZOcEXjpxkMC0hAlL6yjFiP wq/2YTsQA5UMfM1tij0znZaLP5LfbtMqY25/kGo8YE82H1e8bQQudxIlPqwXxLzhzYJy yzWfdMn8Rn4czTVGF0fLFMB/6V74GYV4MPGNL5QeKdYOQ/oS2mqgTkjgdGC5OBb9Cx0C r1Cw/6PPhkJoVBegA5SMvBGTu7uetXHUNDx+1u1J4u7kRcCTSWAEaRLIv+3Cynhmpm5f Pu+w== X-Gm-Message-State: AOJu0Yy+iuGdZMIP1A92DDIN3FpfvVgvMczY5JaAjOOW2LpHL2YYSO8N nh3F/JWbn8XwGPmcLt66izsggDTWKGby3+H9eLSIEsDyNbaIcvy7eJ3U0r4xdnZ/KSgtf/VbhNU gQ4zPiE3fEpRb3ATRsFGiiNzDqC1RO5GLsdAU6vt3HPYVF8Hv X-Received: by 2002:a05:6a00:130f:b0:705:951e:ed84 with SMTP id d2e1a72fcca58-70b43565d94mr11526788b3a.15.1720731793634; Thu, 11 Jul 2024 14:03:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwr+qp1AHeckqgEWrojjQvAUB0M3ica14m5+kWqP0N+BKqw+dyJH0w0Sc2RCDeuPaWaf/pFA== X-Received: by 2002:a05:6a00:130f:b0:705:951e:ed84 with SMTP id d2e1a72fcca58-70b43565d94mr11526748b3a.15.1720731793132; Thu, 11 Jul 2024 14:03:13 -0700 (PDT) Received: from [172.20.2.228] ([4.28.11.157]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b5382b622sm3794125b3a.124.2024.07.11.14.03.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jul 2024 14:03:12 -0700 (PDT) Message-ID: Date: Thu, 11 Jul 2024 23:03:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/huge_memory: Avoid PMD-size page cache if needed To: Matthew Wilcox , Gavin Shan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, william.kucharski@oracle.com, ryan.roberts@arm.com, shan.gavin@gmail.com References: <20240711104840.200573-1-gshan@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BE07740003 X-Stat-Signature: 1f8zog8xjn1ttf8e1u8hretnzrmjzsof X-Rspam-User: X-HE-Tag: 1720731797-468549 X-HE-Meta: U2FsdGVkX19RCcAQZbPY13+LNw6QqvVvQk6Lo7oQbnF4zi1nphThpkKYijET7oKhG+7dJW9q44Gn/a+8F3on+U2rpQM0HVOvSsDYb60EiyeMgI0L8POOoNvC59rCoMRmGaKYqJSSGM7QmZ7aif9JOud6AvmZLrJXFfMStB1h56a2wFv8krvriZWe/LU3ZX9dmHfmdER6H7gzIXivU+sJaqEIwnMlq/AkxJkEZIWZzmnkfUUeNwuXHdsEi6TkNsLcUvmTQts9dmhoi9XzHdIF+AjkPeXYdCa39a7O0GPxOgitEHSZB/akuUUEDDJ4iTzneC7uJgfUrYuGl2mncLhEAh1SyaYewsJjzoU/fjmbsIl7KSOW7mhGikxGmRwqV/px7Ph9Rwm+4ibS3DyIDFME8yUELRCORtEQMGuQ9z0xGnsgQt0Xr/HFdujpDIW/OaruCIS9TPSJxClZFhmuxK3nxLHJ/kyBc1vq+VdKSMHBZAopiJ9ibEOUr7VxnukmIr+t7l3EccjJuxoNFGTYiidLP4W5ZrL2YQ1x1A4Zd67xrZ1dXD8PHtUrTOIi8XTu2AZTaLMWR8Avn3pNFDTSAdwdQaLY4vZhhyVRCVSQQGgvNW+cIZgtO6U3+X6/m7LAEbiYqb7nbXKGopE6EADlPRX1xrMe8g4Ipa8uDzR7uPrP1T8CrC+hbXIH02f2HDDajg2oudkPkv1JomyLioVrBpVI9C85nsCPDrFpMNghxuh2kTVuSZZ4gCjhmnNm+1ygiE8yWFWX4Z0ln4FKtz2FHXSYUty5eIkpw84cpZwDLm5zWZ1mBVWywZPdBKoibPfjriUbhEaRLp/6XQDl4xmhKJtgtm9V4ffM+qelg72D98HZh5btAs5sd1WNj3X/kxMVBILDNImxFAyHo4iDrlYs4o8ysmwCJOzeMYdMzl6ecLBpS3tcwl6yqZna9RTq0gRaLqR3ZWf1DnGR+qTNe1SJxgJ DR7YPUym gxuk1TIZIi7ktDXSk2Hlu+mHk5wlSUIU04NtGNWUJcoTtwdULsRXZIGUdQ2Ct4iQPuJA5PZv+uFdh9It4tSWx1sftatIPfIJO5PQu7Bukpfn5fK0sGei5cG+FxkPlke0TNuyI596GyXCfRVID3agQeCALjfyv12uwaYgJh9KvsHDxU1uOhxmrZqDFwKOjtlQW12zVdYyk2+xBcSLVxgzpclrtYSGaZoSEPwjp+SPB6YffD3rCy1jhYbFvHtz51TdFg68tC+W0QJoEXTn8ZyuRTuLDcq0EhGusdnM2+Y9rw+cf2/9+JiJu+4B+LHOgCTmDtWi0SipsOQTWf8HVXNRFlm2BdmFlvXVoVvJHTy04p/mPHNHg7HPzh7WSY6KBgjZPLZyw30qa7j4bz0Ka1n8XbPRjuwX09NEeHy4jjRnFVNtRcKJK1YIPXQsZG7i5w7u5Skdo63BE2PvxcYYi+v2wFDtTOPmXFGFSOUNdm3JXLBHIcrQKwmPS/SwROM3k1W5vBGyc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.07.24 22:46, Matthew Wilcox wrote: > On Thu, Jul 11, 2024 at 08:48:40PM +1000, Gavin Shan wrote: >> +++ b/mm/huge_memory.c >> @@ -136,7 +136,8 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, >> >> while (orders) { >> addr = vma->vm_end - (PAGE_SIZE << order); >> - if (thp_vma_suitable_order(vma, addr, order)) >> + if (!(vma->vm_file && order > MAX_PAGECACHE_ORDER) && >> + thp_vma_suitable_order(vma, addr, order)) >> break; > > Why does 'orders' even contain potential orders that are larger than > MAX_PAGECACHE_ORDER? > > We do this at the top: > > orders &= vma_is_anonymous(vma) ? > THP_ORDERS_ALL_ANON : THP_ORDERS_ALL_FILE; > > include/linux/huge_mm.h:#define THP_ORDERS_ALL_FILE (BIT(PMD_ORDER) | BIT(PUD_ORDER)) > > ... and that seems very wrong. We support all kinds of orders for > files, not just PMD order. We don't support PUD order at all. > > What the hell is going on here? yes, that's just absolutely confusing. I mentioned it to Ryan lately that we should clean that up (I wanted to look into that, but am happy if someone else can help). There should likely be different defines for DAX (PMD|PUD) SHMEM (PMD) -- but soon more. Not sure if we want separate ANON_SHMEM for the time being. Hm. But shmem is already handles separately, so maybe we can just ignore shmem here. PAGECACHE (1 .. MAX_PAGECACHE_ORDER) ? But it's still unclear to me. At least DAX must stay special I think, and PAGECACHE should be capped at MAX_PAGECACHE_ORDER. -- Cheers, David / dhildenb