From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE2B1C10F16 for ; Mon, 6 May 2024 12:33:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 523636B0088; Mon, 6 May 2024 08:33:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D3D26B008A; Mon, 6 May 2024 08:33:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39AD36B008C; Mon, 6 May 2024 08:33:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1C8BF6B0088 for ; Mon, 6 May 2024 08:33:19 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B4E3BA01F2 for ; Mon, 6 May 2024 12:33:18 +0000 (UTC) X-FDA: 82087911276.19.EB67B48 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf11.hostedemail.com (Postfix) with ESMTP id A2D1E40010 for ; Mon, 6 May 2024 12:33:14 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of yi.zhang@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=yi.zhang@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714998796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HCSSyBhvnnX9PRv8G+ITgV4QAExWES1W010uAzplFzo=; b=ECsh1++oWw3w/GTN2WVDfc3MrMCLZtGCBLDi739ItvbhswB1W5l6uXkEze4ov0hSZSNkMx lM8sewdzrrBAj31EyRBco5PxvSCSsW0puT7WEzIxVxZC1I1AvQ4I47to0hVtADDnF+h8GT QREwFlisXzXh6wDGp97ZouNlquF6nCI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of yi.zhang@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=yi.zhang@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714998796; a=rsa-sha256; cv=none; b=47jRA6vHTQzk4uqk+Fo4xNfWjHEgUGLnhsDRMdW/VfNa9ExDC+4Bq3AjwpcMCPcY/Qb8+3 eQvpAy1pmi3UYdJ8kV34EVDun84M8A95Srj4ODdjGv8v5/334CzTQsb1MR43by9VP7+6ru Ob8D1xL9h5hf2efGTrpUNB+p54L6rLo= Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4VY15k486nz4f3pG7 for ; Mon, 6 May 2024 20:32:58 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id 574AF1A11B3 for ; Mon, 6 May 2024 20:33:08 +0800 (CST) Received: from [10.174.179.80] (unknown [10.174.179.80]) by APP2 (Coremail) with SMTP id Syh0CgDH6w4CzjhmXgPPMA--.59039S3; Mon, 06 May 2024 20:33:08 +0800 (CST) Subject: Re: [RFC PATCH v4 27/34] ext4: implement zero_range iomap path To: Dave Chinner Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, hch@infradead.org, djwong@kernel.org, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com References: <20240410142948.2817554-1-yi.zhang@huaweicloud.com> <20240410142948.2817554-28-yi.zhang@huaweicloud.com> From: Zhang Yi Message-ID: Date: Mon, 6 May 2024 20:33:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CM-TRANSID:Syh0CgDH6w4CzjhmXgPPMA--.59039S3 X-Coremail-Antispam: 1UD129KBjvJXoW7Zw1ktFWkGF4ktw15AF45Awb_yoW8Grykpr Z5KFy8Kr12gr97uFZ2gFZrXryFya13Gw48WrW3Jrn8Z343WryxKFyjgF1093W8X3y7A340 vF1UW34Igw15AFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvIb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lFIxGxcIEc7CjxVA2Y2ka0xkIwI1lc7I2V7IY0VAS 07AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c 02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_GFv_ WrylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7 CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE 14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf 9x07UZ18PUUUUU= X-CM-SenderInfo: d1lo6xhdqjqx5xdzvxpfor3voofrz/ X-Stat-Signature: q57qwdgpg4orxikajs499kr1hwpwxaax X-Rspam-User: X-Rspamd-Queue-Id: A2D1E40010 X-Rspamd-Server: rspam05 X-HE-Tag: 1714998794-466978 X-HE-Meta: U2FsdGVkX18JIyIOXDLpW+sSqgXCCZB3WnR6Vo6HP5YPJPqCp6pdYswULVCZbw0l/Xp1GCsYX98D6LjapibO8bRlnPAKfi8PzSlI2HPyBTEhTEe3kpOEap0YqrD7NtXzIR8kxeIu+uBmUgtIwPM+AkvHbZNLXa7d0VgFl67CcQMrD6XUpLcAXXQahK9XrO89D5o82gTfJCvBU3wgceGFN++YhRFhO63hBtO4uGooEslaUmuF1S4w05nfUuIWB8A8HhhwNDE44B7KDjGBS219cC49pZTLJ9Pgc1EJ6BCGFihp12TetJMNliVvDoEt9HQ9djP1QJ4ZKVxf1aMXeJwsjJXOcX+6G3lFKszLxSVECLmZAtmElH8pgr2LJkrZI3dhcduTs9SOnZVqxh11YJ5KVcGyZeTAP7PkxPRKw92vgQfEp6sbZplRDc+XxFUhTcmze9tikQhLRDkFkkaIuZ27cnjAX5qweXO/1JPHKJ5v9fU2BbgfqPMu+Po6OUrbTP/8u5xSxIKLij5ztfyELYQGor9vvWnqoXIdgru2qImYeOB/NY911Q0Ss79S9Q0X2tTR4lEOjST8cOlfWwHkxELrMSefk8y6g4yoLDfg+y8260+3dc8O0w/EEHLxUyNQUTjq5xGm1BBRcE7cF04PLDrbtth3qiN82QE3Oy9awAiKgm3xNgjRZYk90Rl9cD/7cmUVxDuFRTk6BIQW2GUbYA2SwCJg7UGRtU570792DFS4RZShi0vOogkE0RK8GZKt7xD1XlfrYQYYQU8y4HXXzl8Ombfk+95q8K39uSWU5tFMVwv6Sur9U2yyjyVonRxw4BJ3OdHIZn9+RopSvsR5W7epj19ic9jwa8zSExe7CwfB0OHSYaZGXhSfOtEP6Uj7x96zCFDLiCqOcsapXBtPrWsCAy/C86Gr/fTnMbZ/jKKZaea+tbdWeEzc3ubA3AYKJAiR2jNpqhjQFFeaZuGy5DB ZhVzzA7F PW/Bmi8etMPVLAlWKL5PrkHSac+A40ZpTYNVzVjjYfNU9cgaZ/lyjGeKjE/AcxKDdloGfaOwVXSYi94W9QzmGKJJF0kEtw+jK759RWdX+wPz7MZDo63lbcDkmEZD73L+pmcqNTBLDZTn1Ng7+lisXHLtfVT1c30u4rG8h4t5K+qeT7LhGFV+iZeXmU2NwrIYDAFwIz2c93rH2ZdQG6tLNOSWYdtVQ//22HhhikXMBhSgFi7yvs4TQTho4nnJHiYH1ySQi+em6FKgZMc8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/1 17:40, Dave Chinner wrote: > On Wed, Apr 10, 2024 at 10:29:41PM +0800, Zhang Yi wrote: >> From: Zhang Yi >> >> Add ext4_iomap_zero_range() for the zero_range iomap path, it zero out >> the mapped blocks, all work have been done in iomap_zero_range(), so >> call it directly. >> >> Signed-off-by: Zhang Yi >> --- >> fs/ext4/inode.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c >> index 9d694c780007..5af3b8acf1b9 100644 >> --- a/fs/ext4/inode.c >> +++ b/fs/ext4/inode.c >> @@ -4144,6 +4144,13 @@ static int __ext4_block_zero_page_range(handle_t *handle, >> return err; >> } >> >> +static int ext4_iomap_zero_range(struct inode *inode, >> + loff_t from, loff_t length) >> +{ >> + return iomap_zero_range(inode, from, length, NULL, >> + &ext4_iomap_buffered_read_ops); >> +} > > Zeroing is a buffered write operation, not a buffered read > operation. It runs though iomap_write_begin(), so needs all the > stale iomap detection stuff to be set up for correct operation. > Yeah, right, thanks for point this out. Although we can guarantee that the zeroing is a partial block overwrite and no need to allocate new blocks on ext4, use ext4_iomap_buffered_read_ops is not appropriate, I'll use write ops instead. Thanks, Yi.