From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Dave Chinner <david@fromorbit.com>, Michal Hocko <mhocko@kernel.org>
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org, dchinner@redhat.com,
bfoster@redhat.com, sandeen@sandeen.net
Subject: Re: [PATCH] xfs: Drop setting redundant PF_KSWAPD in kswapd context
Date: Fri, 25 Aug 2017 09:32:14 +0530 [thread overview]
Message-ID: <f60c57f4-c7e2-9ae0-38e8-80c3f77f65e0@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170825000137.GI21024@dastard>
On 08/25/2017 05:31 AM, Dave Chinner wrote:
> On Thu, Aug 24, 2017 at 12:56:35PM +0200, Michal Hocko wrote:
>> On Thu 24-08-17 16:12:47, Anshuman Khandual wrote:
>>> xfs_btree_split() calls xfs_btree_split_worker() with args.kswapd set
>>> if current->flags alrady has PF_KSWAPD. Hence we should not again add
>>> PF_KSWAPD into the current flags inside kswapd context. So drop this
>>> redundant flag addition.
>>
>> I am not familiar with the code but your change seems incorect. The
>> whole point of args->kswapd is to convey the kswapd context to the
>> worker which is obviously running in a different context. So this patch
>> loses the kswapd context.
>
> Yup. That's what the code does, and removing the PF_KSWAPD from it
> will break it.
The worker thread need to inherit these flags. Thanks for pointing out.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-08-25 4:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 10:42 [PATCH] xfs: Drop setting redundant PF_KSWAPD in kswapd context Anshuman Khandual
2017-08-24 10:56 ` Michal Hocko
2017-08-25 0:01 ` Dave Chinner
2017-08-25 4:02 ` Anshuman Khandual [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f60c57f4-c7e2-9ae0-38e8-80c3f77f65e0@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).