From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>,
akpm@linux-foundation.org, ljs@kernel.org,
Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, liushixin2@huawei.com,
hucool.lihua@huawei.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mm: vmstat: make refresh interval take effect immediately
Date: Thu, 26 Mar 2026 11:09:48 +0100 [thread overview]
Message-ID: <f65f3910-f444-40bf-9d15-42a8b6215a56@kernel.org> (raw)
In-Reply-To: <20260326075546.3357901-1-yangyingliang@huawei.com>
On 3/26/26 08:55, Yang Yingliang wrote:
> The refresh workqueue is re-queued after last timer is triggered, so when
> the refresh interval is set, it doesn't take effect immediately.
>
> It leads a problem like this: if current interval is 8640000s (100 days),
> and we want changing it to 1s, the new interval can't take effect until
> 100 days later.
Well, yes. But, the default is set to HZ. If you set the default to
100days you are probably doing something very wrong in the first place?
What's the use case that warrants the complexity? Even when set to, say,
30s, waiting 30s is not that bad.
Would we maybe just want to set an upper limit to which we clamp? That
would be a lot simpler.
--
Cheers,
David
prev parent reply other threads:[~2026-03-26 10:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 7:55 [PATCH -next] mm: vmstat: make refresh interval take effect immediately Yang Yingliang
2026-03-26 10:09 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f65f3910-f444-40bf-9d15-42a8b6215a56@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=hucool.lihua@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox