From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D602C54E58 for ; Mon, 25 Mar 2024 12:36:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D65876B0085; Mon, 25 Mar 2024 08:36:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D134E6B0087; Mon, 25 Mar 2024 08:36:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C00D66B0088; Mon, 25 Mar 2024 08:36:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B1EFE6B0085 for ; Mon, 25 Mar 2024 08:36:44 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 47F60120139 for ; Mon, 25 Mar 2024 12:36:44 +0000 (UTC) X-FDA: 81935510328.20.FB18A10 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf15.hostedemail.com (Postfix) with ESMTP id 676BCA0005 for ; Mon, 25 Mar 2024 12:36:42 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R7jCO4Is; spf=pass (imf15.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711370202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HVD6kyr2yejC7DWiFF8eaBlp4UDIjmyFCY0XmmIOv6Y=; b=CuzGn+QhuPEDNbcrwb9rN7SHXRZwr2gqza0W1ozviRpVGql4GaehkLwoGDWG1NxCSoHuL2 k6FCAEmGzY2FHmklgcg/8MYnl3odBSq0DGKEE58aY7vICXEC3/x8+7qXHjyIQ0wdVgkP5f emqfKyXr7eUTRPwXZynUcqcbUkdOVhg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711370202; a=rsa-sha256; cv=none; b=y9p98S70hsDOaewfXjXAuatR/aRqfWQVT1lkCyw1lVQ873dEq1Q+Ud8OV3oZBvDswxidx+ /FKbj92JYz2qqvN1jUaFqxjfx+KEnouQouNJ5wr/z+6zU5FGm5iteEYo/R0KLOyIdjUvJC 6wkCj0wn4whYL3ia8bUn6oVfmXkPjCI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R7jCO4Is; spf=pass (imf15.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6e6b729669bso3519790b3a.3 for ; Mon, 25 Mar 2024 05:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711370201; x=1711975001; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HVD6kyr2yejC7DWiFF8eaBlp4UDIjmyFCY0XmmIOv6Y=; b=R7jCO4IsAIy7p+cMQoVn81hCgQgF2ZbymdfxRboJVnlEgoFKcvBC5vTlvEPhl1iNTj fd6BOY6MkhyPjutcF/AYzHBkiASzhMEvkw1wjzZ6/ZvJBUEcNFrE5dm4oJ7ol1BmhILU WYeWl359iQmHIes1uV2xjnThdhrQrQs77kzDoS6+Lr31pDvsvx5cjyQpME7IirCEmiWS H8mYbcPl+/696KhsHEYcT1vQ5GliD/2oVdUwXB5DGbbHcTeFyUC2H5c8djn27P+ov9gH 6l8jnr42rkDfZQdx7C9j+w0IjC5wikGP+6cYQ32D6o8K6lfSkpng3/KHrhWJMMPOxP4K pAvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711370201; x=1711975001; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HVD6kyr2yejC7DWiFF8eaBlp4UDIjmyFCY0XmmIOv6Y=; b=pkFdmtCpjHDgIu67O6ez7tZT1n1PspsGz41IaxOPi0ccERGmEjB9KLAQccJ0Fkq/B9 IMxa2oY7J4CocCCOxEKpvX7pdLHwiWFYXCRZ155zoetYSqY2XgK6hnPGlg6HeTZbNksx PM3xQWsIp7FBiKnXwWyUJW3kVShHyIHiV/Lphz/gCO5yPRDERbgE/R9KUBZXKeMyCs99 yIMr2UWgb7mmvBQLuTRyMWXXYOgo+G4SxeiZRuvr7Yh0IeHCxt1Mo/WjjsOuD+CIK59N mHry2oUTXQTQmqMSXQYtsCfrPlmEWV+0nf1TAf9q0LTE6fMAd3kZwyb/mHD388/PQnon hQRQ== X-Forwarded-Encrypted: i=1; AJvYcCW13NIpfQtxayxs7jphO715HVnBnTsWKsrcNdfPC/l7d6696E9jS02gS65rRa4Jto2QOOw6b7lR80mu6sQqW94PcEc= X-Gm-Message-State: AOJu0YwvTsVnWHx1u1YJ1E4TLwlEAGut3/SMWLHIbqwS1zLd0e7AkE/H iewvR2SYxLBskXxE78xZ5WXkH656E2RTuhyIeKtYqBkI0BNpyDwO X-Google-Smtp-Source: AGHT+IFSAq6ifk8Zm6QypSlyeD9gVsuzinOO29bEJo4kN4j84rCnSW6AUJHOinRtT6jayDegwGpJyw== X-Received: by 2002:a17:903:32ca:b0:1e0:1bc1:478c with SMTP id i10-20020a17090332ca00b001e01bc1478cmr9186425plr.22.1711370201243; Mon, 25 Mar 2024 05:36:41 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.20]) by smtp.gmail.com with ESMTPSA id h20-20020a170902f7d400b001db3361bc1dsm4575112plw.102.2024.03.25.05.36.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Mar 2024 05:36:40 -0700 (PDT) Message-ID: Date: Mon, 25 Mar 2024 20:36:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/14] mm/ksm: use folio in stable_node_dup Content-Language: en-US To: David Hildenbrand , Matthew Wilcox , alexs@kernel.org Cc: Andrea Arcangeli , Izik Eidus , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Chris Wright References: <20240322083703.232364-1-alexs@kernel.org> <20240322083703.232364-6-alexs@kernel.org> From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: b1fjd7wyw8o3refmjkqe89q7nhepnr4x X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 676BCA0005 X-Rspam-User: X-HE-Tag: 1711370202-566711 X-HE-Meta: U2FsdGVkX1+7ZnowWapHRfrH1PXBi0vrbLZCxIHY0w1YgoZxTvGXdb1oIWIMPCBRG7+RrwgU6QgSmjJEdOV15hcyU5zRfD98b7AbgYn/wG+Za2+xbjE4hbY5ZxgQTgcd0re2JxadfLpJ4FCr0DRjuVnO8RtlDXhkw60GqLhGBMjOf7rAtV1f3kcr6oLt/BY+pgKpqgA8Wwc5wnoQhz5HlI9yQCxOoKEmuVhs4wEd9bwGqYvW3vwQF1n4+snB5bahRIlZhS4qmR8las0NgWg+8Ngdq0paYouUTuO9BnYBjwkgcsV470N7pEKSDFzdpPCCDRLHkWFzePDtQs/N/kxPT8Mq26tS10VFTSsjLOu1n4yOHtXnKUcxmy6qUAHjS/KWBokuLgKPDh8SC5K40U/CGgIZqVGNuhBTe4IKi7l3bdhQii4bxvB1+CsDFmPasrMNBwdYDohfpbBI8hGpFGkX07pbu35CE9QPRt2rqP9QYkppJNBDl549zxfXhQ87fCnzeE6IUXtzzKd1Lo+82Vi5HZmnVZ6LVxbDOlXkVErRYrv2nAjMAmeCmqrXOhlJ0pMQNv2Gmlowsx0x2FFkQxhHaExaEKBG+FZgB7ttEok159CxSAqWoJ2pGdw4C3erdTBXTq6aoMbdjLrtdY2Fs6YZP10TFLMMsTwhb8gpbY4vCnCEELKWcuhj2N/gMjR1tCcUBzgeU8i+AM38MMaEhHKtOqCc68bAnyXqdAIk5+9ioxg+WWCRjWz+sWbxS/kE/MMKVH7fN6flYm981m+FMA5Mamn3LTKMMjlkUdTyGf4ti8VIqW/gtg/G1UmOGx8zJCpfuNb/6qMElgRyyLVaCyJiwoy9cMbhMmimbxSZAUdD020gQAJGJ0VieDhBw0QhQpPT2fxNSkpmZcKydTRo74054kHncTY37xgJ1Mr8sGzgNlhi8klucYMNfPwoE0rlY9NqkQuYATG7t+TSuX6BG4t nqLlFliK OYwhBRlmGA0h7gcpdsxGYxXDlv4WNiJ8CXadJA7MqU82Z8kZeT71bTug24m2PpVuy0WpckKLwquHQ89oD5WAI1RyXO1wJkw640qy7NQSkBAcl/wFy/VhhbaQQ3NmDIaepzUSxqZ/wpRpvfb9B8qTTqI7sERt2BXW+3MwDlkZk3FFKs7JKsIldHYxfwAgzlnzZ5dHolBcc894n94oJG2E6f34cUOpG1bQ1wXHZJM9LmRGYnze1ERsH2StR0J1kXj+p/4dRQ5COhFS/Ixy2GUDKIl/w+l3EvXxgJ5djZUIsW6P+iBrOvGo0Pnj6/fE3hl+EXZ/tREybY2vzvhR+/frV+vxEfbGQ3znJhjvKts/4au/afKavDuz1HUW06FTCslWCN7dImnAnvfRiz3C3gYm0zbONxHEmOmcPd4Gm1dGPjxdqVhMUkNNgdvVJH5W6IW4i5WfUkpwl/oP7W991Lb86eUjxR6CqoVChBzdpUEwciUpuVtKlx4M9B7+cBomSqYpSKNXc6vvrGhbAzoTg375euSt4WOz8/fu6V2OznnU3m6KyUR59cUM4Ig8l1AZ2ukJdqz0Vg7nbKNkxGbnw0e3Thk+p2iwixrncrXtr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/23/24 1:11 AM, David Hildenbrand wrote: > On 22.03.24 16:57, Matthew Wilcox wrote: >> On Fri, Mar 22, 2024 at 04:36:52PM +0800, alexs@kernel.org wrote: >>> -static struct page *stable_node_dup(struct ksm_stable_node **_stable_node_dup, >>> -                    struct ksm_stable_node **_stable_node, >>> -                    struct rb_root *root, >>> -                    bool prune_stale_stable_nodes) >>> +static void *stable_node_dup(struct ksm_stable_node **_stable_node_dup, >>> +                 struct ksm_stable_node **_stable_node, >>> +                 struct rb_root *root, >>> +                 bool prune_stale_stable_nodes) >> >> Do we really have to go through this void * stage? >> >> Also, please stop reindenting the arguments.  I tend to just switch to >> two tabs, but lining them up with the opening bracket leads to extra >> churn.  Either leave them alone for the entire series or switch _once_. > > I wish the coding style would at least recommend something -- I know, different subsystems/files have their own rules. Nowadays, I prefer 2 tabs as well. > Hi David, Thanks for comments, 2 tabs looks good. But just this file keep using more tabs. For the style alignment, let's keep them for now? Thanks