From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87093C3ABC9 for ; Tue, 13 May 2025 06:06:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9872C6B000A; Tue, 13 May 2025 02:06:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9364A6B0083; Tue, 13 May 2025 02:06:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 826336B0085; Tue, 13 May 2025 02:06:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 639C26B000A for ; Tue, 13 May 2025 02:06:53 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C234BE31B5 for ; Tue, 13 May 2025 06:06:54 +0000 (UTC) X-FDA: 83436851148.08.0FB82FD Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) by imf12.hostedemail.com (Postfix) with ESMTP id AF45B40008 for ; Tue, 13 May 2025 06:06:49 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=bhwanz5B; spf=pass (imf12.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747116413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fUPTQE19Sg3GsFNuknlANEEVIykzFfRofXNpKO+DKkU=; b=OJrfV+0BNn5wH4WOQaFyPogI/PWolotE4rhBtEmkMM0qNE2hI7ewt342KpHwsJLZNcPC7f wdVU7Yded1oXXOVYpdfuG1ixlvWpYUHu2KJd8J5Yt5ONSFqeq0E4Ha8IovnSAAMEabeCTS w/PoCcA24nVZmcOUfTAE4uPUinuOS4k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747116413; a=rsa-sha256; cv=none; b=f/mLOW0W9BSIMe/TSGUq4zZVHwpUnX39cqZOkabmmE4C2CUvM9GQLOI8q71uJLowTf7VwJ eaNp8XarFT07p4lXdahIuyF/WTvP2TRY1nzAQOWo3OYLjG09IJFLnkEkePDEA3u1sqkEbA I3SV6AEVztIXQA8+OeTgp/WpVBA5GbI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=bhwanz5B; spf=pass (imf12.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1747116403; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=fUPTQE19Sg3GsFNuknlANEEVIykzFfRofXNpKO+DKkU=; b=bhwanz5BVFViBWpMDF85lvUf+TNuZana5uIEyfBuUD4dBfz9U1sESuJrfss/a1WFgYkBFoLcfCWasm73xbd3Q1SChkyNNTWlGXqoqAQtVjr9k6SNHoJ82FczN+EYNOY+zpQ8YpDVo6mYQacpZuR+D9asxDA9X40IBTv0ClTytvA= Received: from 30.74.144.114(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WaULMRz_1747116401 cluster:ay36) by smtp.aliyun-inc.com; Tue, 13 May 2025 14:06:42 +0800 Message-ID: Date: Tue, 13 May 2025 14:06:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm: khugepaged: decouple SHMEM and file folios' collapse To: David Hildenbrand , akpm@linux-foundation.org Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, ziy@nvidia.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <5d5e50f1-ee5d-4fca-8d7a-31482a8482bb@redhat.com> From: Baolin Wang In-Reply-To: <5d5e50f1-ee5d-4fca-8d7a-31482a8482bb@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: ub7zddoh8ezxbp7ri13yntebh3k8yse7 X-Rspamd-Queue-Id: AF45B40008 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747116409-60273 X-HE-Meta: U2FsdGVkX19TXoPCO/4IetIOTRm7fttb3N8S6CA5BKskk98m428845fvL5Ph3FT8dfjIpJd9rJCot4reCTmLrCH9sBahxEIIn2/rEyABJ9cStJ3zWDWnz343zYGwMXKsNWg/SkQV5zQJpXX7klftHWHiseT3sTYh3M2NYhEeFuTWccsoK06MhvYfp2mqDXc7yhOcqfqD1GxdgvmhrL9F1q5ROJU+IRIx5hRrrV+yX2Tac91vvoK+NOIgIqfXdvBF5EOxwJrVw7sl1h7H1DcVcVXpirYrD/HD77pZ+aQOtO0dDFv1RASynwJO+dFmgFxkaXG6H3N3u8msuD+PByxUqsFRhzLSD0a85ezpzyusheQlvz2JZY3Xpweu2S9eRFWrw7HC0ECIPLwwbFLlw9mL+JXnH0fASJGY6gTADKwHDsho+VgHcyYGu1zA16wE1dFNh2vaM3zIeETinE6/Perw8entQ1A5Fi7xDT88JDa4xLT4PwG4ug7r6O8+QpGA81woo6uPZYRdqTGh4oBemxx1BWKASY/j6EDr3dHBLR5sON0Bw4MgapAr83+MKVlbgUIElrh48Rdn1GFCmHeQSPs+utoX604tRfr2Gha+46J9eRPQgaK8Rb0LAIBlfIHY21JKXxXdtVplE/rLJCjGEQ+/1EFv1vM6l7JOUFO4zwpaMavdVUh2BIG+ZTuodGowFRINWbw5HVH2D6k4OLOIzAkwc2X6vIGJX8szJ74mNqoQ81S7jewruR8sUCaZwX2sqIfDhhNvzcARZUNW+mltRVwdp41ymvwpGqQB2u8Jj60tpu70S94750exj6Z6kHSg15eh7jjiLH5rgoy9LHNjM3rrMcXUZm0ACSXWwuZjAZgQOyT3NPzaqx8AC0nyKft4Wv+zVSqcGRopDZSkvbrlAxPjl12YAWIsVDr/12zWlEvxZwE9X7F4dG2fubLmn+h+FSsUIbjr/9h28nGBJV+pGgt e7oJZQv1 d3XL0AS/42hjzaGT1LG9qvPJAcbvkStCAnEkccb60u5YDqdynRnFYliVvbpV2s0IJ03FjIylyXz2ntztfaUDSl/+swBi2EN7S1AIJIUC/1ooM6pjmTrpdyOT3yJXWT3fOwUQ9lmDBdSD8cWKdFTH4tL3gg3eUsIuPvhytp8yLIu67uZr01MCYFnw1CeFUU3nRyqqR1M9HuKLjAi7d2G5+xXrVPQBpqCcOxQBAOmh5Zbv2Pf1HMLn6cw61IenwCiyX6D9mQr7c/4EPd58zb0E8Uzfm20QYIA7Eatos3j9emT6zwuZ+mqhrrZOWl70beuJD3DOtX/p+VVjkV6JgOXyxJbA4OA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/5/12 16:08, David Hildenbrand wrote: >>   static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int >> *result, >>                           struct collapse_control *cc) >> @@ -2436,7 +2427,7 @@ static unsigned int >> khugepaged_scan_mm_slot(unsigned int pages, int *result, >>               VM_BUG_ON(khugepaged_scan.address < hstart || >>                     khugepaged_scan.address + HPAGE_PMD_SIZE > >>                     hend); >> -            if (IS_ENABLED(CONFIG_SHMEM) && !vma_is_anonymous(vma)) { >> +            if (!vma_is_anonymous(vma)) { >>                   struct file *file = get_file(vma->vm_file); >>                   pgoff_t pgoff = linear_page_index(vma, >>                           khugepaged_scan.address); >> @@ -2782,7 +2773,7 @@ int madvise_collapse(struct vm_area_struct *vma, >> struct vm_area_struct **prev, >>           mmap_assert_locked(mm); >>           memset(cc->node_load, 0, sizeof(cc->node_load)); >>           nodes_clear(cc->alloc_nmask); >> -        if (IS_ENABLED(CONFIG_SHMEM) && !vma_is_anonymous(vma)) { >> +        if (!vma_is_anonymous(vma)) { >>               struct file *file = get_file(vma->vm_file); >>               pgoff_t pgoff = linear_page_index(vma, addr); > > Yeah, I've been complaining about these checks for too long :) Yes, I know:) > I assume this is fine I tested khugepaged selftest, and no issues found. > Acked-by: David Hildenbrand Thanks.