From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>,
zhengqi.arch@bytedance.com,
"Liam R . Howlett" <liam.howlett@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Michal Hocko <mhocko@suse.com>, Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Shakeel Butt <shakeel.butt@linux.dev>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: TLB free bug in 4c640eb4181c ("mm: move pte table reclaim code to memory.c")
Date: Mon, 3 Aug 2026 11:18:18 +0200 [thread overview]
Message-ID: <f679cc17-643d-4c39-8bfb-9816e5f4b5a0@kernel.org> (raw)
In-Reply-To: <f2eb26f4-62e2-4a16-a56b-706adf230cb6@kernel.org>
>> Original report here:
>>
>> https://github.com/BurntSushi/ripgrep/issues/3494
>>
>> I haven't sent a patch because I *still* don't pretend to have
>> followed what all the tlb_ functions promise to do, and I don't want
>> to submit a subtle patch based just on an LLM telling me what *it*
>> thinks those functions do. I could trace though all this mess
>> manually, but I bet that one of you actually remembers :)
>
> The memory.c code is definitely broken. I guess the real question is,
> what the effect of that is.
We should end up in tlb_flush_mmu_tlbonly(tlb) -> tlb_flush(tlb) ->
flush_tlb_mm_range() with the wrong range, so yes, please send a
fix asap, thanks!
--
Cheers,
David
prev parent reply other threads:[~2026-08-03 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 14:00 TLB free bug in 4c640eb4181c ("mm: move pte table reclaim code to memory.c") Andy Lutomirski
2026-08-03 8:31 ` David Hildenbrand (Arm)
2026-08-03 8:33 ` David Hildenbrand (Arm)
2026-08-03 9:18 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f679cc17-643d-4c39-8bfb-9816e5f4b5a0@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=liam.howlett@oracle.com \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=luto@amacapital.net \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox