Re: [PATCH v3 1/2] selftests/mm: respect build verbosity settings for 32/64-bit targets

David Hildenbrand (Arm)
2026-04-23T13:38:53Z

On 4/22/26 10:04, Li Wang wrote:
> The 32-bit and 64-bit compilation rules invoke $(CC) directly, bypassing
> the $(Q) quiet prefix and $(call msg,...) helper used by the rest of the
> selftests build system. This causes these rules to always print the full
> compiler command line, even when V=0 (the default).
>
> Wrap the commands with $(Q) and $(call msg,CC,,$@) to match the
> convention used by lib.mk, so that quiet and verbose builds behave
> consistently across all targets.
>
> ==== Build logs ====
> ...
> CC merge
> CC rmap
> CC soft-dirty
> gcc -Wall -O2 -I /usr/src/25/tools/testing/selftests/../../..
> -isystem /usr/src/25/tools/testing/selftests/../../../usr/include
> -isystem /usr/src/25/tools/testing/selftests/../../../tools/include/uapi
> -Wunreachable-code -U_FORTIFY_SOURCE -no-pie -D_GNU_SOURCE=
> -I/usr/src/25/tools/testing/selftests/../../../tools/testing/selftests
> -m32 -mxsave protection_keys.c vm_util.c thp_settings.c pkey_util.c
> -lrt -lpthread -lm -lrt -ldl -lm
> -o /usr/src/25/tools/testing/selftests/mm/protection_keys_32
> gcc -Wall -O2 -I /usr/src/25/tools/testing/selftests/../../..
> -isystem /usr/src/25/tools/testing/selftests/../../../usr/include
> -isystem /usr/src/25/tools/testing/selftests/../../../tools/include/uapi
> -Wunreachable-code -U_FORTIFY_SOURCE -no-pie -D_GNU_SOURCE=
> -I/usr/src/25/tools/testing/selftests/../../../tools/testing/selftests
> -m32 -mxsave pkey_sighandler_tests.c vm_util.c thp_settings.c pkey_util.c
> -lrt -lpthread -lm -lrt -ldl -lm
> -o /usr/src/25/tools/testing/selftests/mm/pkey_sighandler_tests_32
> ...
>
> Reported-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Li Wang <wangli.ahau@gmail.com>
> Tested-by: Andrew Morton <akpm@linux-foundation.org>
> ---

Great

Tested-by: David Hildenbrand (Arm) <david@kernel.org>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>

--
Cheers,

David