From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A9E1C54756 for ; Thu, 22 May 2025 08:43:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 191016B0083; Thu, 22 May 2025 04:43:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1427D6B0085; Thu, 22 May 2025 04:43:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 009516B0088; Thu, 22 May 2025 04:43:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D9C2F6B0083 for ; Thu, 22 May 2025 04:43:01 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DFF92BDAAC for ; Thu, 22 May 2025 08:43:00 +0000 (UTC) X-FDA: 83469903720.09.3D56B7C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 7FF368000B for ; Thu, 22 May 2025 08:42:58 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V8um3igX; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747903378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y+JhIAMtHUIDratsJJY78KupDIZPpYinM48aTm1d/JY=; b=PNgzR5F6aOZFBn4e+KFeCxDGCq9W2BKkkTN+FNS/UzWpVTnFaRXRxQ3MP3LZsV3FWXxOan +EwH1xP5ul/Rh1+0XE0gn6x7C3MMT/jjd5oWZ+fDS/hyMXn7pMzEOusmpzMpX+B+RZUNAh N63R3DlGEUF2XsVHiFgaHdzxKmiqXoQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V8um3igX; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747903378; a=rsa-sha256; cv=none; b=TLiqa9e/c/ibMF80x/G+yjTnG5h1oluhwUV4YefHe6Tl8YOBy1WompzE8Sr83Qlu2HFR0T aPfvjpyT7CRVt63VxftCDqEqOyT+cMQ7BMuqpPBjg+I1beJJpNSsm5sbbdEyBq9shVz+uM MpVMwX2ayagkYMKmmXUTCi5laDH7MxQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747903377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Y+JhIAMtHUIDratsJJY78KupDIZPpYinM48aTm1d/JY=; b=V8um3igXKAHbU9vHL32KAd9Jnk50zXxmX/9YUtx3S4FyK7QFQb7NJzW9QT6f/iWEUztD9I huQZ9f+YxxSujBudJYKK1Zp00b4BCviVueQs/rsYQZ10/XCaJGWZ41ifsxdqekATbX0bV2 tB0Qa/WtVap+Db48brzw8u13vr1v5ho= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-474-x4tqh7tSPcKnsx3FLJkr8w-1; Thu, 22 May 2025 04:42:54 -0400 X-MC-Unique: x4tqh7tSPcKnsx3FLJkr8w-1 X-Mimecast-MFC-AGG-ID: x4tqh7tSPcKnsx3FLJkr8w_1747903373 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a36a4c70b4so1837833f8f.1 for ; Thu, 22 May 2025 01:42:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747903373; x=1748508173; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Y+JhIAMtHUIDratsJJY78KupDIZPpYinM48aTm1d/JY=; b=a7uN4/d/ItRoEdD8yglwcVT1XnuVJ3gQWl4G2T4lz0NH44NXymeUhkCgPM/MIm3/Db KLFUOtK/QhD5mPJL4Dq8wistRmIp+2E2d6Qudb2NX4fFS6re2/+ArFBaAN7VTVQY4naT j8NOkWQZjFGLn41wsgWsLKcu2vTyyHpHRsZUAEyHyN5ImmdRBgTrF6WB1Wy99bJuIOfl 2vvmg4NNXAd7wy0kHM2/wc5fnVfcZ3OxiXbRPWMCdHHAZla9bICUGfAFgavKX1ZHbnWg 26ZDz75rqrjR9QvnG/3WtUzkcYyuB4hmQGrF09iBG24jSAvDawOO1K0MrzZWJrCoVdlx Tw5A== X-Forwarded-Encrypted: i=1; AJvYcCVebyfs/3/fHZ9NZAWVA6wRh9zqisMpE7gwYmBUADQfZGqx3g4IaGnkHR1bx3v7/uJ2Z4VEt8/xpg==@kvack.org X-Gm-Message-State: AOJu0YwPM/SDbMpUrOH3XpiO1Z6EUPPJbC3rw5Lppp1xtNfj4SobMcnH 4at75xOEAN/eHgZ5B5LE99SuVskYUNFvvVSg6j1JKDwHFLr5MCzH2wT/r9HMstnQAG5qa479ft0 8pM3se0hLCgEO0vH5qU6O4hcSkb7m4WmlCy11kRo8o/OhI1Yjsuju X-Gm-Gg: ASbGncvBAyUKcbNqgqmp/mSQKOcF/oaNpnFHpKNiuT11/8IKudZCq3OVPGSjOFMFvvY G60VMR/7j0HutHawV9rngPwhahYd9PK3kqDW1IfPRnH0ejEVVSstbXEM830xJuLklT9bFZeWhIm QTL4NztEgtSRz+0gy+0s+T+RsEVN1tzc18Z6V7Fr/GJbszIpM+s7pdl7qsfSvdJMpM8lCG2uWl3 a8JqfpH23Tgx0qgkNRStMtdfWMinkFKiFyiNQl457C3zk8XvFraxxghexylY+B8hvPZAmm/caxg 9Y4wTCWnFlg5NK1jnAkgEUjQUNOjO0AZZDk8GWqAu11SjUEc7XE= X-Received: by 2002:a05:6000:2012:b0:3a3:4b95:a8ce with SMTP id ffacd0b85a97d-3a35fe5bb43mr19588985f8f.4.1747903372766; Thu, 22 May 2025 01:42:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGz3Y59UeX0GI553areSAAultGv2dYGzLX+MDxO1ZCQLWx07jpD+bfnH7brjiXOk9VkcyUhaQ== X-Received: by 2002:a05:6000:2012:b0:3a3:4b95:a8ce with SMTP id ffacd0b85a97d-3a35fe5bb43mr19588952f8f.4.1747903372277; Thu, 22 May 2025 01:42:52 -0700 (PDT) Received: from ?IPV6:2a01:599:916:16c6:54bd:1780:84bf:8f90? ([2a01:599:916:16c6:54bd:1780:84bf:8f90]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca4d230sm21902505f8f.4.2025.05.22.01.42.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 May 2025 01:42:51 -0700 (PDT) Message-ID: Date: Thu, 22 May 2025 10:42:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Fix test result reporting in gup_longterm To: Mark Brown Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250515-selftests-mm-gup-longterm-dups-v1-1-05f8f731cf63@kernel.org> <58dbef73-6e37-46de-9092-365456306b27@redhat.com> <46d151d7-c04b-4538-9725-dc4f46ac8ac1@redhat.com> <8131ce62-0cee-455f-9eeb-e2bbed244402@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RG6EWaShxePkXlUMSaQJiX5q5mVpiV0KZHcjyCO8fMo_1747903373 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 93nszq1zedfjx6aj9543omemr8fe9uet X-Rspamd-Queue-Id: 7FF368000B X-Rspamd-Server: rspam11 X-HE-Tag: 1747903378-183057 X-HE-Meta: U2FsdGVkX1/suJp7y5u7Nsd2VMj+LkUwvrgsrRm5vxsaKLZPfKjdsVcDph3u2DANiHnYeJhbR45M7y4BQanCCA4+xB/ge9hgu7KDCkSslvsI7UCIX/wV0F96GMYyUR21q2VUuQdSqSThB+y9og2SIlMJuoegi9Kv1jcJGOAC0xtCmEIWZGv7YW7K4aOwJOC942Qlv+p9srCSNJP9LcSUNDo2XoVeJHH9CoQNvwsYBfCwgjRtqNR3f4Tok/aT5U8MXmKU5gMIsq7b0RQXJVWm6pSRi5RPuoenSaL/xsiYCPHzP5bsHzFLYKYzSuTLGNU+eN9xz8rV47eA7nFpqEzUEa14YvsPYg2OQu6HrdCxLekjiDKJq5/nMuKQU/X1K8v5BJM7e6k8o+IbC0qpnnsBRXpjxSkrg/371q3rNdNoIe/LntJoBV083TD1pYkNN6soRCVqIIGW/NiiwBtZuRs6GOgvTigYhGVGyyXSDVA6YRjZFkfWzqVo7XQi7NGZzl54tMutdbX3SUV5z+yKDzAQolnhU0iYX11Np9E4BKNVqKnIjD9w8UQ+7wMthgk5abxCstF4h3mk0UZCUfb+8jnNMF3yAY7YFpjpDuwooo0pHKd3v7l2bT8VRfs18gNz9VjI/WysnahwXLii+LqhQ+dRPUKm3fCaUMsylr2MJ2vpl1RKoBCAUuF4iMUwJGlBbgfuzPI9wvP9zy8YxIMFXW0uK139e+HQFwxA90zO+G4Z/QTGOjOQap1gcnoOqAo/1mJuhF2ULQKmdLZlZwHqJ30+c0mhKXZYYOphdOy/as5bXKEunexCINgbGpRNpKlbrzs/2r3BXUqziY5jBAJK88i8SOnC1e/Wr9I8JS9+x21cPYDwrbYNDiAH1CqfTtVw3DixXu+IMPdBmoYttdi0qQgjRweDofQsUmsHzA3PngdCdPKDpYVy8hBIYGorNK19VH7Xcnf62htpVzHM5he2ETb af+QPZjK BbYslXV5P+8rjCifOcCKo6dqOwgAw/FRURf+rto9POlTaPn8oT/2rmzFxTkff8BmQJ5WYjPPVMoXsq7oDvlK2WuzsxhT5EAXfHnDpkjbKbxARZi1DjK0vcR7gvJPZl2w52VXh4iQMTQ2SE/nUGfQZkPhk8dyvQdrRjMKGqOlVJieQdWcBcJ0rTR2K/qilhilWreqVjdb82dGNHYUel06ADfl2I2b/bSpEOkpIyeSPPCRkYjNY7jLVvnBKjiEYxpOlWe4a9c3f/sVwFATHkBY5tiUbP5XDx/s8ffQj+VITe4uQcp0f+KPBq6NLDJdFUivxwFtENbHkpv3HLivoQsR0Wd8wNT5v/S5VcSo5UlrPt5DoFnA0KqKo3semEowOpwCUxjlZd6Kbuqm/FRHm6VWxvNWJE3LgNJQos690+Y1CKrG4+0n53ConyDZVRI0vs0igYqL/AHHlxrXyRREiBviPFrmB4FYeL4k1eK9+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.05.25 20:48, Mark Brown wrote: > On Mon, May 19, 2025 at 03:28:47PM +0200, David Hildenbrand wrote: >> On 16.05.25 20:07, Mark Brown wrote: >>> On Fri, May 16, 2025 at 04:12:08PM +0200, David Hildenbrand wrote: > >>> [Converting to kselftet_harness] >>>>> That'd certainly work, though doing that is more surgery on the test >>>>> than I personally have the time/enthusiasm for right now. > >>>> Same over here. > >>>> But probably if we touch it, we should just clean it up right away. Well, >>>> if we decide that that is the right cleanup. (you mention something like that >>>> in your patch description :) > >>> OTOH there's something to be said for just making incremental >>> improvements in the tests where we can, they tend not to get huge >>> amounts of love in general which means perfect can very much be the > >> I would agree if it would be a handful of small changes. > >> But here we are already at > >> 1 file changed, 107 insertions(+), 56 deletions(-) > > So, I did have a brief poke at this which confirmed my instinct that > blocking a fix for this (and the other similarly structured tests like > cow) seems disproportionate. Thanks for giving it a try. > > The biggest issue is the configuration of fixtures, the harness really > wants the set of test variants to be fixed at compile time (see the > FIXTURE_ macros) but we're covering the dynamically discovered list of > huge page sizes. Yes. Probably, one might be able to revert the logic: instead of running each test for each size, run each size for each test: then, the tests are fixed and would be covering all available sizes in a single logical test. I agree that that really is a bigger rework. Let me take a look at your original patch later (fairly busy today, please poke me if I forget). -- Cheers, David / dhildenb