From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33B4BC46CD2 for ; Wed, 3 Jan 2024 02:21:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 942C46B02DC; Tue, 2 Jan 2024 21:21:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F29D6B02DE; Tue, 2 Jan 2024 21:21:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BA5B6B02DF; Tue, 2 Jan 2024 21:21:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 69D206B02DC for ; Tue, 2 Jan 2024 21:21:10 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3CD8B40275 for ; Wed, 3 Jan 2024 02:21:10 +0000 (UTC) X-FDA: 81636397500.13.49E54B9 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf21.hostedemail.com (Postfix) with ESMTP id 35ABE1C000A for ; Wed, 3 Jan 2024 02:21:06 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="DkO2N/hL"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of gang.li@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704248467; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fnnzaHHZTJxojy45dlDauVj3BDpS6sAOuvKNoVP4Lz4=; b=NJbOSPAWJXCYQwIzH4Iz7dGhuyGEcTERmM5s1z0ssC+LTABKxGbK6zvXNBtSVKMdtY47Po AlY252+M4ho9EU1EEYyqOaKjpC2BajiW0tzfkcItIiMRTVAp/7n5A6G83cIPxEr+XXAi06 M+lc57ejixlXt3ztQ70grk6uPWOQJiA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="DkO2N/hL"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of gang.li@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704248467; a=rsa-sha256; cv=none; b=CfuO33tGStxwIUxm0dq5maYax0xsh8u2GBPYw1Gyd5G3VBAl34Ko19iAjwHrX5HJk7oZoQ NDjQw9q8yk1Yex14CoR3dV4HvsaTfiT5/gfBLBQmw1Ynde7B78r57YMyrBM1QojQckxuAN 2LXpi74QElVHOSj/782etQ0yy5kdQGw= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1704248465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fnnzaHHZTJxojy45dlDauVj3BDpS6sAOuvKNoVP4Lz4=; b=DkO2N/hLoWlU/Xi0uGUM12Bqfsjd0ear7adaK2Sza8y+ahqXdxnVUJjVrX54d2wk/xfWpP lnh7YE+I0W+5aOYcDjssIdoDbFbj7CkXfc+Ng4Irl+zBD004Wu90tcUeSFpJCfI0Joh8d8 lC8GMUZVxhM/zRDrgHZJa0W6eXWtatc= Date: Wed, 3 Jan 2024 10:20:58 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v3 0/7] hugetlb: parallelize hugetlb page init on boot Content-Language: en-US To: David Rientjes Cc: David Hildenbrand , Mike Kravetz , Muchun Song , Andrew Morton , Tim Chen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com References: <20240102131249.76622-1-gang.li@linux.dev> <5c30a825-b588-e3a9-83db-f8eef4cb9012@google.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Gang Li In-Reply-To: <5c30a825-b588-e3a9-83db-f8eef4cb9012@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 35ABE1C000A X-Stat-Signature: 6wprdnqmpfz7a66y81kwtmggkkoq7539 X-Rspam-User: X-HE-Tag: 1704248466-46831 X-HE-Meta: U2FsdGVkX18Z2bPDjpCIBS30NxwemkPpdtFjEDvY+hDszmg2CSCD0QOs1g83zl0Qbrb7w7p8WJcqMeJO29Z/aG6fI2zwGhFdoOJ96LBHnXTdceOUOdo2Kiva0iiLnw3ujQ2wDWRUk917dK71J34wyK263EXom0QMKsuN3pMDlUZUdX0iDJ7HoocBcyZ48S2uB4ojPEO2DvxwG9eORmmTf4U7f35wcMep4QbCVjMaLWm9DznOdvLrnmP6Y48EfWcViRCjFLCO5T+Yw5qftA7fi7dqgO6+84yuLJbuPhMfkTAok6bErw/6RzEYjHP8NcE7OxB4LYFh53qyRj1ie1fbJDND9bwRwM++HQ01haRR5BoPmeK/sEXbhJCX9SVejwSUaqjEFXnNYy0BQ87RMcKgCGqxGCY2dAFzBtz/lZYWtaT36JmtjRXdUX2DGZn42OA0ZCD8fx7bxZ21WYQgm/bNOf6QzPG5s1ol7yBXyO/wYDfzJcBh/1zpijQAdPpaIfmW2CxS9Iufbfh/Vpzv7PTQgZLp744PU3we2LVMgFrazNV8laZJURkmQv7sZ5PJnD+iKJ6AehqRjmr1If70Glvu++wSpEc6bhyZarCCFfVZElNRIv/4prnXKUwqFOJsDPvuYwq70zr8cLZrMMsVZOjm5tZoGRbDSyzyCJ9VDjj6bm7zRGU5t+xo36Mw+e/V3qtkxIu87jixzfWWD5gKhwgDmAAlLnNhyxkq7QPmO3BNHq2IIZmj4vkODSIaiKY1t9MiTpoYVpBS3bpT+qsTOnDlifNNwWp9GNCvJX2XgiDxQA7yluK6eDLpwh4xTI4ErNKK4uCWL5V560Mi1BZ+WRrHbgke73bm259kJi+faitLcooiVTbjZypjcJ//fsY1G4AdvZTtza/SEo5RpXkqI3HJ6lpclF6KMLewMYjE+wQLqyd+LR2fXdliBgsI3+/XRl7OSuYbxWfMygSdDm9vQ3Y JCyBo4wh UWKfcrevRhedXAe8HsoizsBo5LIcSLhA8Tx7yVCfRuQoDzlRGztKehGWvrEJrKWpPNJyr0jgHJWufUkDDGuiEFLp6qzPecfsQCXpm89QUYcUARsAenhveQuajjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/3 09:52, David Rientjes wrote: > > I tested 1GB hugetlb on a smaller AMD host with the following: > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3301,7 +3301,7 @@ int alloc_bootmem_huge_page(struct hstate *h, int nid) > int __alloc_bootmem_huge_page(struct hstate *h, int nid) > { > struct huge_bootmem_page *m = NULL; /* initialize for clang */ > - int nr_nodes, node; > + int nr_nodes, node = nid; > > /* do node specific alloc */ > if (nid != NUMA_NO_NODE) { > Oh, if nid != NUMA_NO_NODE and memblock_alloc_try_nid_raw succeed, `node` must take the value of `nid`. Otherwise, list_add(&m->list, &huge_boot_pages[node]) will not be executed correctly. > After the build error is fixed, feel free to add: > > Tested-by: David Rientjes > Thanks! > to each patch. I think Andrew will probably take a build fix up as a > delta on top of patch 4 rather than sending a whole new series unless > there is other feedback that you receive.