From: David Hildenbrand <david@redhat.com>
To: Barry Song <21cnbao@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org
Cc: baolin.wang@linux.alibaba.com, chrisl@kernel.org,
hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com,
kasong@tencent.com, linux-kernel@vger.kernel.org,
mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com,
ryan.roberts@arm.com, senozhatsky@chromium.org,
shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com,
v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org,
ying.huang@intel.com, yosryahmed@google.com
Subject: Re: [PATCH 1/1] mm: swap: add nr argument in swapcache_prepare and swapcache_clear to support large folios
Date: Tue, 30 Jul 2024 09:42:10 +0200 [thread overview]
Message-ID: <f7524eeb-7e94-48aa-a3f6-543ba6a8a5b6@redhat.com> (raw)
In-Reply-To: <20240730071339.107447-2-21cnbao@gmail.com>
On 30.07.24 09:13, Barry Song wrote:
> From: Barry Song <v-songbaohua@oppo.com>
>
> Right now, swapcache_prepare() and swapcache_clear() supports one entry
> only, to support large folios, we need to handle multiple swap entries.
>
> To optimize stack usage, we iterate twice in __swap_duplicate(): the
> first time to verify that all entries are valid, and the second time
> to apply the modifications to the entries.
>
> Currently, we're using nr=1 for the existing users.
>
> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> Signed-off-by: Barry Song <v-songbaohua@oppo.com>
> ---
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-07-30 7:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 7:13 [PATCH 0/1] mm: swap: add nr argument in swapcache_prepare() and swapcache_clear() Barry Song
2024-07-30 7:13 ` [PATCH 1/1] mm: swap: add nr argument in swapcache_prepare and swapcache_clear to support large folios Barry Song
2024-07-30 7:42 ` David Hildenbrand [this message]
2024-07-30 8:15 ` Baolin Wang
2024-07-31 8:10 ` Huang, Ying
2024-07-31 8:20 ` Barry Song
2024-07-31 8:25 ` Huang, Ying
2024-07-31 10:23 ` Barry Song
2024-08-01 1:09 ` Huang, Ying
2024-08-01 2:07 ` Barry Song
2024-08-01 2:32 ` Huang, Ying
2024-08-01 2:42 ` Barry Song
2024-08-01 2:46 ` Huang, Ying
2024-08-01 9:20 ` Barry Song
2024-08-02 1:46 ` Huang, Ying
2024-08-02 2:09 ` Baolin Wang
2024-08-02 7:18 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7524eeb-7e94-48aa-a3f6-543ba6a8a5b6@redhat.com \
--to=david@redhat.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chrisl@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kaleshsingh@google.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=senozhatsky@chromium.org \
--cc=shakeel.butt@linux.dev \
--cc=shy828301@gmail.com \
--cc=surenb@google.com \
--cc=v-songbaohua@oppo.com \
--cc=willy@infradead.org \
--cc=xiang@kernel.org \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).