From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Muhammad Haris Awan <m.harisawan@icloud.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Kees Cook <kees@kernel.org>, Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] fork: mark memcpy() in dup_mm() with data_race()
Date: Tue, 17 Nov 2026 11:54:28 +0100 [thread overview]
Message-ID: <f75945f7-82bc-4ff2-92ac-9ec057347a41@kernel.org> (raw)
In-Reply-To: <179491109101.4015489.11185824873441987133@icloud.com>
On 11/17/26 11:24, Muhammad Haris Awan wrote:
> Hi David,
>
> Reclaim isn't touching the new mm being initialized (which isn't added to
> mm_list->fifo until lru_gen_add_mm() at the end of copy_process()).
Oh, that makes sense.
>
> The KCSAN read is on oldmm inside dup_mm()'s memcpy(mm, oldmm, sizeof(*mm)):
> oldmm is an already-live mm sitting on mm_list->fifo, so when an adjacent
> exiting mm calls lru_gen_del_mm(), list_del_init() updates
> oldmm->lru_gen.list.next/.prev under mm_list->lock.
> > Since oldmm is live, lru_gen_del_mm() has to update those list pointers.
> The alternatives in dup_mm() would be taking mm_list->lock (plus
> mmlist_lock) during fork, or avoiding copying oldmm->lru_gen / oldmm->mmlist
> (awkward because struct mm_struct uses __randomize_layout). Wrapping the
> memcpy() in data_race() avoids locking on fork and matches dup_vma() in
> mm/vma_init.c.
Yeah, the only concern I have is that this is the big hammer for any members,
not just the ones where we expect races.
We hold the mmap lock in write mode, so one would assume that nothing can rally
modify it. Well, besides these list exceptions.
Let's see what others have to say, but I guess this is fine then, although a bit
suboptimal.
--
Cheers,
David
prev parent reply other threads:[~2026-11-17 10:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 5:59 [PATCH] fork: mark memcpy() in dup_mm() with data_race() Muhammad Haris Awan
2026-11-17 8:59 ` David Hildenbrand (Arm)
2026-11-17 10:24 ` Muhammad Haris Awan
2026-11-17 10:54 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f75945f7-82bc-4ff2-92ac-9ec057347a41@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kees@kernel.org \
--cc=kprateek.nayak@amd.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=m.harisawan@icloud.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=vbabka@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox