From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A76C3DA4B for ; Fri, 12 Jul 2024 03:51:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75C0D6B009B; Thu, 11 Jul 2024 23:51:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E61F6B009C; Thu, 11 Jul 2024 23:51:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AC486B009E; Thu, 11 Jul 2024 23:51:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3C64A6B009B for ; Thu, 11 Jul 2024 23:51:30 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EF29AA012D for ; Fri, 12 Jul 2024 03:51:29 +0000 (UTC) X-FDA: 82329725898.19.C54E6C2 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 506A720005 for ; Fri, 12 Jul 2024 03:51:26 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=shhRitpu; spf=pass (imf03.hostedemail.com: domain of xiongwei.song@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=xiongwei.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720756252; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X5CHzDO2w0iaSpqQBiS4c4McEFhHtmC9DKCnYkfWSQs=; b=EbgmgIqtEQlKbY1eaoBcwGacm2Zr2p1SKA4ofIT6db1Sgb3mUrbc7P9BjsM25FKL0MNVoV /b4DQJWsfc8TzsKBxBZrxNn2XKe8SP6Rsb3yWIcuTF/lsvy2ffsq3WNC39TLED0Fo2zkqA T2RzG23E3Ymwwz0MyEKLwr6r3k4mpcc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720756252; a=rsa-sha256; cv=none; b=2DVX7oA++KdeM+dmcq/biWy28W2JW5yM8rQkGN60WStsYmZlo8y30SlyIXB6V65s9YwqNR ozos8Wmvgqy2RlkRj09tlrwtZiqjDUFHMVfTsO5r6SO0PgHjVW8DO98hycEiKVvjjQWJTe H+txJBYLneOK1UzGndFvfA4BYXwERfs= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=shhRitpu; spf=pass (imf03.hostedemail.com: domain of xiongwei.song@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=xiongwei.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: surenb@google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1720756283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X5CHzDO2w0iaSpqQBiS4c4McEFhHtmC9DKCnYkfWSQs=; b=shhRitpuf0ZalVIT4mcGfaEA0ILfBRatFoRHHZjMSySBxZQQ1mIUhlJoB9eZWBJu5NRpt5 ENscMyjdbTDTtKPiftP0K+AlMBNi/l37IJSnNZN26q/wr+ZdD0Ry8s8+GVPH5bfbWUWwW9 cHxTycOCTWjsKi1ALp6qTX93+e17y8A= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: vbabka@suse.cz X-Envelope-To: sxwjean@me.com X-Envelope-To: willy@infradead.org X-Envelope-To: nathan@kernel.org X-Envelope-To: cl@linux.com X-Envelope-To: penberg@kernel.org X-Envelope-To: rientjes@google.com X-Envelope-To: iamjoonsoo.kim@lge.com X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: 42.hyeyoo@gmail.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: lkp@intel.com MIME-Version: 1.0 Date: Fri, 12 Jul 2024 03:51:20 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: xiongwei.song@linux.dev Message-ID: TLS-Required: No Subject: Re: [PATCH 1/1] mm, slab: move prepare_slab_obj_exts_hook under CONFIG_MEM_ALLOC_PROFILING To: "Suren Baghdasaryan" , akpm@linux-foundation.org Cc: vbabka@suse.cz, sxwjean@me.com, willy@infradead.org, nathan@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Suren Baghdasaryan" , "kernel test robot" In-Reply-To: <20240711170216.1149695-1-surenb@google.com> References: <20240711170216.1149695-1-surenb@google.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: k8hx4axffw9sfh3exy16mqxb7mfwjm6b X-Rspamd-Queue-Id: 506A720005 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1720756286-653465 X-HE-Meta: U2FsdGVkX199p0jESi8DjT6pY0f7wxojsHL8mpYPL+EBiFO3l8ZuOYp1nPJU8Z6bvJ26y9T3wKlPUfTjuQVDaxxl3Wt9FWkh12LcwTgSMGFygPVSrgcxypVWC2s+g3wkFyRMukBNKF9eYZvUHDYd2mD62xEH2IbOMwGiBDmZBPM/+vk9pBKKgPaI6Fg8dh7PnPSAk50KuYqLdz+KAsP3dnw0z1JV8mkHoiSURbwsgFnTOi2nFau2Lxoi0i9rnuP+IXVqJ8uXunrmtJu6PPdqr5ONqARtZrVI92fcGgCrxsl7X+YAqnupr9pQ59DPx5icVy3QqPOyYEWlWh+nmULNiLir1x79RRCfnfDH/TP65YxbPFCr8NBk9WvPZn2on55aUvdDlAg5mWVe8rU5CtQQAj1eCggldKfCqx7slQiL6BMyp2a5yqOIp/x0kq9Nh5+imNsJux0h8KBsxJww0Qf5IGTe0Sxg8/Y4kmyDoA6iZ1vMG54KqULW1uYE6QKAmiMPRSgNrs+yBf0KcFlFyfGzY42h2F4IIMWR4aLe6xgXzD5F3oJaoStPEctBEkVwhAuVEP/ScEHRWq96pF0BLYwVK2Yhu2MhLn4QyXEmTGFrpgYiGJqZq6kI2XAxrQgY1jr2uUfAJYFrXXtVKTOZ9ErTjYJlwv99MYnHi2gSN8Yn5CDodulDrzVnRyiyYTJXJSMI2JJPAiBt0UNDmjCObtS9URlzX51PEVuaPfc4kGUIgQsPQ6QIVe5StLowQqEzy1s0PCI59kB2t9eOhtClrfsH8Oitpf4GWloMDIIaeNI8vAAmYp44LFYTflKDyvrFYeY2JndVTDLTfu+V/jHjY/ft/bPkEfMUjedud03zQYd0kGu3+taAi1/y+ciygF69dJjLSMTDgQrSVX0na1sP7QXwczpHg9fMZUp89+iXEf6H0lGX9VYn+izizTUYn2akGq3bjJ0QnKaj+84OgvvX9VE /8iTwwrz uA5pFR2nALjZQDjXT10UXTPaiA6501jcd+WwrrwA4yju6SgvuGeWJfBOh9REE4A3Va+Xyzq1/OPgXLnwEbggjJnNBqoYXmETEujfV71SsQGrjeQMnW2qDQJ6/Y+FgesZV556e8i06rKN2HO2S//2u3RXPKIeT8nM5kwmAkfiwN8oQnieTDjVZxa/XjixMqkZJyQiXtVe3gbbVuNT5iluodBp1JUHhi4H7dZ3TMPUczLNnnhZlj7or85rcVrOF6iE5d0w9aPycnR9W1CLJiXnHXQsuJaIZ7O0OAeOdl/bhRLTtfmhJHHAAnPuqFW5g6xwypegoxdtpRUQNt55cob0ILqEvVLRYhgPbNHZE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: July 12, 2024 at 1:02 AM, "Suren Baghdasaryan" wrote: >=20 >=20The only place prepare_slab_obj_exts_hook() is currently being used i= s >=20 >=20from alloc_tagging_slab_alloc_hook() when CONFIG_MEM_ALLOC_PROFILING= =3Dy. >=20 >=20Move its definition under CONFIG_MEM_ALLOC_PROFILING to prevent unuse= d >=20 >=20function warning for CONFIG_SLAB_OBJ_EXT=3Dn case. >=20 >=20Reported-by: kernel test robot >=20 >=20Closes: https://lore.kernel.org/oe-kbuild-all/202407050845.zNONqauD-l= kp@intel.com/ >=20 >=20Signed-off-by: Suren Baghdasaryan >=20 >=20Cc: Vlastimil Babka Reviewed-by: Xiongwei Song Thanks. >=20 >=20--- >=20 >=20Applied over slab/for-next because of the refactoring [1] in that bra= nch. >=20 >=20[1] 302a3ea38aec ("mm, slab: move allocation tagging code in the allo= c path into a hook") >=20 >=20 mm/slub.c | 48 +++++++++++++++++++++--------------------------- >=20 >=20 1 file changed, 21 insertions(+), 27 deletions(-) >=20 >=20diff --git a/mm/slub.c b/mm/slub.c >=20 >=20index ce39544acf7c..829a1f08e8a2 100644 >=20 >=20--- a/mm/slub.c >=20 >=20+++ b/mm/slub.c >=20 >=20@@ -2027,6 +2027,27 @@ static inline bool need_slab_obj_ext(void) >=20 >=20 return false; >=20 >=20 } >=20 >=20=20 >=20 > +#else /* CONFIG_SLAB_OBJ_EXT */ >=20 >=20+ >=20 >=20+static int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache = *s, >=20 >=20+ gfp_t gfp, bool new_slab) >=20 >=20+{ >=20 >=20+ return 0; >=20 >=20+} >=20 >=20+ >=20 >=20+static inline void free_slab_obj_exts(struct slab *slab) >=20 >=20+{ >=20 >=20+} >=20 >=20+ >=20 >=20+static inline bool need_slab_obj_ext(void) >=20 >=20+{ >=20 >=20+ return false; >=20 >=20+} >=20 >=20+ >=20 >=20+#endif /* CONFIG_SLAB_OBJ_EXT */ >=20 >=20+ >=20 >=20+#ifdef CONFIG_MEM_ALLOC_PROFILING >=20 >=20+ >=20 >=20 static inline struct slabobj_ext * >=20 >=20 prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *= p) >=20 >=20 { >=20 >=20@@ -2051,33 +2072,6 @@ prepare_slab_obj_exts_hook(struct kmem_cache *= s, gfp_t flags, void *p) >=20 >=20 return slab_obj_exts(slab) + obj_to_index(s, slab, p); >=20 >=20 } >=20 >=20=20 >=20 > -#else /* CONFIG_SLAB_OBJ_EXT */ >=20 >=20- >=20 >=20-static int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache = *s, >=20 >=20- gfp_t gfp, bool new_slab) >=20 >=20-{ >=20 >=20- return 0; >=20 >=20-} >=20 >=20- >=20 >=20-static inline void free_slab_obj_exts(struct slab *slab) >=20 >=20-{ >=20 >=20-} >=20 >=20- >=20 >=20-static inline bool need_slab_obj_ext(void) >=20 >=20-{ >=20 >=20- return false; >=20 >=20-} >=20 >=20- >=20 >=20-static inline struct slabobj_ext * >=20 >=20-prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *= p) >=20 >=20-{ >=20 >=20- return NULL; >=20 >=20-} >=20 >=20- >=20 > -#endif /* CONFIG_SLAB_OBJ_EXT */ >=20 >=20- >=20 >=20-#ifdef CONFIG_MEM_ALLOC_PROFILING >=20 >=20- >=20 >=20 static inline void >=20 >=20 alloc_tagging_slab_alloc_hook(struct kmem_cache *s, void *object, gf= p_t flags) >=20 >=20 { >=20 >=20base-commit: fe4e761669ab4d8b388fdb6e9dbe9a110eed8009 >=20 >=20--=20 >=20 > 2.45.2.993.g49e7a77208-goog >