From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD19FC83F1A for ; Fri, 11 Jul 2025 09:39:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B19C6B00A1; Fri, 11 Jul 2025 05:39:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 362966B00A2; Fri, 11 Jul 2025 05:39:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 229DC6B00A3; Fri, 11 Jul 2025 05:39:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0E0436B00A1 for ; Fri, 11 Jul 2025 05:39:11 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 13D20142F93 for ; Fri, 11 Jul 2025 09:39:10 +0000 (UTC) X-FDA: 83651485260.04.A54F195 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 7B71720009 for ; Fri, 11 Jul 2025 09:39:07 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CT7VU5KF; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752226747; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wQecZyWmWsgHDALYGnZ4BgAt7aKBzE7knExhR/Vkoxc=; b=FmkFayXpbLS26mYySDAMBZrV0TpUsW7DXHDlJRR3uW7vijHXKalGaODoL5xZavNMNy38a0 GEcAsd+XKa//edu6NxodL6d9MpGapmnwMiMPWNrgUw53IBk2PfnpWI8kkBoFAL0JRSAqQ/ 4RVaakRxtforQE2cOhBI/SvOHX3UScM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752226747; a=rsa-sha256; cv=none; b=71HjNtPOi7AUhNmIAfhPZ6tX/zNd03HxTZyGttt0Lk0otA3l+zwwDeg6baDFnmIhPuSjIY lLzXVV1VgGny6glMvFu/mHglANyCbcbgsPu6mBoM8/SD0w/J8ABNjcFe7EKjVMc9r6fW6q O2SZiQGPU4D/lhHP4N18iw4BJZ4EbxE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CT7VU5KF; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752226746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wQecZyWmWsgHDALYGnZ4BgAt7aKBzE7knExhR/Vkoxc=; b=CT7VU5KFMxkVYCdPdmm5lom+9jmJ69BWOEAKBhWo2/LxAeJlSWoQJaJMQhnwSlh9o2wsZa uohvALNaWjQ++REALwPrQ3gSDqfkBSJh9ODGNLKAY56WJ/EkHjkq9f22BjodzuKRfYv1dp Ulri6OEUGTvjBj22P6Sr6YxDdj0JoPs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-395-myFYGefsPEGID3iYLHYk5Q-1; Fri, 11 Jul 2025 05:39:02 -0400 X-MC-Unique: myFYGefsPEGID3iYLHYk5Q-1 X-Mimecast-MFC-AGG-ID: myFYGefsPEGID3iYLHYk5Q_1752226741 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-450d244bfabso15704025e9.0 for ; Fri, 11 Jul 2025 02:39:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752226741; x=1752831541; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wQecZyWmWsgHDALYGnZ4BgAt7aKBzE7knExhR/Vkoxc=; b=GIhPM/uFAoIwpv6NsZ44xFizQ50CrTBA9KXbjawEOew2PO99PlZNYm8b0POwC8jS0O z+zR2qT3m2n6E/wFHTxSteHg8GZ1+gbUovP7F+SBL3Ub4uDrgy94Vz+oKgZkv/mSp6up pYREemnl6Y9OPZBd1y5cDHyDgqxyVCBJj9o050d6paTeoujFD4XiHMU4V/IlV5V7KLom 7DQ0/egoHApoDtc4GLxosO0fzMuSJze5Gf9I92iR125urPByZilcdYtARFW2ohy13pTD vruG/LCJleRc35JUycHlhKPLhACwOo78woQ47awtSZ4gJ0WhAdCIdISVe9UZKsgjD/RU uLSg== X-Forwarded-Encrypted: i=1; AJvYcCW3eHNOrDZJBzmj1PpG+08H2nlHK3Mw3fInw/iy960iZobq7yN9/SMOy7UsIq2GXyrNqSX6I3P/hw==@kvack.org X-Gm-Message-State: AOJu0Yx9IkAScqzNy205490MRLdnoerVnj7pCvQ6jEh892pfXpB2lQu9 8PZLKAx/J0fLa0/YQgITSWaqKBJWqhY56TxeoOTIfSik3JYNr0jVJICGGKHEu32/f4rms0Jdkra kpusu3nwPgrXOlUO+Ywybtfnn79tMKomaAtgr19u1V1s1uDbZcvey X-Gm-Gg: ASbGnct6tGOIt0l/LIIFk9dmslN7iKxkd4HofFNuCjzbOB2P9/fkC44KPlaBrE9uZ4R T3Ri+E777M0RMdPpdfbSog9PZyGW7Rh8XFVFme/Bp5VwKoLPqKwNBkYPsvVYyEiYebbfxm2gqxh V/my+vBOiFPIBYWgFPNk8vHBZ2fAlq3teq5L2rVixlMhkniAdqL1uGKTadfOVZckeoK2fLnZymA f7/TubOszZ7XoAbH9HZmn3+AxJq5qKKrsKQla83nCaZcp6EMqnmWHNCV4dqIbt/wz8iwZgCoO29 A8FxkX2Ptr+TLshiaWYwy7IS0nugw92OGy2lJM5LdJYa0BQQB6mpXz4k435911XNhlRHbVRRe4J EJ6Fu/WKxTQsojgvQLGhq4fY08p3K0RbYNdGYJ9l9iuNmGIE4WvOOvGRwUjbXEFMZuR0= X-Received: by 2002:a05:600c:4ecf:b0:453:dda:a52e with SMTP id 5b1f17b1804b1-454ec27e3b9mr16495075e9.33.1752226741103; Fri, 11 Jul 2025 02:39:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExWIvCiETlaLEh+tomf4x2EEMzXLfA9UvWDVsAMK1xk9DaBUTK6aJcyWeSpLnlgw09g/FhNA== X-Received: by 2002:a05:600c:4ecf:b0:453:dda:a52e with SMTP id 5b1f17b1804b1-454ec27e3b9mr16494695e9.33.1752226740563; Fri, 11 Jul 2025 02:39:00 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454dd54115bsm42810775e9.31.2025.07.11.02.38.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jul 2025 02:39:00 -0700 (PDT) Message-ID: Date: Fri, 11 Jul 2025 11:38:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 11/20] KVM: x86/mmu: Allow NULL-able fault in kvm_max_private_mapping_level To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250709105946.4009897-1-tabba@google.com> <20250709105946.4009897-12-tabba@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250709105946.4009897-12-tabba@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: U7TwNxzbCgF3BuLpobdOfpopypK5R3XHCxUXQ7w1GPU_1752226741 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7B71720009 X-Stat-Signature: 3tgrqmo4cosphte3jcwxqxg5w3gbgp1m X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1752226747-221235 X-HE-Meta: U2FsdGVkX19D1qdrZVXHUkh4i5Py//gY50P7ur+ELQUhzJ/DQ1GPP57p4E8HmQRlGNsIglc9rWzVuNondHR8ttLQCNLBSntyxTC3fgocKkdf6D2QtuEdr/GdAc/7nbaVqUupiRWlsumU61rp4RifP/ZqNHmlg6+P6SZErfttE/Q/s5GFJYEDnFvUJCc31xxvlEHJy3ct/djqZwN+kTYf5W+YuSESZMOW9CHd3xYjJG6lxuobkRXTSYWQog3FBdVoA/xgE1wpLIqDDSzmqTZU7bv6ErVUvfrWO3JlhYoCF5ceeFJHCMAkIXLd22/AWRfSGZHaXkJ4sj+enB80TnUJNTPcSLKYq5KONhWgSmwJDStjkwxYJ1P7Rhx0xdjZ7S3y0p55Dr+AgTU9X9+SG7NUA6yf4zO8bmetLYea8yYwAf3MAfMxvTnlzHlPc8EglExcBLJa4wynVoTSqih7w9riMpvPtERh5PBY0z0bGztapGkcg3uutBs6Yw5MBM10LJKXyt+SqlbWHWImxHw0hv4aBtAbWNMZbmr/K5RJosi3Rpu/nZT7es6Gv9IlN5dwwXYxervOoP18ar2cBEyhzO+t1FIjkzwSYcNpSx/v/f56ZDLQKB6L+YnAlGdixgacnmHGWoBJYWBbI6Iw5yY081pPJXlzkV4/HrmAJ7jxA6gJAiCalQpF7k62iGYrwV4Oi3c7vdDjObqu75qStI0JaHL+bfu+9sMrWJ/L3fXF2dFB+eBBsLJb/FlUkDEeXlso+uhyqsD/BeMXmwcAZaAk0k/jGRX8KvLpEHZxXI8odHgcw6MBpUkgmVwWTVZiiRkXBj7MwymYBJbQwO3URjyjMVKbGD0unP76u8JFXaQqSJhCe/1iFXvlvWih1wZkTVLVofI9F2j4cY3ugc0kiX6hmt81HOLVDxRQANjyy41INhL3drKcBBLx4jzC2Oj/+L+Q6XuCU7SKupXaqcIacyZ0On9 QxB8q9wX shZS6Z025PCHtsuatvoOdDKj96PwtfwijVTHFqVPbo4TnmMxEgDZmYwf9qMnuQSXEDKYvUbrt4gimk/4PujMW388YZqvmMGPu3OkwXWNyDcic6Lli9AFwHjQzOxgB5ThQdjL3vMyEib5cgh01Tq11Fv4S5tRlSIxcwM0LJvYBuEsoFZ/LFh+yqTqXctS+eYGr8NssjhYuc81nfH7s+wocr8GYLzKylsUb+FrJjn9Btw08S90iDGDnVm+jdvVZIyDdgkVPAgUMLYdtitTsBiuOgxCypEIsodiXqa8RXT+37G4yL5skZhsHY+oO81v1K9AvJz0D04I7B2pgQDmWju1JdTkiswbhc4y4wEpEINjAHK928Pt38H3m41NqjGB95fnXsgZQTYx24JJxrHrBbc5zuWZ5JQV7jqAcHYLNXH1/lFRrN+Mj97iA0WPZ1J46KlloMaFVs85NqVUlBFZd02SUM1NiThNulXoI3CTJGusTj2blShp+M4LmQ0fi0oVovirgqt1SbY5lyfFgoAwgh3XY5znBvGtsTtROH3kXUfdPsdu2KxlKdplUodx4pFmPJtVLV2FsjaWPFinXX2gWbqk6bDDo6w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.07.25 12:59, Fuad Tabba wrote: > From: Ackerley Tng > > Refactor kvm_max_private_mapping_level() to accept a NULL kvm_page_fault > pointer and rename it to kvm_gmem_max_mapping_level(). > > The max_mapping_level x86 operation (previously private_max_mapping_level) > is designed to potentially be called without an active page fault, for > instance, when kvm_mmu_max_mapping_level() is determining the maximum > mapping level for a gfn proactively. > > Allow NULL fault pointer: Modify kvm_max_private_mapping_level() to > safely handle a NULL fault argument. This aligns its interface with the > kvm_x86_ops.max_mapping_level operation it wraps, which can also be > called with NULL. > > Rename function to kvm_gmem_max_mapping_level(): This reinforces that > the function's scope is for guest_memfd-backed memory, which can be > either private or non-private, removing any remaining "private" > connotation from its name. > > Optimize max_level checks: Introduce a check in the caller to skip > querying for max_mapping_level if the current max_level is already > PG_LEVEL_4K, as no further reduction is possible. > > Suggested-by: Sean Christoperson > Signed-off-by: Ackerley Tng > Signed-off-by: Fuad Tabba > --- > arch/x86/kvm/mmu/mmu.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > index bb925994cbc5..495dcedaeafa 100644 > --- a/arch/x86/kvm/mmu/mmu.c > +++ b/arch/x86/kvm/mmu/mmu.c > @@ -4467,17 +4467,13 @@ static inline u8 kvm_max_level_for_order(int order) > return PG_LEVEL_4K; > } > > -static u8 kvm_max_private_mapping_level(struct kvm *kvm, > - struct kvm_page_fault *fault, > - int gmem_order) > +static u8 kvm_gmem_max_mapping_level(struct kvm *kvm, int order, > + struct kvm_page_fault *fault) > { > - u8 max_level = fault->max_level; > u8 req_max_level; > + u8 max_level; > > - if (max_level == PG_LEVEL_4K) > - return PG_LEVEL_4K; > - > - max_level = min(kvm_max_level_for_order(gmem_order), max_level); > + max_level = kvm_max_level_for_order(order); > if (max_level == PG_LEVEL_4K) > return PG_LEVEL_4K; > > @@ -4513,7 +4509,10 @@ static int kvm_mmu_faultin_pfn_private(struct kvm_vcpu *vcpu, > } > > fault->map_writable = !(fault->slot->flags & KVM_MEM_READONLY); > - fault->max_level = kvm_max_private_mapping_level(vcpu->kvm, fault, max_order); > + if (fault->max_level >= PG_LEVEL_4K) { > + fault->max_level = kvm_gmem_max_mapping_level(vcpu->kvm, > + max_order, fault); > + } Could drop {} Acked-by: David Hildenbrand -- Cheers, David / dhildenb