From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA60C4829E for ; Thu, 15 Feb 2024 16:52:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3CBE8D000E; Thu, 15 Feb 2024 11:52:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BEE048D0001; Thu, 15 Feb 2024 11:52:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8D468D000E; Thu, 15 Feb 2024 11:52:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9A67C8D0001 for ; Thu, 15 Feb 2024 11:52:30 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 440F4160206 for ; Thu, 15 Feb 2024 16:52:30 +0000 (UTC) X-FDA: 81794631660.24.3F63CFB Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf16.hostedemail.com (Postfix) with ESMTP id D783018000E for ; Thu, 15 Feb 2024 16:52:26 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="x8AaE/PO"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XRxyCuYe; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HDp2IEKY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pC0Ba+7t; dmarc=none; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708015947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ciAK3UmOQFXUXmlelpdBbf3qEyQO9Ipdb1FXEM6L3d0=; b=j86IoAblGZecSwO/zpT3CrnsyJ/7yKn7NJeK05shte0954M6IQgbJsJ2ZqRTfNkw0HNaxw ksu0hBMokH7kLkN0rTyPXl2EB5N03MCJMvJLS/sLxr6rbd9N4eO418ve6ObRHdaEl//zHO LUCHanmFgfFU0RHNLdP1ELGPrlI4Cz0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="x8AaE/PO"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XRxyCuYe; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HDp2IEKY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pC0Ba+7t; dmarc=none; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708015947; a=rsa-sha256; cv=none; b=yeUZIpfpSKHbu/302dC9Hx+kM638EXfsbbrV+uu3AJkFD1A4QOdIx5Tfdg2B/3+MHYJ4g8 fE+0FNSiIVpmJr7aKZD6w5R/AUNaA/To3e9PDprAuwvhepiSCg0zmiOGF3eXj9XUOQYP+x 3aqEwAvedn9SpuM/qrDI2p6fbR3iaHI= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E56E01F8C8; Thu, 15 Feb 2024 16:52:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708015945; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ciAK3UmOQFXUXmlelpdBbf3qEyQO9Ipdb1FXEM6L3d0=; b=x8AaE/PORJVyrTlOprVAqTjjDJiUubSBa5tOUR7SCM2njmQ+EcGzu2xYOhN1uRli6Gejci wWvBEW43DYD+aAowQ8SbdGwfmT1oD1a3jZn4Ol9+C/eufQFZKFqZxRn+SLXpzVGl6OHoD+ AO7GjdeXm/Tq0FMS63iNbVqlCQjrRfg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708015945; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ciAK3UmOQFXUXmlelpdBbf3qEyQO9Ipdb1FXEM6L3d0=; b=XRxyCuYeRVThXkyrn6tVlQlY7IxhEivS38D9UH2LOxUNbAuP/oIL5zTq53Bg/uzAf/9m4q A5TbgkjQ3Pd/a1Bg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708015944; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ciAK3UmOQFXUXmlelpdBbf3qEyQO9Ipdb1FXEM6L3d0=; b=HDp2IEKYp5ziILDa1S7p964GU4PqGkWSCrinwGRifRNcEyhgZf+nWdKs453iqH1Z/Z7VxF HvV32Wj4l1+JRpX0tLmW53sZIWWAKLAvOnP8Y6bW/q27tR1G6xwM2LTT3Pg9HHsfoWNmcw K5yhUohvHnSf7Q4qSypmBuu7oOQlyyQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708015944; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ciAK3UmOQFXUXmlelpdBbf3qEyQO9Ipdb1FXEM6L3d0=; b=pC0Ba+7tkq7tljGcQXKb8aDqY3Vwi653EDo9pHaR2IYvFWGqHuIMDGIoTqIrFVBFlQFn3n Xqtw40TxOeEfQODA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B245C13A53; Thu, 15 Feb 2024 16:52:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HsooK0hBzmW3CwAAD6G6ig (envelope-from ); Thu, 15 Feb 2024 16:52:24 +0000 Message-ID: Date: Thu, 15 Feb 2024 17:52:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/3] mm/compaction: optimize >0 order folio compaction with free page split. Content-Language: en-US To: Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" References: <20240214220420.1229173-1-zi.yan@sent.com> <20240214220420.1229173-4-zi.yan@sent.com> From: Vlastimil Babka In-Reply-To: <20240214220420.1229173-4-zi.yan@sent.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Bar: / X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D783018000E X-Stat-Signature: 8cfzeaced6bprd4ozuoqatxqqioxzn58 X-HE-Tag: 1708015946-447770 X-HE-Meta: U2FsdGVkX19W8fWYPqlMfvkzf8ySC+sPfhbkoAIoj6+BIIHzHa7PCIA0+6DVt2O6MT62p5VKycUwWPyUKuSI7wiUziVVjkqE0sVcPSgyXL0iabYr29w//xUFgLsWLbOBJCkTbg15iok9O+HqYteS4Dnx0QJPI5J7+Y+771/ZwmqeHC8uSgPcd/Qeb7ZDXTbKUf4pjE7DCZWvei5bpDBQa0JCxHj07Qy4poEpF/1T4DkK0C8ZJEgCW66IeXpGE8CHavsNn5GIhLnDtFrReZHwSOi6PH1yj828vVOSgq8cd+LhekLdqcWvlLBDgKB9QGqnxg6p7VsAHwJu2c15FCFQzmy3oR1Sce2t095PvV0l1pK8u8Hyv1J1pvMgjlQhfIrb5/qdEshqHIDX+kyxNzjkSKdS2v1KVTjh3ZeGyvNpV0jMxHc++b6sCCVJPrXfdyA4Wv7ansafJfs/2STxh8AvTGA7iNvV1HLdS/sy7yEMxWB2gqpYGIHZOUtzdAY6ccuswZUuFtul1B2gOf8gHIDqMdCj6NXSSJg5b7NucWIGU3r4rRiphhR8fWtbeSigD2n0x8ni6XoKRSbYHXriUn29OQmSHeJnR4qjpacLRpJhepCsSJVutZcWTa9oUeJGbpttHjxzbLoaaflRigM4yJgeo108SnSEu8rzvQlVJXWmTyCZr+CLpXDE9zRW6lVr61J1B/cOJfXHDnba6bJxHbDpsDZ5QieRfVS22j46fr0QHXN4hvScdlDzowyb/uEkaJgQ9l/chWghfh2B3i1iold0WUz0x95FErnyukGIkDgBKAPnuoANEMbEySR4lZyTLViZS3xWHZ1bka3rFrXUXmUwV2wQ1a3AJcwpHlXx732Vp+NQYck68eIHOE/vDiMo7VouGM2/sqfM8MWoNlGKZwjHyL2cspK/7BxXJo+GfKY5te8IjB0qbpfgx9mye5kuTCp2RUx70k0f8akBHJ13s9J iULGMgwd /pDBTYLL4m9tbbtvyab5QERaac30epbJaV3rlvD48Xh/t457kCilk3Ou/8Y7rVWO4SkYi999+1gArWP6sjJhUPCfPM/v6YgzfKC1peegPNpiVfR8DboHRPW3+iTW9OZPrJ1A2AJniKHKmiiYaT7FoPXJwi9tOBXJ0Cs6pzCuOClbPGTJM0p/7vXcBpidTvMjEQkGeyhlX3XfMYnvW2XnQ9MHG+BYXHDNfuYj1sOq7wXoP2PZ56b0QXcI9f8wG1domQJVKpIRF3ZvOyWYXxfQXjU4n8VuWs6eFVSIRYNKgs6uLmG3twt0REm+sE+B2+/OXvQOQthYQ6Ytqu+r442JdE8feyiKc4oHMoCzyXF+YPHnY3oTOXekXu6Vk3aiT3iDEsUXHNO9SqG4ScxQ8O7xjpbk99A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/14/24 23:04, Zi Yan wrote: > From: Zi Yan > > During migration in a memory compaction, free pages are placed in an array > of page lists based on their order. But the desired free page order > (i.e., the order of a source page) might not be always present, thus > leading to migration failures and premature compaction termination. Split > a high order free pages when source migration page has a lower order to > increase migration successful rate. > > Note: merging free pages when a migration fails and a lower order free > page is returned via compaction_free() is possible, but there is too much > work. Since the free pages are not buddy pages, it is hard to identify > these free pages using existing PFN-based page merging algorithm. > > Signed-off-by: Zi Yan > Reviewed-by: Baolin Wang > Tested-by: Baolin Wang > Tested-by: Yu Zhao Reviewed-by: Vlastimil Babka Thanks!