From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF252C5475B for ; Fri, 1 Mar 2024 11:25:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76E656B007B; Fri, 1 Mar 2024 06:25:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 71F116B007D; Fri, 1 Mar 2024 06:25:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C08D6B007E; Fri, 1 Mar 2024 06:25:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4E3F76B007B for ; Fri, 1 Mar 2024 06:25:00 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9B9EDC13F2 for ; Fri, 1 Mar 2024 11:24:59 +0000 (UTC) X-FDA: 81848238318.21.1A58B67 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 638031C0013 for ; Fri, 1 Mar 2024 11:24:57 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OjHOUsTm; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709292297; a=rsa-sha256; cv=none; b=dEQwH5wWT/7WTUyPUpTELeKqOlHlh5r+8PLzn2ltDHfbzA+BY9JFXRJrpmbMYJMQZGwTFP ITPTjzzJSOMstzFm4mWuGTuISRWUoTttgpxwrnISuw8xy5+xOOVkYt6fXI0SuFfZME/cK3 Ks1a0g0QU2TcO1GuUo/XE3vnKtgqhFI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OjHOUsTm; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709292297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4OqJXN5BcxJObIJTy2Hs3KGlEQswVlVswjdrC4N2CCs=; b=2uUVlD0pyP588xd8KhNcv9JvL9hr84h8pXFppcVBqFrL2zUiENyqTeMw0cRMuI65CCrfx0 lW9VVYRV3eLziODgP+lM4rg1jRC8D9CHSHOv3LXazQlE5HhfFD9+z5IygFhO8/PI114/xp JviQSGed2NCtjeSE+4nDF30gGQA9IL8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709292296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4OqJXN5BcxJObIJTy2Hs3KGlEQswVlVswjdrC4N2CCs=; b=OjHOUsTmYaRoQb6PLgTDG717vllLwDr15NLgC71xXqwnKF+NZN9V9IYEspkbHbeg8KCjJG VHRI2sly942ZFO0Y5+xXigcefxQ/PB1LmJ2pHF/4J+fMIJhJF//u7Cz6jfdRX9joLbRaPt I1ReLUBANDyxo3y1YVI67ul+EFZnb3E= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-jqvX8iOYNaOxpdCg6wTQwA-1; Fri, 01 Mar 2024 06:24:55 -0500 X-MC-Unique: jqvX8iOYNaOxpdCg6wTQwA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-51314c5a05aso1309230e87.2 for ; Fri, 01 Mar 2024 03:24:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709292294; x=1709897094; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4OqJXN5BcxJObIJTy2Hs3KGlEQswVlVswjdrC4N2CCs=; b=mqnkQJ7hQP7qRUIUGpHo8JOA+JcEDuiUlnmEOYcXHNYRYlBIk7vJ8dCDh5r/Le0Vrq tcJI/cxOp4QviJYVQYzNJlyWLcV3T/eUqpG/1zjJs6HYBRRZZZ5UpJaAqCOtR42gbUtW GVgnYZqJi0KrSJ+UbZVKNX//0ngRDHMVPUBp/qezhbpMMUJdo1DOQgf9GcQgHvCq1J8J PEmkfKGYxKw8P4bg6wrPIGlG94nIcHQlabbhzQofjompcijUrJCWcSx7vOAgf24jg/h1 aO2PIHeHeBlUOkjaZD4k3l8AvSOnfPpZUestbnDSb7gjJzN0S08l+c9fcay7Qv7Hj1r/ fvcw== X-Gm-Message-State: AOJu0Yx6SqQk83sE/QCAVrQ+FFaa5SqZWUrU1PBgQmiinOOvj0bkreqh rg+HqrARAOa1uvd/gVQkKO2O1vOvQ1wKm4FjHh25i00NcYgvqD4Ymnsx0Bhx7qtDQ9Jl/Ho39XF so+Qw4RZvGhX17JqGrcM/DpsJ6QJaxKucvy75zWVY1yGQlh3q X-Received: by 2002:a05:6512:402:b0:513:17bf:87d5 with SMTP id u2-20020a056512040200b0051317bf87d5mr944200lfk.63.1709292293777; Fri, 01 Mar 2024 03:24:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1GmfVIOcWl3DhuMeeddrqrJoK+8BxO/Zo0doBuXZc2VNpbgP7w3CeJf8zwl0T620gqrI9PA== X-Received: by 2002:a05:6512:402:b0:513:17bf:87d5 with SMTP id u2-20020a056512040200b0051317bf87d5mr944182lfk.63.1709292293234; Fri, 01 Mar 2024 03:24:53 -0800 (PST) Received: from ?IPV6:2003:cb:c713:3200:77d:8652:169f:b5f7? (p200300cbc7133200077d8652169fb5f7.dip0.t-ipconnect.de. [2003:cb:c713:3200:77d:8652:169f:b5f7]) by smtp.gmail.com with ESMTPSA id bx5-20020a5d5b05000000b0033e103eaf5bsm4120422wrb.115.2024.03.01.03.24.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Mar 2024 03:24:52 -0800 (PST) Message-ID: Date: Fri, 1 Mar 2024 12:24:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/8] mm: Remove PageWaiters, PageSetWaiters and PageClearWaiters To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20240227192337.757313-1-willy@infradead.org> <20240227192337.757313-3-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240227192337.757313-3-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 638031C0013 X-Stat-Signature: 8k5wy1fe38598upbb191foot3w1pdyte X-Rspam-User: X-HE-Tag: 1709292297-293310 X-HE-Meta: U2FsdGVkX1/gJ2YSxAZD6deQCwRlbuLDgHAEuf6UF+Xfg83PXv2C3UDiIcOBdcfxBKy2t5HXYD4HJpyOVuMx5pO4ytyAzkzrlSOFgffnRRtNdY6T9TD4g+Ndfd7+tm6wmiO5kV6vM2/xz3IBZzP1nwYoNiEczOrmrgGNyhX5Dcgf5KhxTh7JbmlBQpxa+yvSUom9Ou1xvHRSfYwIYBpjrGXGdLmUN/8pfhuAun1Ah6dhj3EhAMJWkSNR+5bRDBteenTIKwJ8Wdu0t2yDPGAETncuf+mTwPRflX9/OSi8DQYo7o6W8QrNYqt47xRbG143yl5XBZxnyI4B3yk6zvWEJCVui/OHoDYR9rWksbSRIJK0vp8Ubqqa7/FV6jRP+Gzhno7VlZ42cAkuMTEOocaERd0+XimTAhH3kdRpiav+pd6FTCrIoIoc5/2jZ2ylna5R/sBYYW5F2mPdZi/Loq7xOODk5VbXPSgskBj8VfsRwUt+Y8m4BhmaYTTo2qMi1o179dT3MKh8+wi3/Wvr/lr9IF3iH4M7ekf1uroPE3I+G8XlZPO8xOnX0gai587LYg926tPnE+JU0msaZQsyHlGT2nJ53y4COFplB5dKxpjzuwXHOLW4oLpOcJ3vXloE5hjGr319ARfFwNo6fh8QHs4xAINAenpAV9i688ihXBNs8Xkz/3IR7BsXWeJOb8x3lXGYvRDhLy/ZTwUjfozwIpbh6kzV/BD++Cog00PjKYD24kzGiLm00HJciDZL46iZzCNkBZRK1zsDaGNSFxcglooq7YahXEzE44d0VOt8GhnpdyVM5uycYcrFNk1WqyVAiiG33Q+sjpUzKAkfN0NMuqQluvNKgGGX//k23b7z2cg/rTKivZeTeDTCYJrkYMk0aDCKsSomGBRLXW8ZvcsIt6mhtKuxkaj0zqkJuCEX3aUWR4+5hLt8bF4zNIHh0a1r2AmL2z8WfmB9ftzP5n0myRb 1jjoVLCj jc5Fj2N/Jajil8awHHe6XTSZPpDAQtuvNmi4eJIRrIBRZg05ej4D5i8cb/9wisWb4ngmXSHiJV6ZvWnEitJLI8G6cs6ugk5pOafc0jlKzRAlMnwg7Qyy5POkjFhpOYIaXoSTPvRVFqXm78cmjqg2lBmuxg4eSboHqUgSuAUodaJmwnqZKBQ3GgfZ3esZMnzcMWdm0RhVKbkg0QhXcaq/QloTyN4c0ZDJbjIr9D1TN3pd0Hj1HWDFxYl8uJD42J34uWMEfXr+Ef9ZXD7aGqygEG/B3xFYZoP1WXcaK5sYJWPMouwc2Tos7SqsRJxTyWe8f76mDvopNI102VUCJU/f9vZhTCprnJ0q3O6eW3tVtxC77UXZMkAxGsrgAv76HVm+o5Ocwv3hJuOqmXOkWPMdqZpWexLslAr2DbYciCkkKzEh0rtY5QNZMm81UzinohHQdbEV2ZUHamPHg/EYyVn3f5sXzrgSS3s9m84OdcWJknZVvAHoUV2WA+IKpMQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.02.24 20:23, Matthew Wilcox (Oracle) wrote: > All callers have been converted to use folios. This was the only user > of PF_ONLY_HEAD, so remove that too. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/page-flags.h | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 95ab75d0b39c..d8f5127ae72e 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -328,9 +328,6 @@ static unsigned long *folio_flags(struct folio *folio, unsigned n) > * for compound page all operations related to the page flag applied to > * head page. > * > - * PF_ONLY_HEAD: > - * for compound page, callers only ever operate on the head page. > - * > * PF_NO_TAIL: > * modifications of the page flag must be done on small or head pages, > * checks can be done on tail pages too. > @@ -346,9 +343,6 @@ static unsigned long *folio_flags(struct folio *folio, unsigned n) > page; }) > #define PF_ANY(page, enforce) PF_POISONED_CHECK(page) > #define PF_HEAD(page, enforce) PF_POISONED_CHECK(compound_head(page)) > -#define PF_ONLY_HEAD(page, enforce) ({ \ > - VM_BUG_ON_PGFLAGS(PageTail(page), page); \ > - PF_POISONED_CHECK(page); }) > #define PF_NO_TAIL(page, enforce) ({ \ > VM_BUG_ON_PGFLAGS(enforce && PageTail(page), page); \ > PF_POISONED_CHECK(compound_head(page)); }) > @@ -362,7 +356,6 @@ static unsigned long *folio_flags(struct folio *folio, unsigned n) > /* Which page is the flag stored in */ > #define FOLIO_PF_ANY 0 > #define FOLIO_PF_HEAD 0 > -#define FOLIO_PF_ONLY_HEAD 0 > #define FOLIO_PF_NO_TAIL 0 > #define FOLIO_PF_NO_COMPOUND 0 > #define FOLIO_PF_SECOND 1 > @@ -488,7 +481,7 @@ static inline int TestClearPage##uname(struct page *page) { return 0; } > TESTSETFLAG_FALSE(uname, lname) TESTCLEARFLAG_FALSE(uname, lname) > > __PAGEFLAG(Locked, locked, PF_NO_TAIL) > -PAGEFLAG(Waiters, waiters, PF_ONLY_HEAD) > +FOLIO_FLAG(waiters, FOLIO_HEAD_PAGE) > PAGEFLAG(Error, error, PF_NO_TAIL) TESTCLEARFLAG(Error, error, PF_NO_TAIL) > PAGEFLAG(Referenced, referenced, PF_HEAD) > TESTCLEARFLAG(Referenced, referenced, PF_HEAD) > @@ -1138,7 +1131,6 @@ static inline bool folio_has_private(struct folio *folio) > > #undef PF_ANY > #undef PF_HEAD > -#undef PF_ONLY_HEAD > #undef PF_NO_TAIL > #undef PF_NO_COMPOUND > #undef PF_SECOND Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb