From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4C65C433B4 for ; Thu, 13 May 2021 15:13:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3EB136143C for ; Thu, 13 May 2021 15:13:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EB136143C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 99FF46B0070; Thu, 13 May 2021 11:13:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 950A46B0071; Thu, 13 May 2021 11:13:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83F5C6B0072; Thu, 13 May 2021 11:13:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 532096B0070 for ; Thu, 13 May 2021 11:13:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E5319BBDE for ; Thu, 13 May 2021 15:13:25 +0000 (UTC) X-FDA: 78136551570.19.16C8F84 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf08.hostedemail.com (Postfix) with ESMTP id 64CA68019382 for ; Thu, 13 May 2021 15:13:23 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 50F95610A7; Thu, 13 May 2021 15:13:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620918802; bh=41qb467358PVWANG8SIzcwNL37SGfMDJteXHTiVFBmk=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Qx2rlVZSXYR2TxqHlZxJ1qDYqorMs4V3rrBSNXmrDaFr5uI2z94F7FU+eielXHQ6w 2qVIDsLxAF96kf3b4BGAB48Nbtg0iPtdpMEemoAitO+/0QNgy1DqDkFsldKm2iFG34 +aGB6I+7cJL3h/SyZxWRbhI8FV4FwxZEEkAQTWEi8d9fSYWV9qxXuKce3QsXLcxvUP lBV8m6hEDtLxxc5bQ7/tgghDpTOj9AAuS3EZHS1bAJo29OIZBY9Kwi7BYJQop8iqGL fjMc+CK+tp7BY+ZZXOfaCc1pPRse2na0vsFEWjbQvB4PbRz5/bLXYsCspK9njJAwts 5R80Xhp0QuCUg== Message-ID: Subject: Re: [PATCH] netfs: Pass flags through to grab_cache_page_write_begin() From: Jeff Layton To: David Howells , willy@infradead.org Cc: linux-mm@kvack.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Date: Thu, 13 May 2021 11:13:20 -0400 In-Reply-To: <162090295383.3165945.13595101698295243662.stgit@warthog.procyon.org.uk> References: <162090295383.3165945.13595101698295243662.stgit@warthog.procyon.org.uk> Content-Type: text/plain; charset="ISO-8859-15" User-Agent: Evolution 3.40.1 (3.40.1-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Qx2rlVZS; spf=pass (imf08.hostedemail.com: domain of jlayton@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 64CA68019382 X-Stat-Signature: konja9thunuw9duj9n3cq137a8c478qo X-HE-Tag: 1620918803-504156 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2021-05-13 at 11:49 +0100, David Howells wrote: > In netfs_write_begin(), pass the AOP flags through to > grab_cache_page_write_begin() so that a request to use GFP_NOFS is honoured. > > Fixes: e1b1240c1ff5 ("netfs: Add write_begin helper") > Reported-by: Matthew Wilcox (Oracle) > Signed-off-by: David Howells > cc: linux-mm@kvack.org > cc: linux-cachefs@redhat.com > cc: linux-afs@lists.infradead.org > cc: linux-nfs@vger.kernel.org > cc: linux-cifs@vger.kernel.org > cc: ceph-devel@vger.kernel.org > cc: v9fs-developer@lists.sourceforge.net > cc: linux-fsdevel@vger.kernel.org > --- > > fs/netfs/read_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/netfs/read_helper.c b/fs/netfs/read_helper.c > index 193841d03de0..725614625ed4 100644 > --- a/fs/netfs/read_helper.c > +++ b/fs/netfs/read_helper.c > @@ -1068,7 +1068,7 @@ int netfs_write_begin(struct file *file, struct address_space *mapping, > DEFINE_READAHEAD(ractl, file, NULL, mapping, index); > > retry: > - page = grab_cache_page_write_begin(mapping, index, 0); > + page = grab_cache_page_write_begin(mapping, index, flags); > if (!page) > return -ENOMEM; > > > Reviewed-by: Jeff Layton