From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F41CC2BD09 for ; Sat, 13 Jul 2024 01:23:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F7C26B0099; Fri, 12 Jul 2024 21:23:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A8BC6B009A; Fri, 12 Jul 2024 21:23:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 021E86B009B; Fri, 12 Jul 2024 21:23:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D8AD66B0099 for ; Fri, 12 Jul 2024 21:23:07 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8989E1C205F for ; Sat, 13 Jul 2024 01:23:07 +0000 (UTC) X-FDA: 82332980814.18.9BA9A81 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 42966180015 for ; Sat, 13 Jul 2024 01:23:05 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XxdtvK7T; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720833767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=96qXy98er4ppY2GDT/VfSRmz3R2UiUM94nu/XmfrfVU=; b=hZgiN4a31p/AGnPn0sYI1C2SDFec5wZtgWWjl+I1SWzbm8NaBRzuDGL3lhwi0uWymAFZAe 3qfL5cTP+152dFeTuMXa74vK5yIWzHibimAR5pxckgK12MZcbkw7E7VxMfLxyJQlXsMIbE pGwErYjGEC7y7KfkMUzyHCQnaiGezkw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XxdtvK7T; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720833767; a=rsa-sha256; cv=none; b=bgUOy6M7731MWncT/C4MSFPl85YaAucjJwP8mPyJ6N92QOEgtoVUa2fw1Md2qqkmi+5jbj KoipH8k0RzcIMHmNhuVv89OqtQTTJvmGbLAKh3/XcITfCHfp4vd+Qtd0FI2y6YoXakCaCS VxYbN64MgrJRSd3m4fyux34HEC6mYXo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720833784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=96qXy98er4ppY2GDT/VfSRmz3R2UiUM94nu/XmfrfVU=; b=XxdtvK7TAxU4RNb4fnWHiLtJZonbj6AeSJG1SSRXaVfB8FN0U2F+b5AO4oTtZXUV6O1snx /GkpuzGct9oiURU2CFZu72HEaB3O+KEBlUbTlgThF9WWdkQQ79veX1KYi/0StR4ICKupb5 DC1Mf1slzW4BXGDOD0NvvhESqSeJhus= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-574-QZ-CRoLeOhu0Y0ns2hOt3A-1; Fri, 12 Jul 2024 21:23:03 -0400 X-MC-Unique: QZ-CRoLeOhu0Y0ns2hOt3A-1 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-70ac9630e3aso1822641a12.1 for ; Fri, 12 Jul 2024 18:23:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720833782; x=1721438582; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=96qXy98er4ppY2GDT/VfSRmz3R2UiUM94nu/XmfrfVU=; b=wCi1PQ/jXImpw+qDYRsA1cb2BwmfffDjhsNOu7i/jtIl3avpM6dLiv8SYVv3/XMwYa IR4yIYN9c02KOQ6KdVJmgAVnDD97CxzcBp0ElLMRIA8f9LxLC6Gez6xGILaiSB1BaoI1 Xzaiv2k/tpcwEmHAAjn7lTl90F4VnM3aQxFshpsaSx8FAXfzq3ilX/a3Q5xwSyHTvFDs uFh4YdqXEFPRyTAP4EfjF6gZw0EfvO6JILTE+ydpoapZ7zq1xTfyDt+bYm0ifMouoeeS pXEN/6NNSb/XaFkIvm76dN+VkTXqhzNLNvaEMnmmM0tZrO3Em223JMQ1MoGQBkg8t7z5 2ugw== X-Forwarded-Encrypted: i=1; AJvYcCWZP9x6z9TV8slJSmjmfIHWsUYzzdzilqKj+u0wrMbXHfmSs/o87D8tUbqUrJTWHYtwbdumYbsM8aRTYA9CIckBxJw= X-Gm-Message-State: AOJu0YxrqY+aAlF8eemhOIP2t6JxqMcle53WzRxpLgC6+DJX9GU8pQXc abASNm6h2bkPulx1DyyTlVkW+lJXREv6d8WotbPw8amU9FuxZ04C4EA03rlWpqzNOYSXi7pgqMt A4pbRKainsmB+TPRSJXh5q/VRoo0u4jfxuwnZphI6hb5Pix8XxxQvD+ISNi0= X-Received: by 2002:a05:6a20:914f:b0:1c0:7ec3:c7ae with SMTP id adf61e73a8af0-1c2984cd9f7mr14916651637.47.1720833781934; Fri, 12 Jul 2024 18:23:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHjdAWavbNKN9EKbB6EMLRBt3ZcXJi9vcmdlFv0oLH8OXnjxQNc+ZObxqtfDZ4jkgfBG7Jd4w== X-Received: by 2002:a05:6a20:914f:b0:1c0:7ec3:c7ae with SMTP id adf61e73a8af0-1c2984cd9f7mr14916641637.47.1720833781524; Fri, 12 Jul 2024 18:23:01 -0700 (PDT) Received: from [172.20.2.228] ([4.28.11.157]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fc0bc5e904sm612325ad.304.2024.07.12.18.23.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jul 2024 18:23:01 -0700 (PDT) Message-ID: Date: Sat, 13 Jul 2024 03:23:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/3] memory tiering: read last_cpupid correctly in do_huge_pmd_numa_page() To: Zi Yan Cc: "Huang, Ying" , linux-mm@kvack.org, Andrew Morton , Baolin Wang , linux-kernel@vger.kernel.org References: <20240712024455.163543-1-zi.yan@sent.com> <20240712024455.163543-2-zi.yan@sent.com> <65FBE843-2FEA-400B-9FFA-150E038F7BDA@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <65FBE843-2FEA-400B-9FFA-150E038F7BDA@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 42966180015 X-Stat-Signature: u5goorbij94xiuqsxidtbt3e8c549j9k X-Rspam-User: X-HE-Tag: 1720833785-672148 X-HE-Meta: U2FsdGVkX1+BENawSMsgMSIl/AKQelDu8l5EGV2/fjaqMTlmTCxe9ewdi9EEo8wRTn53PUGh25dzDdhGRW+RnwN3LMYZq4jpUV8mX3Yzz696fhNnNgPhkeOgzgnqsHN7SbeRlSOi6R8sjtvmZzsU49FJHkghiQjb6HKv1Eefq+KWG5xqtd10of8QBvwS4nKO1MjoVBjsXXVEz30AiTB96OLDInRuA0L/uebeaqTBz55E3nrEMMbgR+BY1zR05cFi1rpDE9Mor+yX90JhVNOs/KASXaRmMVsKMc0eyYR2abo8t1QL69ZfxJGW83YrQ+y8ihyOF97gnZb0d4DcwMYDenMgA5w4MF/5tRXG76pawV3kbRaG1CBZwd57/Pt+qryDe0bYvjXz1sdp6rR91zMwtnvyosYzTEz+wSOrURQDTQ+rjONsttfBmkxKwAiwq/lDPjqbZf0zxdWCgXMyVhysNOlHFKMDgXTZicSIx54jUsXZRPS0StPyMK9zwejkVgcYtrPU9ybRJ11XhgkfJkarDbPsGnxA9B4qb5SKlfo9Iu2MpMnJVRS4VCKLDeb698D3JlAHREqZ2sKZDslRHRRDXwCUpMr8vFClmeKPhGiOKqZdFzvdvhRwNexwh9+4X0S1JfUEGgc92fO9ez1cRTeB0SIahTxKAwQnFulmcdENOQoZdYAsLZDNMQeMloQiwrj7MvmthHyl9d9wsbWRFqFYRRRI6d3TIb3x5AlG/ZaWyM2aclGH0wwMEa7ZkjTFah2W2uffHJrhcqH+lvIvUXoAfLVWMNxAwEjAnU+SKQ/hkqTnD7csfaWUqlOClcVnhIGLQhWO9MrSJrU5kNI24Jbp2tEIeNMeXjIw1QIVm/GveZltkkY20pKJFjssjLqymAK7Z26o7Pv7zLMmx11L3oALBa0MEh0cTTO8G23VnysMzOXCZuPRm/s2UAwg3xcF2hmmPwFwyFRYqo77E0Iny9y GGAt0/cX BKoB7Leeq7whxyVRvDwVFID8LNoZWFfODJxzGOirUlTCcLhyVOwJxZWolqKNVuvlAw3zDWnn+zNqHspyWwUprx9cBe/v/v3DDVQIR/PKQSmY93YrgqtC85WZtVv3QoGtfzja/QxsbHBMr9FyzKPpoonVIKQhyoyzuqBkrmpsZeXaCh0pszj8aJjAXxTRE2jO4kxtRlbtyDmpCs1Z/ndHB9ZijE/+IQbmixdSGH3m2Kg9q2npDgma32WSwFcqy6px56RriVaBvaUU051v8I2U+BzL3k94a4Ya1RTDsUb8JzACvFLIC7eLOd4h0mBzwtJqj6ZUvcdo0ylJ59BlEIR+cmtYMk5ATelpEqzXCbX/OD1T91LlfaYSSI19yN1ENdIZzLzzPuGCxb+p9gDmtt4GwPi0SK6yM3JiQBj1z4F5C9uUSTuD2D8AItAecxTQmJ9M8nG6g2CmaHJtj/d0fn+7LJ90PsLyJBwbWAfajkZ29Bc5MT2E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.07.24 03:18, Zi Yan wrote: > On 12 Jul 2024, at 21:13, David Hildenbrand wrote: > >> On 12.07.24 04:44, Zi Yan wrote: >>> From: Zi Yan >>> >>> last_cpupid is only available when memory tiering is off or the folio >>> is in toptier node. Complete the check to read last_cpupid when it is >>> available. >>> >>> Before the fix, the default last_cpupid will be used even if memory >>> tiering mode is turned off at runtime instead of the actual value. This >>> can prevent task_numa_fault() from getting right numa fault stats, but >>> should not cause any crash. User might see performance changes after the >>> fix. >>> >>> Fixes: 33024536bafd ("memory tiering: hot page selection with hint page fault latency") >>> Signed-off-by: Zi Yan >>> --- >>> mm/huge_memory.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >>> index d7c84480f1a4..07d9dde4ca33 100644 >>> --- a/mm/huge_memory.c >>> +++ b/mm/huge_memory.c >>> @@ -1705,7 +1705,8 @@ vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf) >>> * For memory tiering mode, cpupid of slow memory page is used >>> * to record page access time. So use default value. >>> */ >>> - if (node_is_toptier(nid)) >>> + if (!(sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) || >>> + node_is_toptier(nid)) >>> last_cpupid = folio_last_cpupid(folio); >>> target_nid = numa_migrate_prep(folio, vmf, haddr, nid, &flags); >>> if (target_nid == NUMA_NO_NODE) >> >> Reported-by: ... > > Reported-by: David Hildenbrand > > I suppose your email[1] reports the issue based on code inspection. Yes, thanks for taking care of the fix and cleanups! -- Cheers, David / dhildenb