From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD497C433F5 for ; Thu, 24 Mar 2022 17:22:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2194D6B0071; Thu, 24 Mar 2022 13:22:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C9A46B0073; Thu, 24 Mar 2022 13:22:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 042D86B0074; Thu, 24 Mar 2022 13:22:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id E5C446B0071 for ; Thu, 24 Mar 2022 13:22:56 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id B52E1801CC for ; Thu, 24 Mar 2022 17:22:56 +0000 (UTC) X-FDA: 79279949952.05.E13B62E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf24.hostedemail.com (Postfix) with ESMTP id 147E918002E for ; Thu, 24 Mar 2022 17:22:55 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 98A27215FD; Thu, 24 Mar 2022 17:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1648142574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HGT7Uj6/EhveXkVwghH4LYAenDJ1TyPCjNeutemup5s=; b=HQzImj5RZ4tBMpz4HqGSXrKSVTkS8nHvI8XO2MB65609assGuxUYVPCz40M5Ovk6NmFook U7dCxBVS6jWjhhVnfy4ZOSgnDkAqYx5eUl8ZDiJmHxBpVVoqbjqMY8hGmt5dFVh0di7vLQ t9nJfu2lAjAJONY+ukZ77nhKETGTJgM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1648142574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HGT7Uj6/EhveXkVwghH4LYAenDJ1TyPCjNeutemup5s=; b=bKV0Fwya9p1PnCxvArPKuyctqOZ/8wV6lwKLs9LYMyshmhW6dcNJ7B5XzmFqQAohBIGslL vV3f2Jo3Xa4KdjBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 674EC13A7F; Thu, 24 Mar 2022 17:22:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EqBvGO6oPGLaWAAAMHmgww (envelope-from ); Thu, 24 Mar 2022 17:22:54 +0000 Message-ID: Date: Thu, 24 Mar 2022 18:22:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC PATCH v1 05/15] mm/slub: move kmalloc_large_node() to slab_common.c Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Marco Elver , Matthew WilCox , Roman Gushchin , linux-kernel@vger.kernel.org References: <20220308114142.1744229-1-42.hyeyoo@gmail.com> <20220308114142.1744229-6-42.hyeyoo@gmail.com> From: Vlastimil Babka In-Reply-To: <20220308114142.1744229-6-42.hyeyoo@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HQzImj5R; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=bKV0Fwya; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Stat-Signature: yd3qrmwe6rkip5nu7nwe4w6ogdqmdkhp X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 147E918002E X-HE-Tag: 1648142575-688521 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/8/22 12:41, Hyeonggon Yoo wrote: > In later patch SLAB will also pass requests larger than order-1 page > to page allocator. Move kmalloc_large_node() to slab_common.c. > > Fold kmalloc_large_node_hook() into kmalloc_large_node() as there is > no other caller. > > Move tracepoint in kmalloc_large_node(). > > Add flag fix code. This exist in kmalloc_large() but omitted in > kmalloc_large_node(). > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > --- > include/linux/slab.h | 3 +++ > mm/slab_common.c | 26 ++++++++++++++++++++++++ > mm/slub.c | 47 ++++---------------------------------------- > 3 files changed, 33 insertions(+), 43 deletions(-) > > > @@ -4874,15 +4842,8 @@ void *__kmalloc_node_track_caller(size_t size, gfp_t gfpflags, > struct kmem_cache *s; > void *ret; > > - if (unlikely(size > KMALLOC_MAX_CACHE_SIZE)) { > - ret = kmalloc_large_node(size, gfpflags, node); > - > - trace_kmalloc_node(caller, ret, > - size, PAGE_SIZE << get_order(size), > - gfpflags, node); Hmm this throws away the caller for tracing, so looks like an unintended functional change. > - > - return ret; > - } > + if (unlikely(size > KMALLOC_MAX_CACHE_SIZE)) > + return kmalloc_large_node(size, gfpflags, node); > > s = kmalloc_slab(size, gfpflags); >