From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC0ADC30653 for ; Mon, 1 Jul 2024 08:59:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E0F76B0099; Mon, 1 Jul 2024 04:59:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 290186B00A8; Mon, 1 Jul 2024 04:59:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 109ED6B00B4; Mon, 1 Jul 2024 04:59:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E5DB46B0099 for ; Mon, 1 Jul 2024 04:59:41 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 97A2FA294E for ; Mon, 1 Jul 2024 08:59:41 +0000 (UTC) X-FDA: 82290585762.16.B910B9F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 558EF140003 for ; Mon, 1 Jul 2024 08:59:39 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cCiMjWGF; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719824368; a=rsa-sha256; cv=none; b=r4OqwYvtaRiPcy9zhRHVIQjxKg8h1h9oBJCHUwNVyyJVzGwQUVHRS9FEr8qC2MmaDSlzMq F+EMYn2rjVi/rgHkfSK/CekoUxSJ8oW9Hvi5NhdZXsec+uYTNhatGMpV+p9Wmz/9km0hRX N1Z218RAEBpv8qQih8Glfh2FSN8P4vk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cCiMjWGF; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719824368; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9uYOVYe/S8vLD+pbmxnWXeRCdyZnIcQi9ch5IcOoz4I=; b=PRyMwXOdGdtseIcLPA8T/eoOEzMxL8ETdo36HMq0ywQ2ai9VnDg8ZJt+XckSM2cvC1VMVv rpw34T8N0doTjFozFRGy2UWIEYKmyCf6PpJVSB1xIOg9MF4pu7KBme0ia6fN+F5N6Z0uKc EGYsGDdVxfDqkvMFLKipl48x/Eeaz9E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719824378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9uYOVYe/S8vLD+pbmxnWXeRCdyZnIcQi9ch5IcOoz4I=; b=cCiMjWGF6plErQRtX6gs8yKV3Nimf8pVoI7PTBzmAgQ6akdTXHCB+ejtJR8NQKY04lrpgr o1hxzY7cRpDVD4iVRPve5ya2DupIIPySynj6O8NbPwca7YF3Ff/BN4tnJpGmC/AIozCqp2 xdVSs7ADoERUFEKGq6qXSx5JBUGwWfc= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-SSLUjToTNl2mcsTT8KvwMQ-1; Mon, 01 Jul 2024 04:59:37 -0400 X-MC-Unique: SSLUjToTNl2mcsTT8KvwMQ-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a72716df71eso209413866b.1 for ; Mon, 01 Jul 2024 01:59:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719824376; x=1720429176; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9uYOVYe/S8vLD+pbmxnWXeRCdyZnIcQi9ch5IcOoz4I=; b=K5R8lbvGPhR5Kn3i/n2nlNtnjXES+Czz4K9QNr4o52LYul/XOTrmc7MGe14dVX9caw vaDbAlAo51cwT+3/EJdgDz7JVDWzQTiBWRvwx6LqHKx6FoDiq1oLK8M7k09QDHlnmk/k opNnGlKnAN0dWr5HHgcBd0nz1UjSu9Qpd9ZuJl2V8OYeze1wq2Yo9KLBR9vum4JoTERB +OjlFfwbTbycGcgJS+g+ZwrVnbtKcUF0+I9s+Z4mJAqvDcItfCtwy8GC0FOpYGVLefSr c2f5NqsxB/W+vWPrabVGTQMZL3bYSpetpzXJm0uMddwAPue/um+ULEvzAXLWfxtMu65I ZtGg== X-Forwarded-Encrypted: i=1; AJvYcCWWSe1grHP8v2CPjYcpl2efLfdrtvnjzoH9EJBkrYzZllqq5rSSAvaixV3YCJIaH0LZ55f/nf4a3JYGVx1tHR+Gxl4= X-Gm-Message-State: AOJu0YzcGgDZZ0xHfo19PwmH9l+SyVzz6QyEPSm3Ubl3klB3cIX8v2Pt 5B7curSHwKtVSpneFrCve/8kceZDD/fKpL4zcJSym71UYS8PVBuOuklg9qphXzWZpAknY3yHLGw JCxr+qooe/jKl2caX4e4Z6XiNrGeyScXChd7mMhU6S0YnO+FH X-Received: by 2002:a17:907:3e9f:b0:a6f:50ae:e02 with SMTP id a640c23a62f3a-a751446803fmr478915166b.4.1719824376383; Mon, 01 Jul 2024 01:59:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHM3czGdSGmbeNbLrkMbgpMQyqMRvlRY7ksZCrI83uQ/r1Cugdq08d/zn9Zqwxvl5smKMdCgg== X-Received: by 2002:a17:907:3e9f:b0:a6f:50ae:e02 with SMTP id a640c23a62f3a-a751446803fmr478913666b.4.1719824375888; Mon, 01 Jul 2024 01:59:35 -0700 (PDT) Received: from [100.81.188.195] ([178.24.249.76]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab06565csm311746366b.103.2024.07.01.01.59.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jul 2024 01:59:35 -0700 (PDT) Message-ID: Date: Mon, 1 Jul 2024 10:59:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/13] gup: Don't allow FOLL_LONGTERM pinning of FS DAX pages To: Alistair Popple , dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca Cc: catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com References: <74a9fc9e018e54d7afbeae166479e2358e0a1225.1719386613.git-series.apopple@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <74a9fc9e018e54d7afbeae166479e2358e0a1225.1719386613.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: u7fng4ophxzwadrdm4jnzmqww6saokqz X-Rspamd-Queue-Id: 558EF140003 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1719824379-292987 X-HE-Meta: U2FsdGVkX18qko/lUDIKm0Lu2yFZGwVKgSpSCs4SfU3nvYg1zNJiN39zUX2eMJUSD+BK26Yvo34iwPYV1bnJrXl7gofZVehPCSaao7/6blDI1vNCXlAt/2w1cMyad1LqyNsd99TPjOv+ek2/Fo3/BxCVIauCDjn7C3B5T49jE1j8D3R1WUVNoOKLdxCLHtmvtlv3CIZ5M1oyE55/HWKk/V4vqpT1VGgGudhdaRPjxZ7lRZdBwmuADynX28iitqmI1vs174Lrfpgpf1gFxPf122Drr7SOsUtSF6u1XmomyNUiWE7T+c/pT9tz0UmUXC0c1o3wMzu0fcIMzvedrVvoGS5px/G9xQsFYLTO5Wil7WLFPHhDEyAoDV80ODL1kdTQFiL7nSyzABhiQW/hdrhmtKksVbZqu67va66e5H1kcc1kb0HI7aP0YvQ2yMn4A1rmcN1GOngtMRo/nsLyKC2UtbelEEbgP8xkky/N7i6bXkYLRXnrjt2PJy+xhKueNWPH820zh1OlD/6VzDebb1sp6qtus/fgSOApauYMjeYGBkPXcgWRIZmeqm0bjulZqrFITPF+Ia2sIGEkx5fY+MzMHb125zG+bColEpuLCfDBaS8NKYrIcvaoDamcy+1NePdA9xvK22zSNxL0L+wXrKt0o8tSXYoVyUVWYnmSY00RTPJ1Bh5fBiGSM+WAyJoTIR1axuuS7DFNwXDVWtOC4eyRYkdg/IHHOrcDWO7GKztT7/pz8d6Y6AGH8t0VqdW9pJ1p0YAQf3VGUsE764LJ0Tqximl7ovtP6ve3cQ3LfCOumWVrFxH8B4GVwi/0OJqZXg+13hV7z1+vSMzGfh/VpWM8LXek8e15ZWaZ1paY/LSc8+4cQsOY66cEyBQA9pSTlGLEic2qMjBOxmQzg5TrZih2WmLyrheO/LZyVwAeRVLT6ltPtVc82iCM+7k5FG2CoIt3eUgKaKS99nhN/+6zle8 4RQ0rYVS ro7aH/z1tri8IY3z1wHWUAdCsTMgV8nG/Fz/nVLBZ2rPQGVzQN6O4bd6YJUsIppMziMyVYmZpanGNFjtTya+8uc81NcMarcoUuGDxqP0wGoXwxA5Ui63h0QNFLks76Eiz2dh5r37z5E5Hd/E9Zui4fNQwDMkh3cMfIwMQdov6gP2J2lXAVtKefN3U0epwwuQ4+txVD50J869uXCwVzO9v6kwng1JxfSfP4Gz7MFs7byjm2RtEkmiErvxKAUF0BZuemUY5pta8WDb1Ev/Cek/tOJtIpSyFphWu1pEwCtGdOEV+PpVK0btQiXkX2D2cgzvRJNxp/lxtD8pG1Bnl2kPDgQmguhblD+m1g4i1QDWnAuJpFGNCr5cwNSh75M0+kp1qjNxEhDJpR5TCMsbQrYCJHuXcP6mLbCbnWm+/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.06.24 02:54, Alistair Popple wrote: > Longterm pinning of FS DAX pages should already be disallowed by > various pXX_devmap checks. However a future change will cause these > checks to be invalid for FS DAX pages so make > folio_is_longterm_pinnable() return false for FS DAX pages. > > Signed-off-by: Alistair Popple > --- > include/linux/memremap.h | 11 +++++++++++ > include/linux/mm.h | 4 ++++ > 2 files changed, 15 insertions(+) > > diff --git a/include/linux/memremap.h b/include/linux/memremap.h > index 6505713..19a448e 100644 > --- a/include/linux/memremap.h > +++ b/include/linux/memremap.h > @@ -193,6 +193,17 @@ static inline bool folio_is_device_coherent(const struct folio *folio) > return is_device_coherent_page(&folio->page); > } > > +static inline bool is_device_dax_page(const struct page *page) > +{ > + return is_zone_device_page(page) && > + page_dev_pagemap(page)->type == MEMORY_DEVICE_FS_DAX; > +} > + > +static inline bool folio_is_device_dax(const struct folio *folio) > +{ > + return is_device_dax_page(&folio->page); > +} > + > #ifdef CONFIG_ZONE_DEVICE > void zone_device_page_init(struct page *page); > void *memremap_pages(struct dev_pagemap *pgmap, int nid); > diff --git a/include/linux/mm.h b/include/linux/mm.h > index b84368b..4d1cdea 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2032,6 +2032,10 @@ static inline bool folio_is_longterm_pinnable(struct folio *folio) > if (folio_is_device_coherent(folio)) > return false; > > + /* DAX must also always allow eviction. */ > + if (folio_is_device_dax(folio)) > + return false; > + > /* Otherwise, non-movable zone folios can be pinned. */ > return !folio_is_zone_movable(folio); > Why is the check in check_vma_flags() insufficient? GUP-fast maybe? -- Cheers, David / dhildenb