From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id 29F2F6B0007 for ; Sun, 11 Feb 2018 15:27:24 -0500 (EST) Received: by mail-wm0-f69.google.com with SMTP id b193so1594683wmd.7 for ; Sun, 11 Feb 2018 12:27:24 -0800 (PST) Received: from casper.infradead.org (casper.infradead.org. [2001:8b0:10b:1236::1]) by mx.google.com with ESMTPS id l16si5502209wrl.33.2018.02.11.12.27.22 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Feb 2018 12:27:22 -0800 (PST) Subject: Re: [PATCH 2/6] genalloc: selftest References: <20180211031920.3424-1-igor.stoppa@huawei.com> <20180211031920.3424-3-igor.stoppa@huawei.com> From: Randy Dunlap Message-ID: Date: Sun, 11 Feb 2018 12:27:14 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Philippe Ombredanne , Igor Stoppa Cc: Matthew Wilcox , Jonathan Corbet , Kees Cook , mhocko@kernel.org, labbott@redhat.com, jglisse@redhat.com, Christoph Hellwig , cl@linux.com, linux-security-module@vger.kernel.org, linux-mm@kvack.org, LKML , kernel-hardening@lists.openwall.com On 02/11/18 12:22, Philippe Ombredanne wrote: > On Sun, Feb 11, 2018 at 4:19 AM, Igor Stoppa wrote: >> Introduce a set of macros for writing concise test cases for genalloc. >> >> The test cases are meant to provide regression testing, when working on >> new functionality for genalloc. >> >> Primarily they are meant to confirm that the various allocation strategy >> will continue to work as expected. >> >> The execution of the self testing is controlled through a Kconfig option. >> >> Signed-off-by: Igor Stoppa > > > >> --- /dev/null >> +++ b/include/linux/genalloc-selftest.h >> @@ -0,0 +1,26 @@ >> +/* SPDX-License-Identifier: GPL-2.0 > > nit... For a comment in .h this line should be instead its own comment > as the first line: >> +/* SPDX-License-Identifier: GPL-2.0 */ Why are we treating header files (.h) differently than .c files? Either one can use the C++ "//" comment syntax. > > >> --- /dev/null >> +++ b/lib/genalloc-selftest.c >> @@ -0,0 +1,400 @@ >> +/* SPDX-License-Identifier: GPL-2.0 > > And for a comment in .c this line should use C++ style as the first line: > >> +// SPDX-License-Identifier: GPL-2.0 > > Please check the docs for this (I know this can feel surprising but > this has been debated at great length on list) > > Thank you! > -- ~Randy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org