From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18F28C001DC for ; Thu, 27 Jul 2023 09:27:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB8A26B0072; Thu, 27 Jul 2023 05:27:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6A2F6B0074; Thu, 27 Jul 2023 05:27:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 932BA6B0075; Thu, 27 Jul 2023 05:27:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 848B76B0072 for ; Thu, 27 Jul 2023 05:27:35 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 428B980507 for ; Thu, 27 Jul 2023 09:27:35 +0000 (UTC) X-FDA: 81056864070.17.E3B4888 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf09.hostedemail.com (Postfix) with ESMTP id 6DACB14000B for ; Thu, 27 Jul 2023 09:27:32 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Wtjt8nrF; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf09.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690450053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ov8GaOrZpmzA0j8SS/4mOwN8qvFCeLXW0O/KbsJbAj0=; b=3CHZcPzFQZjyc4vanW9+rC97S+G2GTAmOBDQjciJPv9I/ti1wwpGWjWXdQMSHQ1EhaGzd8 EWa3J1qZNd4egXTVqNQ8eImQwMRsDyEV5ZPSHi/5IBrFtjzDB80v3xOUeh8NhjGFzZQRkg MjGILoSLErwOPQ2F/8kp/2tTjV59OvE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Wtjt8nrF; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf09.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690450053; a=rsa-sha256; cv=none; b=kXAap5kZPc640psmfOGTjSb9oYyQ1x5b7x2szk5aOHxhQo3hHDdZyMLzOKQ8Oam6C47g/t qPvN/HevZ0lnR5slKDQA5HcSvh7CSCuV5nMmKbTxh3zpxsT48lLlHzmnY7cOBNI04MSkFC 7P2rAqa+uad3wAUtAqJFWqw5PDvBGbw= Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36R9FDoC013208; Thu, 27 Jul 2023 09:27:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=ov8GaOrZpmzA0j8SS/4mOwN8qvFCeLXW0O/KbsJbAj0=; b=Wtjt8nrFw1RdZc+7ULkrDC08OKVTHTOwcNg9/uuh1mO1emCwkmaCN8J/nbt6I1Q6rvr9 N6jOnXvbw1Fqoxo2GOdIJNyLSvPb4l0j+vBciYXbjRY5XuoAYGJrj9wH2p9pMpCDt2Eu HmteaR/cYdCbxaJygPQk9c7+f0hSVXPYbriYNWH7U6Xc7n3fd9RfzW0W6knR1djoHPB0 IVbua8Aq24uTFds1frBLxLo6Ppa9N/HmR/jKzmVJCuvbMnvn6CycOQ0jCdHo1F2Sq1zW MPVye7x3YnpjPFknw6eKCGehxL1jKyizFVHTabn0lGVMouCzmm8n8elR2t0TM0P/ncSd 6Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3s3n511s9u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jul 2023 09:27:24 +0000 Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 36R8hf6l028352; Thu, 27 Jul 2023 09:27:24 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3s3n511s9e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jul 2023 09:27:24 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 36R8tUFW003624; Thu, 27 Jul 2023 09:27:22 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3s0txkc63t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jul 2023 09:27:22 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 36R9RKD329229392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Jul 2023 09:27:20 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A671920043; Thu, 27 Jul 2023 09:27:20 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E44E420040; Thu, 27 Jul 2023 09:27:18 +0000 (GMT) Received: from [9.109.212.144] (unknown [9.109.212.144]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 27 Jul 2023 09:27:18 +0000 (GMT) Message-ID: Date: Thu, 27 Jul 2023 14:57:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v6 4/7] mm/memory_hotplug: Support memmap_on_memory when memmap is not aligned to pageblocks Content-Language: en-US To: Michal Hocko Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu, Oscar Salvador , David Hildenbrand , Vishal Verma References: <20230727080232.667439-1-aneesh.kumar@linux.ibm.com> <20230727080232.667439-5-aneesh.kumar@linux.ibm.com> From: Aneesh Kumar K V In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: PghE2kCZ43h9QzfydF3yWECW_GUuqV2n X-Proofpoint-GUID: pocW8nM03ogqsf8EAWzXhi7T7PMhsVxL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-26_08,2023-07-26_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 phishscore=0 mlxscore=0 priorityscore=1501 malwarescore=0 adultscore=0 spamscore=0 mlxlogscore=489 impostorscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307270080 X-Rspamd-Queue-Id: 6DACB14000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: oknkg8red5jrswweier51su6tto7goke X-HE-Tag: 1690450052-864095 X-HE-Meta: U2FsdGVkX1+HyqfGUOXSc3d7aLoLeE5rrjloBNbxB91yZB+Jh4NzmPngWE2FDLN3WpAYqjAjECijQPXxlCK+GwYvZPTbz69Qw+xrUgVhAZfsv2wSZHZe9XHf7dROU8/eRMfeOi8LxdAV9TUJlel/TxIZd1IbgT0y84ViSoX3jkONBlCQzlUVtDY4Wrla1QFXdT4Ph1ZFc5W25NZJ+ot+CQdbkCK7cRH5GcJsRZ5KBQjjb1NOzXGyER4zt5zoFpGx+Uxmgqm6aavC/h4h+A9lDR3f0Rq2JL3CkDjA5OyD0Ow9FZSxRiglJ19DMvs8nygIEA5xhjO1LRqbznXdxY8GYWEeZMRZY78VZKW/TL0cIxuuqMPL9AGo6TYAbjWWHRUzEwFyQohj/pC/Qok9VNWLC0i2oba06LnqTgH6Eh3T8MaIzSct/OXNulukapcOao+6Y3PZEmm1z6qaKdcOxlOuZvwJ/ajFzxPylPpl4tnS9aq7gHF6tVTJlcv+gLZk2YaFGsZUWrk68XBRyhM3SgdF2Ga0E5ZA4YP21t3W9UGeSFr7wgC+Vq+umGksIYhLycP0yDlWR4XFo8yKpQO35ghsWCjqVUQSYMLh6JEdChZIuvRaUmq+PR0TJ/j3/uaf9qxstFNNCRzL+RuDMxvEwc/xKg0jPBEa5zyxqsd07JQCZkSHYtj9OUlcUuys872pzDkVqxEUnEHD2+PWW1mKUoT7Ic5bqiatzXFIAmp1MJjdZsIWT79oLyZGq6fr8Nveu0VT/8UUJ+sdYC6Ak4ZW5g0kuJOs5jK4Y2EJlRaLjtEu89s3d05jZGKX7U484Qa6UdOMIVzKvKAbtA/5JYroJqNQJewHj4B4AmsIeeb/EDomwXqJUM/G/KeJ+5VutnxoU4nWitMK8cYFxVQ8M9YIsaHFmm4QbUZ2vFpTyETJrJcuIFLc/x22tGIFrR7qXbamAp9OoOmFeV5MoG16eGypV6u gJSfEg1i xyOG0XVMNyH9Ha93AknrIqJ2wRgl0xrzkOY9uUjbOiIeEetb1AHldbhPvC1ERCS8poqo588LlBCZAtCEuuoDvHPhILSEXIF/4deRmCR1CVoZu9q3n231gNGiUf56TIoj75j3m0Y/MwE17t+BMl7N910LzPXp41vSNI7jpRlraYuN+iuBPm9va0k04kA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/27/23 2:53 PM, Michal Hocko wrote: > On Thu 27-07-23 13:32:29, Aneesh Kumar K.V wrote: > [...] >> + if (mode == MEMMAP_ON_MEMORY_FORCE) { >> + unsigned long memmap_pages = memory_block_memmap_on_memory_pages(); >> + >> + pr_info_once("Memory hotplug will reserve %ld pages in each memory block\n", >> + memmap_pages - PFN_UP(memory_block_memmap_size())); >> + } >> + return 0; >> +} > > Why should we print this only for the forced case? Isn't that > interesting for any on memory memmap? Also is this the above sufficient > on its own? the size depends on the block size and that can vary. > I think it would make more sense to print the block size and the vmemmap > reservation and for the force case also any wasted amount on top (if > any). > For the other cases the space is completely used by for struct page allocation. What the information is indicating here is that for each memblock we add we are loosing/wasting so many pages. May be I should have used the term "waste" instead of "reserve" ? -aneesh