From: Eric DeVolder <eric.devolder@oracle.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Baoquan He <bhe@redhat.com>,
david@redhat.com, Oscar Salvador <osalvador@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, ebiederm@xmission.com,
dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de,
mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com,
nramas@linux.microsoft.com, thomas.lendacky@amd.com,
robh@kernel.org, efault@gmx.de, rppt@kernel.org,
sourabhjain@linux.ibm.com, linux-mm@kvack.org
Subject: Re: [PATCH v12 7/7] x86/crash: Add x86 crash hotplug support
Date: Fri, 28 Oct 2022 15:34:43 -0500 [thread overview]
Message-ID: <f9a57532-42c3-8c68-bb10-6a9648c93b15@oracle.com> (raw)
In-Reply-To: <Y1w76RwZUKUvsS7A@zn.tnic>
On 10/28/22 15:30, Borislav Petkov wrote:
> On Fri, Oct 28, 2022 at 02:26:58PM -0500, Eric DeVolder wrote:
>> config CRASH_MAX_MEMORY_RANGES
>> depends on CRASH_DUMP && KEXEC_FILE && MEMORY_HOTPLUG
>> int
>> default 8192
>> help
>> For the kexec_file_load path, specify the maximum number of
>> memory regions, eg. as represented by the 'System RAM' entries
>> in /proc/iomem, that the elfcorehdr buffer/segment can accommodate.
>> This value is combined with NR_CPUS and multiplied by Elf64_Phdr
>> size to determine the final buffer size.
>
> No, do this:
>
> config CRASH_MEMORY_HOTPLUG_SUPPORT
> depends on CRASH_DUMP && KEXEC_FILE && MEMORY_HOTPLUG
> help
> Help text explaining what this feature is
>
> this thing will simply get enabled when the user enables MEMORY_HOTPLUG
> and CRASH_DUMP.
>
> and then you do in the code:
>
> /*
> * A comment explaining how the 8192 value has been selected.
> */
> #define CRASH_MAX_MEMORY_RANGES 8192
>
> Thx.
>
ok, will do!
thanks!
eric
next prev parent reply other threads:[~2022-10-28 20:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220909210509.6286-1-eric.devolder@oracle.com>
[not found] ` <20220909210509.6286-8-eric.devolder@oracle.com>
[not found] ` <Yx7XEcXZ8PwwQW95@nazgul.tnic>
[not found] ` <cb343eef-46be-2d67-b93a-84c75be86325@oracle.com>
[not found] ` <YzRxPAoN+XmOfJzV@zn.tnic>
[not found] ` <fd08c13d-a917-4cd6-85ec-267e0fe74c41@oracle.com>
2022-09-30 16:50 ` [PATCH v12 7/7] x86/crash: Add x86 crash hotplug support Borislav Petkov
2022-09-30 17:11 ` Eric DeVolder
2022-09-30 17:40 ` Borislav Petkov
2022-10-08 2:35 ` Baoquan He
2022-10-12 17:46 ` Borislav Petkov
2022-10-12 20:19 ` Eric DeVolder
2022-10-12 20:41 ` Borislav Petkov
2022-10-13 2:57 ` Baoquan He
2022-10-25 10:31 ` Borislav Petkov
2022-10-26 14:48 ` Baoquan He
2022-10-26 14:54 ` David Hildenbrand
2022-10-27 13:52 ` Baoquan He
2022-10-27 19:28 ` Eric DeVolder
2022-10-29 4:27 ` Baoquan He
2022-10-27 19:24 ` Eric DeVolder
2022-10-28 10:19 ` Borislav Petkov
2022-10-28 15:29 ` Eric DeVolder
2022-10-28 17:06 ` Borislav Petkov
2022-10-28 19:26 ` Eric DeVolder
2022-10-28 20:30 ` Borislav Petkov
2022-10-28 20:34 ` Eric DeVolder [this message]
2022-10-28 21:22 ` Eric DeVolder
2022-10-28 22:19 ` Borislav Petkov
2022-10-12 20:42 ` Eric DeVolder
2022-10-12 16:20 ` Eric DeVolder
2022-10-25 10:39 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9a57532-42c3-8c68-bb10-6a9648c93b15@oracle.com \
--to=eric.devolder@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=efault@gmx.de \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=nramas@linux.microsoft.com \
--cc=osalvador@suse.de \
--cc=robh@kernel.org \
--cc=rppt@kernel.org \
--cc=sourabhjain@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).