From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6C8DC47DD3 for ; Fri, 19 Jan 2024 14:55:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 371DC6B0080; Fri, 19 Jan 2024 09:55:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 322E06B0081; Fri, 19 Jan 2024 09:55:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EA936B0083; Fri, 19 Jan 2024 09:55:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 117AA6B0080 for ; Fri, 19 Jan 2024 09:55:31 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DD682140798 for ; Fri, 19 Jan 2024 14:55:30 +0000 (UTC) X-FDA: 81696359220.12.62D6F5D Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf20.hostedemail.com (Postfix) with ESMTP id 0061B1C0017 for ; Fri, 19 Jan 2024 14:55:28 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=YNzferZw; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705676129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h4qbCQgj12O8En/gusu3QK+XK6h8GB3JBzV0B53LnBI=; b=oGW6qPw3FlkdGaSVx4dMAYUGYmYc/pViXcFPX9OQWiRJOccCKIDBHi15qsp+U7lYsenvBe r0odbZo+YgiEcVRNOydS+zEUpWWERkfg4ShHKKPbSkW+kLu+PKbvmUo5VsxR17Rabwye3m s6RcUkylZWOPxautyQ/ic5Fs4yZkzVI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=YNzferZw; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705676129; a=rsa-sha256; cv=none; b=nONAVz8VKncDFH8H/3sdWp6VfdyPnwhF/hiwBUjLoFA4m3B7rodxCDD7NcaWYfbQC+8xYc VPu/iDaE7sifevFtS5hQjQgRN+nOpEWnglW11toEi3kCMkK1AO8j0oxkPgZsdcnF9jFAsa bxaKJZa+45uMhoHgF1Tu6K33PUgHano= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705676127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h4qbCQgj12O8En/gusu3QK+XK6h8GB3JBzV0B53LnBI=; b=YNzferZwWQ6R67NBzwQZe0NUaJQyAKDcurN5py4mjGZsPK/MyRETgjnkF//XD52NxPQuHX qBmUyBX6t53kh3Lz/0imTLZHQr9RuadMvDoFEttEagqbv5QgvbI/UY/0fvdo5CbbANGqPW hBGTY34pztOlyUYN8g3x4u5IO59/5/M= Date: Fri, 19 Jan 2024 23:05:11 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v4 3/7] padata: dispatch works on different nodes Content-Language: en-US To: Tim Chen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , David Rientjes , Mike Kravetz , Muchun Song , Andrew Morton , ligang.bdlg@bytedance.com References: <20240118123911.88833-1-gang.li@linux.dev> <20240118123911.88833-4-gang.li@linux.dev> <29695e89ae2d838c9b7537941b0231c3ff559e48.camel@linux.intel.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Gang Li In-Reply-To: <29695e89ae2d838c9b7537941b0231c3ff559e48.camel@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: 9uzn3sznpubeah45rtygckychok6816s X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0061B1C0017 X-HE-Tag: 1705676128-875963 X-HE-Meta: U2FsdGVkX1864ckAZiyKmbuiFg4U1a+z5Id1rkKKTI8P5lnTB13dh8VhHZ7poIyKeVEMaNN4JZjKVtzEbGRgFKf7LMUDHQo0MkAl7M3ShgFShcNigV+McwD3AeyV9Im/6QsHV6U5kBLxLPaouToallJVggb7UlzHiM18aanhXUsT/RBiMFVtVEF0/FpKztbD+dmpPlwylB+aQraL2+021lDR+SmCWwQMackYRWlNdeov2Qw+trZL/qjk5ohxNnLmFdwPHQAKQojthmB0uPy0oPDMxr/MKF6NftybY35JQDXJHCifOeSK9d2Oy3G3FoLjxl4/fru8+lZ1gmsg5IjDqCsdABW4+ph2lmB6k8ODNbvyJTq4KSraiWT7d7wvh6ZkrspHQ2pjsCI51uLVQ1nENjeoxMxMttVZ+uH668VpNBSlW8WnkWt5xpIt4JjIr9qEf9+7fuEYu84tgaXXHWNew459M3O62Z21NfW85ORWLz2ltEbtkY9p2lZEABaTc3fyn/QJW3HxoqSoMTEkpEkPd/dSrcymxWzKD6mqQ94bw54ZErjABbxIO2Il4r/S11IfcmWrgo2X4F3AIAV7YAMr7nrf9bJ+YHKnAhcH8SdAw5jOLy7y3IXUnf0EHlNvlGHK6k2wIKkggxy7FI5L2+exh5FurjAzK/MM6sX881VZMF5VxumX1uI4FVzDBZq4qOChRlE7WDUBnKXYr7upKmqBsoLu8J/9jKUIhzpY7fjU5/tqZEeoaczaJ08akiFoMDRn/RA+d7C5X3gwQ6/oHmJEo6xgdLnbot4PENI5SI/HQQARUD7furaOGinZ7w3qIoX677P+7GX3CgkL/Twm15kXNhd8ll2MrI8m6EjQEt5irGPovPH0b5ofcT5E6HliivWM0sTbXPrAZZuYM+4GiCOvEakiM0MGYMWibCYyP+MTkFDfZ12pOxpJFgpdqxQA3hfsm4i7mn7wFZnGxyTIKhW Dy79PwXJ xI9AYo8wYKIb5nQiduIgFnsz9DDZMyL+aSXPngoUsXKQdvbtD2Viu/pTG0mdjFzk2ohD4U3Tx9c3A99l/d21bce1OP2TNs6ryojPL437m1FN0atE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/19 07:04, Tim Chen wrote: > On Thu, 2024-01-18 at 20:39 +0800, Gang Li wrote: >> When a group of tasks that access different nodes are scheduled on the >> same node, they may encounter bandwidth bottlenecks and access latency. >> >> Thus, numa_aware flag is introduced here, allowing tasks to be >> distributed across different nodes to fully utilize the advantage of >> multi-node systems. >> >> Signed-off-by: Gang Li >> Tested-by: David Rientjes >> --- >> include/linux/padata.h | 3 +++ >> kernel/padata.c | 14 ++++++++++++-- >> mm/mm_init.c | 1 + >> 3 files changed, 16 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/padata.h b/include/linux/padata.h >> index 495b16b6b4d7..f79ccd50e7f4 100644 >> --- a/include/linux/padata.h >> +++ b/include/linux/padata.h >> @@ -137,6 +137,8 @@ struct padata_shell { >> * appropriate for one worker thread to do at once. >> * @max_threads: Max threads to use for the job, actual number may be less >> * depending on task size and minimum chunk size. >> + * @numa_aware: Dispatch jobs to different nodes. If a node only has memory but >> + * no CPU, dispatch its jobs to a random CPU. > > Suggest: > Distribute jobs to different nodes with CPU in a round robin fashion. > Good idea. Thanks. >> */ >> struct padata_mt_job { >