From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 387A7C67861 for ; Mon, 8 Apr 2024 18:32:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 574056B007B; Mon, 8 Apr 2024 14:32:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FCBC6B0082; Mon, 8 Apr 2024 14:32:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DA186B0083; Mon, 8 Apr 2024 14:32:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0D19A6B007B for ; Mon, 8 Apr 2024 14:32:28 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6B1E0A0089 for ; Mon, 8 Apr 2024 18:32:27 +0000 (UTC) X-FDA: 81987209934.20.BA5BBA1 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf29.hostedemail.com (Postfix) with ESMTP id 29BD312001E for ; Mon, 8 Apr 2024 18:32:23 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="Tc/wVIWc"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="HAc/bpEp"; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf29.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; dmarc=pass (policy=quarantine) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712601144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X4rqeoOcBplbIUlsKk1RE5Tl2EYmRvY1QLd1MxHOqi4=; b=b2XLi4wBdEPSBgKUGXGXe6T9vxyQmJyLw4EucDiJxByCbeiHBKM2dQgHJzIDXVV71ydwVL FKZ+znSVqEXp1U/rTkHwVIZsPxL7V2//mFmW3ZpY3iUgn7KS/t0EXPicSweGuf8IVECsJO kmOieIuQtu1/tgx4ruUOlEeq5f6oYSU= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712601144; a=rsa-sha256; cv=pass; b=X50capYHmG7KKgZEbzMChqvemcUlUGw+xKuGxrB/Za9bZMjZY83UaSG3KiZRsNQ3Kg1Dwp 9Zp9pxLLxMchA8D4oA01q/dhjeC28CTpsi+bWlHQhXa8KN9VxBNf2PaAKpoVXP7iZjGjcS mnO1Z/nSvc1k/gze+w/9GBtld3Nd7GI= ARC-Authentication-Results: i=2; imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="Tc/wVIWc"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="HAc/bpEp"; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf29.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; dmarc=pass (policy=quarantine) header.from=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 438ENwkO027268; Mon, 8 Apr 2024 18:31:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=X4rqeoOcBplbIUlsKk1RE5Tl2EYmRvY1QLd1MxHOqi4=; b=Tc/wVIWc2cxkG4w9k19pLiFajuH8Xq9L1hDQkRC5ez9AnDqGVK+Bxv2PaR+fuudhk5fs 48Es+bAI+sGuagHffursw997S5nBdjkR7M3CjxSvvMEUlX61snakUZcLtyaPiGw2IKnQ x5f2o+hcFSAUKj0pDU658ePRAL3zjoNovslTIT5m0R6sgImuUKnjJkcpnWrKsUxD33ns Z0PghjR7uOMDgKDdek4P8kyNcUBULMfrrV4mtCqXwKnlTMpGdQKSdbyun3+hNw6mP46p 8R0c23B7SO+1eec8DKWeaC0ihOdH92MRXdfOf7YhL8js8Q5PuySxR2SDXGYYevU1d/Hy 8w== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xaw643erj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Apr 2024 18:31:45 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 438IFVfK003080; Mon, 8 Apr 2024 18:31:44 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3xavuc481j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Apr 2024 18:31:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=biyZHOoT1pfOx87169pdZrK7q/4azV11atWIgjkVgOKk/ZLrCkgWMH+Z00o9dZISeOI9BhBZ/4GtCZaKgb9Y3F13092hJCII3v2yYtsfFX5oRzPMCn1DObquVNJMuASoR2B04cJZV2wjZENtpwcqsZFnKaP/m3dsCU/f+IsYVy9pgk0FY8U2jPaAACR9mDQsQ6Vmn7hLSAhW8V5Pn3b9LR4AUykfovpSdQYY7DtEnoBDCHK1WU4gm4SpWzUHOVk5uQlP/mJAVF/d3oYbmNrmOw/pLkwqd+HHK0uDg8qtuOrRN5var8eUgEafBA9j0NaxVQDDf+JBb3uk48Z8BqtntQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X4rqeoOcBplbIUlsKk1RE5Tl2EYmRvY1QLd1MxHOqi4=; b=S9DBE+inn/E5XZ7BZ/9H55xn8JZQ9rrSk+Onql+6QdmP5PvYu/7mj+WMSMV7vp8t1rFDnlCgvSPE/JhUE8DJ28y99+ZJYwaCuR7ngIEHyIIJWhe+3HXNH+dLgcf/2utTU7aUp79s9hyL7pKiYKtI3TM4CLwUEUzYKQqITgdre+fZWYCwzFbn2Xjg5EOZgmUpXfY5rbJ6b7pKq1iBuEqmmusK4fVVBNzn6f6Uh3KkIbJKpvGP1MJf9ZOgGxVBhKHlvPZcYzsUqcDajyg0QCJwFhoWsuBedPq/Pn/D+3S5EvUFVkwBExl5p1LG8YRdt14n/QkInriBsC3jY+DG9uATig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X4rqeoOcBplbIUlsKk1RE5Tl2EYmRvY1QLd1MxHOqi4=; b=HAc/bpEp5P+WvKS/0MdgJAed11Rt4DUAGdVYZgBA6/w5L4yBcmcFbIdPwdNygP4oBvdlEvA7zYMiWzN0x2HfK7vmcwWXe8QMiGKy39WGQti8PXPF1Bx4/ImYGWEOhtqK/wmLM7qN+C6YDl3XKKNvVgNXwhdJ1YmOhF5rZuh1IgA= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by CH3PR10MB7957.namprd10.prod.outlook.com (2603:10b6:610:1bf::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 8 Apr 2024 18:31:42 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::f5b:648d:5d73:dd03]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::f5b:648d:5d73:dd03%7]) with mapi id 15.20.7409.042; Mon, 8 Apr 2024 18:31:42 +0000 Message-ID: Date: Mon, 8 Apr 2024 11:31:37 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] mm/memory-failure: Convert shake_page() to shake_folio() To: Matthew Wilcox , Miaohe Lin Cc: linux-mm@kvack.org, Naoya Horiguchi , Andrew Morton References: <20240229212036.2160900-1-willy@infradead.org> <20240229212036.2160900-5-willy@infradead.org> Content-Language: en-US From: Jane Chu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL0PR0102CA0049.prod.exchangelabs.com (2603:10b6:208:25::26) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|CH3PR10MB7957:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DNIf7mqFVuyGI+6pP1ftSOOn7YYYxKXtcfbNfLL9ogIxKg/E/RVBDpgifcRrRXXyAjWQA6z64mgonH6obJ7gDDQHMo5WG3gkNXyZ41B330isdenSj+VCP7CSptTa4lqQF49fjiyfeL6E/bZ7sVQR1hF3mWSF/Spfe4BZbvgQjE6gl/wCAMgEnw5/k1SNZ5LIjbdrbsNvXW/KixfpmQuWGtMxS/XineFFu4nHYOf40+/QpL1cc63HmGBnHhSsHzTyOVlJl0EXfv+hRFNJkXLTjhqPJJUnVNL6IPC5naxIvB7Luh8LDRlyEdXRnXAjMAJBIHR3Eh6VJxzlRJyfaQZrMdZZfQoJUaHdgBoh087xCGo8WszMGCifYfTryHOgTMcYc/86oeR5a4xoo0Ks99l/G6xL2/ZOSqG3OOPG8ZvGWz4lhfbtEfdF+1ck0avL8MCMG7vX7DbY4uPnrJ0HwiOcASPiL1dsruSTxwp3/Vr0H5uWzI/5nEgU4RxrV4ak7hFCDeke52Jbjp7/e1MActqKo2BeuAA4B20JVTB2+2zbY8flaYUt7SqImktfFIXYCkwjadfBbdPGcqVAho2Onlqvb76D9n/ptgbTGk/9FwOKo9fn89bG+o7r/K7Kf4EpZvsW5IqF5o8r6eNSDbFXgAki98Ek0PHjd0LQdORHPltE+OE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0dJeDFZRHBRNTBSL3p4SVpCZGVpNTZkdGpJQ2hldWthS1FtMGd0enlTVWtv?= =?utf-8?B?cWUrWkczMU1ZNzR1UUJML3BoL0YxUFhRWTUrL3FLRVZZYlVmN2NFRk9jMWt2?= =?utf-8?B?UW5oT3VzTE9iclB6WStJZTZOR0Radmxubk9rV0RJY0xXWVFwYmNJek5vNjFi?= =?utf-8?B?WDBTdlh4b1hNRUlMejF2cUhKNkRPU2M4SG1EenB6Z0pVeWgxaGxJQ0RhZTdG?= =?utf-8?B?Ym5OcFpFdmFDbzlOUGxhVSttMlBsdnRBRVVaZHpPd3NSdFk4Mjd2MXJJMzlW?= =?utf-8?B?Yi9FRk1QQ0NTcVZuQkFaQmZoL0JLY01CMmhwUDlhYVBmdlNCcGxEczM5SkRO?= =?utf-8?B?OVp1U0ptZ2QwTFFxNGZlaHNUWTJLdlVlK1pESk53M1VuZkVzVlh4bmZIemJm?= =?utf-8?B?VzFtTzBtL2QwN1MwMWxFQXlWdTZFTDJVbDFaSWhYbEhOWElUUU5wMk96aWo4?= =?utf-8?B?UzBDbi9GNEl6ajRyTUg2LzZTYkVrMlNzNDNvY3orSktUelJGVVhaYW1keG01?= =?utf-8?B?aVJVVEpSMU1xSFJqVmhCRndHTnJCU1J0QlZsckY0Y3lvb2FSYnA4TEtWTUlp?= =?utf-8?B?anpWREZ1UlRSalkyZEZmSW9OdHZBS1VobTBWUW56eHZBSklGdVdrWkpFY09m?= =?utf-8?B?bkVZRVJzWk4rdFNjTXN6eHdKZG5VbkJUcUJWckREUWxCVFJ0dXB5VjZJdG9z?= =?utf-8?B?M0srMTFtc3JCRXQzRTU5Mkx0OUx6R1hKOHJJditONlFVdDhtYmtTYVFiRDVM?= =?utf-8?B?cWNVWlM2TmJaSG5iSzZOblZwYiszOGRZRkJYZWlqNHF6QU5JZ1EvRk8xVTkr?= =?utf-8?B?OEJ0QWd1OWhUQy9BdFc0NUdoamJlWmorZGZ2WGtOdmRTbXBKcHErQUdMbTdM?= =?utf-8?B?dE1oMnc1bjJYdUx4MHloUFFUYVY0VUYrd21UZ1dlVDFyc2tNUkYzS1ZGY2tt?= =?utf-8?B?cTUrY3BoN2Vjc1Q4YWNNNzc3U2U0dG5tdXRVS0plK3pSN0NpSThGcE5ZVjlQ?= =?utf-8?B?c1V3ai9JS1puR2x4YkVvdjNnM3hvZ2M5bzN1dHdMU3Jaa1JSTnR1cWJOK1Jp?= =?utf-8?B?ZTU3UmtEeHpTNktmclRRMncwczQvNHJES2locGhxRnlRYnVnOWhVU3krZ0VW?= =?utf-8?B?SEI4dSt2dld2dmNxb1RkZWpzVjZjVVlOQjBzTGxaRVFTWHA5T0R5cE1YZmRn?= =?utf-8?B?YmJqOFlCSFE5Y0tUeHloNkxHcnlSQ0JPbURMLzg5RDEvbEhkTXBzalJ2NjRh?= =?utf-8?B?WG9sQ0FiMi8xUHphV3NudndzVUlZU3kzZ0U1Q09UYUZuaWI0ZHIveSsrazFa?= =?utf-8?B?VmFUcm0zYmV0eEdmT0F2MmRCRG5COXdSMVRZeTdlTngxdWMzZHhsNGM1VGQ1?= =?utf-8?B?K3E3a0lNYWVoc1ZSU0FZUlkrTklaRmxnQTlqbGxIWlRZTDhSMFdTUlB2Z29F?= =?utf-8?B?NG9URVdLYVExeTBYUHRvcDloeDgxWG8rVFlFeUQ0MmQ2UWZ4SW9rZjZQd3NI?= =?utf-8?B?RDR0VTNiTzhiYUhxWG1qSGZGMXhORDNiS3ZST2lkUXQvTHFaT3Jxb2dFSnBr?= =?utf-8?B?eHZwL29EK0ZxQ1NmSnhWUmVHZEw1dFFNaTlHMWhlUWVSeWFGcVBIOU9oZnlZ?= =?utf-8?B?dHRkODVtamFCZEU3M0NKYUFSRFh2cmpwZk0xRlZlcXcrTjJNc09FYVQvS2ZU?= =?utf-8?B?ZEttV2kwK0pTL0U1M1JOdHBJVC9hTGpNNkVxUGczM0hlTjl3aTBzV1VUQzFk?= =?utf-8?B?R1Q5cGNpeXNadFFGZHhHTXlvQTJGd3dnZWlYUTA3YjVhb25nRmxJZVhUNlow?= =?utf-8?B?Mkh1ZWs0L0pEeG9MYVFCeHp0a1pkcVNnRS9STUtieDUyd0F0YU54QWJzR29D?= =?utf-8?B?RGhrVFpjanNqVm9ISEZ4VlBnQzJGOGx5QnREZFN3MkhVQkF1UUxGa3hnM3dL?= =?utf-8?B?clc1eHRwWUd1V1c2YS9GU2d6UlozYk5JSGtTWStjc0tEaDJXUm83RlNNT0lq?= =?utf-8?B?VXZhVEx1cmZ3MmlzZnBWbU9kWGJaaGtQMXpZRTM2SUFDeEdQWjZQSENsempx?= =?utf-8?B?VTFJajBkYXdFY3dIVDBLcWZMdHNUU0hUcWtVb2dMcWFvaldVZmhteVorMVlJ?= =?utf-8?Q?velb8o/9epQ+mJvM8kMzCHvz4?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: PGQD3U5laCsZjZiurvInMEU9hJrIBorCScb1NAKlGcGxLyBGmZC1A+6q9oN7sHB0S5US4Um2mk5F3WCb4O4lkTnmhkud2tNU2+nGoCOSNTnETNmFZvTqP4V2/L4d4/003Mt2u7e9scf1gR2gYO6btArQMB/NQESGRKCqELegkXxPPFZ6ZkX9kZXJWsksMDCRa8l2wKU5EVqlFeu3g6ZcEYUHGQHhczbpP0QwngQd7qUeFE9vHkFCObGyFeyU+L0SdQSH9sCkWjemPLn6bPsfZ5wYdVh914B6CASOhhP89tK4pQxXq9HXdWCBIK73Ii0CgEMj6v0fgMy/XUOBMFDZjN7BVkcx0dIeo1IzwvzHg23ECjMYG+19kQpxyJXttFRh/3h77EumVm0QcjIq21qPannja7aifBNJZod4272ZSQfIkmSJvUjRYN1kB/DeYECgp1DULNlgj3XUMc9kQB0OzdY2IchwuI/WCHe8vpstKkICt+dIyiZHVBgL28KBLwTXKCHTIniYC2QEwdu2jwLxBGGY6/pFGr9jIH9j+wEP6OIjNVJsIqLH0Td3dNPHLAXbAYVIWN/AsBwDy/F5sYZX2eWWlt/WdMnRrtG8g5yjojg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe03c8fc-740b-41d6-6691-08dc57fa22d3 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 18:31:42.1708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nz/W04eExf/vOFj+1mp3SsiBcxNSl6FdwijZvFJtw8Lu9cJWKU0UPjs1QyglR5oqiGCOje5VHm6E+lKJkYFAWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7957 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-08_16,2024-04-05_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404080143 X-Proofpoint-GUID: UUcUyg7Icwg0_eUpNZMbLRavf98gQeUa X-Proofpoint-ORIG-GUID: UUcUyg7Icwg0_eUpNZMbLRavf98gQeUa X-Stat-Signature: xa3kkgyg9r7hym4d3oa3uzs6t69miiwi X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 29BD312001E X-Rspam-User: X-HE-Tag: 1712601143-731839 X-HE-Meta: U2FsdGVkX19q510FIzyWCP9zXv0g/LpxIbCdZRuOhseOZNoZHCXVWMSZQVUnxLu5QInexH3BR01GtgKMT7jE6Rdc53ujEm43id7w38kIrN1kspMxIleRVKug67697rEC1ZEPgKXMPTvtUi6w1uUrH89BXBkHtA4amcR5WglOgGaACQb/dFkWB/hVbhLcb2Q+diMaivMxCGBwfUk/jubwggDCgV7RLEA5A6hF6TDBaAW5Jn8s9LXDOlCklV+ecBwWvvejy3sw5VxBYGcsHqUJoicj7xob94SbupOAHjKnyn+AW69SI53XTsjc/SXP9myjlr+3ohfQRN+x3Cf56Ts+aT5egJAzVBvLgasWhOg+rVIsTeAz7UQOMikKUyVfz24mNseYbIIP3azkLn0s3F5rq3wP2cPRAePeDvD+U3lenw8J1dVZ8pikKRXDk45SutpIfVmTacicCBE82VSIJZuJX69Evr1J7sBkT7DbZqi6ujhi4jNK9S6ofHFGBKqR0Kd/YJB6/ocCMw1oHtnxhmynz7s5Zak6tiMgvHxgP0zB+P32iI9qFxIeZiTXJr1KP7M97r2x1kqzyRvIY1MbeaCodRsjpn0Xu4cVgcKxUqzBesb85eDpgnOtimN0AnFjPgGP+oAqo3li5tPdyIo7iTE2kqCBBcCW3kTMY5qN5ZVSRKssPoxktYDdYXJqGZuq4NrtQvCREuLSCnK4BhCwvMdGbr79OGEDo7ecsTkIR9xEPZNmQdpJbzBUuUPRIGqllgDO252wSp2kfYp8t6l4gERY2TT9SzMjVDe8UPJdzBD3izgTpgue8Pr9voweJRp2JO1tCSSVN+kDG7KkbLOhl/Ko5UYHLV+bpOu9kHvleKxm3GQp3+nqHpNIBGpuqiG39yh9qGi82uuc7Dlf1gstZSYa3jPj5W5GfMVEcsFCdJtcibe/gfoKAZwy8E/ZK9M+iekjzRFdQah7K5flfFdmeHW nhrxPZdT R2+F9auDZ16Gr0mTikiKBY+F/1bk7kaGIGV/8M+hrh7GKlFWD1vxedeZydjzkdLFrbZRupMULJhaRJ+6bJZTOLEXGQHWwVOq2fdCCj2t6JV8yNe0vXhMZYcVRTKfo3e5Y9dJRlXpmqqPwlNBe3GKYQ2TGCj0fMFgytVrsp6gC7xaQugkhTt/xMJzXg+kFwdKAF2R8DkTRt52GA/a5v84HCcRkgqx3MPJnWN+UNmm0Yg3NYBioiKV8ptKiU6zUIIdEOAChPQRAC+n81pXOY2QCWbIdMY1JCHjfCCPxtCG50AGZFO9ZKyrgFfqpABGbEWqJIHIGFNM3yO0+ivafOcRIMp7SE8Syulzl2UCasOMYV9XxujfcrMm0PktOnC8/q7q0PQjQ1q29wqwjRuIWDPXJPQc346B+XuEnBNrNnAnpRMolBSFGGK3nMZgOvHXnRjlGBSDZ6ZcTleU0rF1M2QVfd8bGEdzuG7xKj8kzhp7fBLBpqu8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/8/2024 8:36 AM, Matthew Wilcox wrote: > On Wed, Mar 06, 2024 at 05:31:19PM +0800, Miaohe Lin wrote: >>> -void shake_page(struct page *p) >>> +void shake_folio(struct folio *folio) >> It might not be a good idea to convert shake_page() into shake_folio(). shake_page() can >> be called without holding page refcnt. So the below race could happen: >> >> hwpoison_inject >> folio = page_folio(p); --> assume p is 4k page [1] >> shake_folio(folio) >> folio_test_slab(folio) >> test_bit(PG_slab, folio_flags(folio, FOLIO_PF_NO_TAIL) [2] >> VM_BUG_ON_PGFLAGS(PageTail(page), page) in folio_flags >> >> Between [1] and [2], page can become PageTail of a THP. So the VM_BUG_ON_PGFLAGS will trigger. >> Or am I miss something? > No, you're not missing anything. This race can happen. However, I've > removed the VM_BUG_ON for folio_test_slab() with "mm: free up PG_slab". > Now it goes through: > > static inline bool PageSlab(const struct page *page) > { > return folio_test_slab(page_folio(page)); > } > > static __always_inline bool folio_test_##fname(const struct folio *folio)\ > { \ > return folio_test_type(folio, PG_##lname); \ > } \ > > #define folio_test_type(folio, flag) \ > ((folio->page.page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) > > which has no assertion that the folio is not a tail page. Maybe it > should, but until then we'll silently get the wrong result ;-) > In this case (4k page -> THP), the act of drain will be triggered with perhaps nothing to do, so looks like a harmless 'wrong result' to me. thanks, -jane