From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 131D8C001B0 for ; Wed, 16 Aug 2023 10:12:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A3898D002D; Wed, 16 Aug 2023 06:12:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 753108D0001; Wed, 16 Aug 2023 06:12:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61B468D002D; Wed, 16 Aug 2023 06:12:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 51AA38D0001 for ; Wed, 16 Aug 2023 06:12:51 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 16C4114036A for ; Wed, 16 Aug 2023 10:12:51 +0000 (UTC) X-FDA: 81129554142.01.B9392FD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id C8653A000B for ; Wed, 16 Aug 2023 10:12:48 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cHjD5WO1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692180768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pxeSOckQKw4dtSxcy30SLEYbSszPBpgrvgvEwcI35yo=; b=YnaL1T7jbHQSbeoCumJ2gd6oc09MvrggXvks8UHdAM1JCVCgqPyMjXeYPwYK2AVaoaM8Nz hZmAuJdi+Q3uuVSJT5f8FuMPidTgu4BGTPJAkL3Qr4LBql1DxFxMHOBquYH3yBrJ696JEM xKQrXGTSKt/7hk6GKCOfNyaqprPNSmM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cHjD5WO1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692180768; a=rsa-sha256; cv=none; b=Y8+p37WPRJIDTocVulkJtn2US0zdHOILMxXN67j8wPDt3essltGO7pyoMWvEO8C4re1kpg 6dZ8hGdSIcHXVmGYTM0d9kDWPIE6pMn+0GlA/gKILcdQ0+/4Cz/bDAluwFwwNTmiHmNMEl EetJ28z9qhhl2mVpC9rASbJSXujl4oE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692180768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pxeSOckQKw4dtSxcy30SLEYbSszPBpgrvgvEwcI35yo=; b=cHjD5WO1pn8N6B8tqC8qTAOgOOiQaEuPbpypnSkqqYOpM/Ea20IMr8l5szt2Jf0QEZfM1M 3X5Dndb+1ARO3ona/8IH46VE0CmPaJ56PmjBd/fV9UJolDOV7Pc0gK1jtOffwAvIRMM13z el0KYE2V0vx4Uh7pBgWh9f4vgVdLShQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-WFVcjxlQPReJYNBePTwnZw-1; Wed, 16 Aug 2023 06:12:46 -0400 X-MC-Unique: WFVcjxlQPReJYNBePTwnZw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fe919c0348so16880015e9.1 for ; Wed, 16 Aug 2023 03:12:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692180765; x=1692785565; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pxeSOckQKw4dtSxcy30SLEYbSszPBpgrvgvEwcI35yo=; b=FLc5LwbVcFl3RsrVxJQWNlUyewVHyTJWoP1SWjnp2LV+B+m/gH/HaHO+n9GA8EcNss VvXkZtqRLgiY4hLZbyPeqKhs5JWmofZwZUGXLoxscLis2OqIMKwvP0xokDHZ2Bb/jatY GbSNczGNTz8zLXreWmkfpfMvfbECd50Zu5w85PQIylQO2p2csmyA/clQo/T0x5IqIf/q d+z/rWrt3jpZcHo3liwAnmV3rX8oeMQe+vSyXJBkRF/RIdPIXnddUNEA19cpwL63SdoN tSmoMHxhxOlnZGPXhVXnjvr7LCbXNJGNmC+DPwgF6bmuxpKG7XBnSU7/X+4EjROUG+Qz gEVg== X-Gm-Message-State: AOJu0YwbZpms/nyHxGPZboqQkIhF/TUv22a3XNrfzWEUXOaf3DVnKNMv mTsqHtsVdysVI6jbUcAZL5cAY9TdXyNfrmdCa7WIb+m/CrSzTUM8OmMyAY5/9Z3IHFoLiK4gZtD xzsMM+/7MEFo= X-Received: by 2002:a7b:ce96:0:b0:3fb:af9a:bf30 with SMTP id q22-20020a7bce96000000b003fbaf9abf30mr1285769wmj.2.1692180765682; Wed, 16 Aug 2023 03:12:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGqO5dx9GO1vQCAK5+arzBnsN6aBIoqM8XkI0MI+rXYVfXFTOndkgoOu924oMpblFAwifphRQ== X-Received: by 2002:a7b:ce96:0:b0:3fb:af9a:bf30 with SMTP id q22-20020a7bce96000000b003fbaf9abf30mr1285749wmj.2.1692180765222; Wed, 16 Aug 2023 03:12:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:8b00:5520:fa3c:c527:592f? (p200300cbc74b8b005520fa3cc527592f.dip0.t-ipconnect.de. [2003:cb:c74b:8b00:5520:fa3c:c527:592f]) by smtp.gmail.com with ESMTPSA id e9-20020a05600c218900b003fe195cecb3sm23635677wme.38.2023.08.16.03.12.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Aug 2023 03:12:44 -0700 (PDT) Message-ID: Date: Wed, 16 Aug 2023 12:12:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Matthew Wilcox Cc: Andrew Morton , Jens Axboe , io-uring@vger.kernel.org, linux-mm@kvack.org References: <20230815032645.1393700-1-willy@infradead.org> <20230815032645.1393700-8-willy@infradead.org> <7c1bb01d-620c-ca97-c4a2-2bb7c126c687@redhat.com> <88bdc3d2-56e4-4c09-77fe-74fb4c116893@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH 7/9] mm: Add deferred_list page flag In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: aww5w3kcbzii3ph7hwu34t5ht7a3f9dw X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C8653A000B X-HE-Tag: 1692180768-631538 X-HE-Meta: U2FsdGVkX1+gaiXrFBzF5/IJpX85IY2YFB0tCYjOn+zXUSQLDmabm/PcX5HHKZEja+BKBfSsoUAiF3LsU8QAulL8d4BuPQsJbuKaPhj23phZkbSQ0LC1RSSpJpSOpj9xtFQ2Tpf83mwyPLWHJnk0Xxy5hrcYOPDhO38+rLibQq4AXpHIJMcPnq1WZ0nmwqkJYNjIht6hBxCToVJ4r+tjrfBGDfSFOtPhg0+RPMCgGYPjIOiFpTFr/OzbgbnvJ3ARa+RfSxu+8qyd6nEKAwmKZOb4NMnKl2rKCOhtTbD1f+TIs25/84MaXqTmsAC4YWhUP+si4Dg3YdqgN3UPf9alCD4xETCSypGyLe2JeVZ6ftEcHjWREOZvU9ALaRDilIHsuEGM1dVmB+Tpyio0qhhPIlljCgbK9tsJ8IMEU1UcpAwWR5fjH/lE8mzisLAl2zrkC6OjJR66ir892DfQFws2P2D6OuWpCeBe5Uw45zwVM96BGfd4w8SHtD8QjDPNCIEAbvrR6yuBXdjpU2cwmK95jXxyV053zbdx2lyT7p7k94o872sU2M89GsDgKu3VYZNe4H9OvS/O5+DWLorUaXGUbNyq/WhGO16fUOx9ANJOx3BbXfds9eqvo3mmbIi9BZcUNQNvEebdP2xrwQGrQkBvugDWMJK6Ta3LfMLp7vSaqNwSIfMOkySwGbJJtlJ1UdhtLfmMCftB2KMs4AmW5ytI1pc/ZL0+suAUx7uC9Gv+NAJI/wAg0dTW/Kd8Z1vFIIC0NS4oBZ9AJ1K1xbLCF8HjJadrvPzrh3bN3syTwZyDfC6vVH7Q3TU3gaIqwIaziLajNlBSx7aCQb8+xP1gol74695+So0l4WRz9bZMI47x308qM/dKaBNzbTQgDRC8EsWYQe29BSS3CHJHd1+gfJO9STMVl7RhsvBiLo4gxpJT6fJa/7j23iHP/qaJa6hkLrX8PjUa1zgeeIuKHBpCC4J oLF7r535 nmKVc/KLB2fQQrUxWKTl8J8EAyMWSRV7HPHcoczM+P4/lnxCLTVqXLdj024qImX1pcRzXvEvrlNBtSSUJgwr7+0u79D2lZaVgq6zv9iMw1QkY/vFYuge1GogOdz/wZ7JHMDs9DNn0qI8oWs9cXQILvydnqcCrvyK2Z5qr0Q4CBe6UAucxzXD6g2GVV7G81w9Wln3tZ7vIzuinhJR5DQoxrno+MLyWYLaD5gxIH3T8EfFklsL2/Fkk0XPCtMxBZiyCr3+WiFzHfxCRzDNbWwny7e01zRuaUm2dW/8ZsTkKY/vMUF/vMU3wGleGjhY6Tf7V8KvfcoIU2aL6BEhGeaFKa+JWXAbHtuLzFMC3dKwayjmSAhfEC/dwOOFN9mk+q5oYn9evhyC8mvFdr5VzZV/9p+w6yNKLJdsbENV3Zn5C6ULozMhO0nPAxDbfIOZVB0zzBQg1NC0GFs0Wz6/2dndQqBssuJGkQymTeZc5J1+JIv99hd0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.08.23 05:14, Matthew Wilcox wrote: > On Tue, Aug 15, 2023 at 08:58:24PM +0100, Matthew Wilcox wrote: >> On Tue, Aug 15, 2023 at 07:27:26PM +0200, David Hildenbrand wrote: >>> On 15.08.23 19:06, Matthew Wilcox wrote: >>>> Theree are a lot of counters called THP and TransHuge and other variants >>>> which are exposed to userspace, and the (user) assumption is that this counts >>>> PMD-sized folios. If you grep around for folio_test_pmd_mappable(), >>>> you'll find them. If we have folio_test_thp(), people will write: >>>> >>>> if (folio_test_thp(folio)) >>>> __mod_lruvec_state(lruvec, NR_SHMEM_THPS, nr); >>>> >>>> instead of using folio_test_pmd_mappable(). >>> >>> So if we *really* don't want to use THP to express that we have a page, then >>> let's see what these pages are: >>> * can be mapped to user space >>> * are transparent to most MM-related systemcalls by (un) mapping >>> them in system page size (PTEs) >> >> * Are managed on the LRU > > I think this is the best one to go with. Either that or "managed by > rmap". That excludes compoud pages which are allocated from vmalloc() > (which can be mmaped), page tables, slab, etc. It includes both file > and anon folios. > > I have a handy taxonomy here: https://kernelnewbies.org/MemoryTypes > > Unfortunately, folio_test_lru() already exists and means something > different ("Is this folio on an LRU list"). I fear folio_test_rmap() > would have a similar confusion -- "Is this folio currently findable by > rmap", or some such. folio_test_rmappable()? But what about hugetlb, they are also remappable? We could have folio_test_rmappable(), but that would then also better include hugetlb ... (in theory, one could envision hugetlb also using an lru mechanism, although I doubt/hope it will ever happen) Starting at the link you provided, I guess "vmalloc" and "net pool" would not fall under that category, or would they? (I'm assuming they don't get mapped using the rmap, so they are "different", and they are not managed by lru). So I assume we only care about anon+file (lru-managed). Only these are rmappable (besides hugetlb), correct? folio_test_lru_managed() Might be cleanest to describe anon+file that are managed by the lru, just might not be on a lru list right now (difference to folio_test_lru()). I've been also thinking about "folio_test_normal" But it only makes sense when "all others (including hugetlb) are the odd one". -- Cheers, David / dhildenb