From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev,
"André Almeida" <andrealmeid@igalia.com>,
"Hugh Dickins" <hughd@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
"Linux Memory Management List" <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-dev@igalia.com, krisman@kernel.org,
"Daniel Rosenberg" <drosen@google.com>,
smcv@collabora.com, "André Almeida" <andrealmeid@igalia.com>
Subject: Re: [PATCH 3/5] tmpfs: Create casefold mount options
Date: Thu, 29 Aug 2024 12:25:57 +0300 [thread overview]
Message-ID: <fc502406-af31-439c-b8fe-94518dd7c800@stanley.mountain> (raw)
In-Reply-To: <20240823173332.281211-4-andrealmeid@igalia.com>
Hi André,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andr-Almeida/tmpfs-Add-casefold-lookup-support/20240826-135457
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20240823173332.281211-4-andrealmeid%40igalia.com
patch subject: [PATCH 3/5] tmpfs: Create casefold mount options
config: x86_64-randconfig-161-20240827 (https://download.01.org/0day-ci/archive/20240829/202408290349.lp2Eq74b-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202408290349.lp2Eq74b-lkp@intel.com/
smatch warnings:
mm/shmem.c:4307 shmem_parse_opt_casefold() error: uninitialized symbol 'maj'.
mm/shmem.c:4307 shmem_parse_opt_casefold() error: uninitialized symbol 'min'.
mm/shmem.c:4307 shmem_parse_opt_casefold() error: uninitialized symbol 'rev'.
vim +/maj +4307 mm/shmem.c
a024e87c2944676 André Almeida 2024-08-23 4291 static int shmem_parse_opt_casefold(struct fs_context *fc, struct fs_parameter *param)
a024e87c2944676 André Almeida 2024-08-23 4292 {
a024e87c2944676 André Almeida 2024-08-23 4293 struct shmem_options *ctx = fc->fs_private;
a024e87c2944676 André Almeida 2024-08-23 4294 unsigned int maj, min, rev, version_number;
a024e87c2944676 André Almeida 2024-08-23 4295 char version[10];
a024e87c2944676 André Almeida 2024-08-23 4296 int ret;
a024e87c2944676 André Almeida 2024-08-23 4297 struct unicode_map *encoding;
a024e87c2944676 André Almeida 2024-08-23 4298
a024e87c2944676 André Almeida 2024-08-23 4299 if (strncmp(param->string, "utf8-", 5))
a024e87c2944676 André Almeida 2024-08-23 4300 return invalfc(fc, "Only utf8 encondings are supported");
a024e87c2944676 André Almeida 2024-08-23 4301 ret = strscpy(version, param->string + 5, sizeof(version));
a024e87c2944676 André Almeida 2024-08-23 4302 if (ret < 0)
a024e87c2944676 André Almeida 2024-08-23 4303 return invalfc(fc, "Invalid enconding argument: %s",
a024e87c2944676 André Almeida 2024-08-23 4304 param->string);
a024e87c2944676 André Almeida 2024-08-23 4305
a024e87c2944676 André Almeida 2024-08-23 4306 utf8_parse_version(version, &maj, &min, &rev);
No error checking
a024e87c2944676 André Almeida 2024-08-23 @4307 version_number = UNICODE_AGE(maj, min, rev);
^^^^^^^^^^^^^
a024e87c2944676 André Almeida 2024-08-23 4308 encoding = utf8_load(version_number);
a024e87c2944676 André Almeida 2024-08-23 4309 if (IS_ERR(encoding))
a024e87c2944676 André Almeida 2024-08-23 4310 return invalfc(fc, "Invalid utf8 version: %s", version);
a024e87c2944676 André Almeida 2024-08-23 4311 pr_info("tmpfs: Using encoding provided by mount options: %s\n",
a024e87c2944676 André Almeida 2024-08-23 4312 param->string);
a024e87c2944676 André Almeida 2024-08-23 4313 ctx->encoding = encoding;
a024e87c2944676 André Almeida 2024-08-23 4314
a024e87c2944676 André Almeida 2024-08-23 4315 return 0;
a024e87c2944676 André Almeida 2024-08-23 4316 }
a024e87c2944676 André Almeida 2024-08-23 4317 #else
a024e87c2944676 André Almeida 2024-08-23 4318 static int shmem_parse_opt_casefold(struct fs_context *fc, struct fs_parameter *param)
a024e87c2944676 André Almeida 2024-08-23 4319 {
a024e87c2944676 André Almeida 2024-08-23 4320 return invalfc(fc, "tmpfs: No kernel support for casefold filesystems\n");
a024e87c2944676 André Almeida 2024-08-23 4321 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-08-29 9:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 17:33 [PATCH 0/5] tmpfs: Add case-insesitive support for tmpfs André Almeida
2024-08-23 17:33 ` [PATCH 1/5] tmpfs: Add casefold lookup support André Almeida
2024-08-26 19:16 ` Gabriel Krisman Bertazi
2024-08-26 23:40 ` kernel test robot
2024-08-23 17:33 ` [PATCH 2/5] tmpfs: Add flag FS_CASEFOLD_FL support for tmpfs dirs André Almeida
2024-08-23 17:33 ` [PATCH 3/5] tmpfs: Create casefold mount options André Almeida
2024-08-29 9:25 ` Dan Carpenter [this message]
2024-08-23 17:33 ` [PATCH 4/5] tmpfs: Expose filesystem features via sysfs André Almeida
2024-08-26 22:58 ` kernel test robot
2024-08-23 17:33 ` [PATCH 5/5] docs: tmpfs: Add casefold options André Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc502406-af31-439c-b8fe-94518dd7c800@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=andrealmeid@igalia.com \
--cc=brauner@kernel.org \
--cc=drosen@google.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kernel-dev@igalia.com \
--cc=krisman@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=smcv@collabora.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).