From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70F6CC636C8 for ; Tue, 20 Jul 2021 23:07:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EA66D6101E for ; Tue, 20 Jul 2021 23:07:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA66D6101E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A62CB6B0036; Tue, 20 Jul 2021 19:07:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A116E6B006C; Tue, 20 Jul 2021 19:07:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B2516B0070; Tue, 20 Jul 2021 19:07:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id 570A86B0036 for ; Tue, 20 Jul 2021 19:07:20 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DB36C1851D79B for ; Tue, 20 Jul 2021 23:07:18 +0000 (UTC) X-FDA: 78384504156.04.5F01237 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 730FF5001054 for ; Tue, 20 Jul 2021 23:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626822437; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ztgVvJxRpaDFgXRdUSCFV+ku7s6Onq7aqmb9J+83zrg=; b=XTmVbD1kIueT+bIKStqc8zDc+ru76wI/7HgvkKNTobkKdNgVUZaHbUf+8n3D6oidGELDQZ evF+DlvZm9MEQARFj38hW+uyFnmtgoaxBIQ6RlTVLLaK972xfvnPYf1gC14YjRzyQFHNwT 5b3JJr4XhbKTGsqPg/HGxzLF35yK25U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-8IeK1yH4PqCH-JylQYHArw-1; Tue, 20 Jul 2021 19:07:14 -0400 X-MC-Unique: 8IeK1yH4PqCH-JylQYHArw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 08D4818D6A25; Tue, 20 Jul 2021 23:07:13 +0000 (UTC) Received: from [10.64.54.195] (vpn2-54-195.bne.redhat.com [10.64.54.195]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ECAD419C59; Tue, 20 Jul 2021 23:07:10 +0000 (UTC) Reply-To: Gavin Shan Subject: Re: [PATCH 01/12] mm/debug_vm_pgtable: Introduce struct vm_pgtable_debug To: Anshuman Khandual , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, shan.gavin@gmail.com, chuhu@redhat.com References: <20210706061748.161258-1-gshan@redhat.com> <20210706061748.161258-2-gshan@redhat.com> <65dbdc03-dd34-570c-6beb-7497855b5c8e@redhat.com> <1e39cb49-21d8-7114-4ffa-237c6fa19de9@arm.com> From: Gavin Shan Message-ID: Date: Wed, 21 Jul 2021 09:07:26 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <1e39cb49-21d8-7114-4ffa-237c6fa19de9@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 730FF5001054 X-Stat-Signature: w4ecpryrf9p8re4eptwck8akb3qfb8ue Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XTmVbD1k; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf04.hostedemail.com: domain of gshan@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=gshan@redhat.com X-HE-Tag: 1626822438-475708 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Anshuman, On 7/20/21 5:02 PM, Anshuman Khandual wrote: > On 7/19/21 11:09 AM, Gavin Shan wrote: >> On 7/14/21 4:24 PM, Anshuman Khandual wrote: >>> On 7/6/21 11:47 AM, Gavin Shan wrote: >> >> Thanks for your review. I will take all your suggestion if it's applicable. >> Otherwise, I will explain as below. All changes will be included in v2, >> which will be posted pretty soon. > > You revised the series couple of times before I could even respond > here :) Anyways, I will jump to V3 directly and continue reviewing > from there. > Yep. Sorry for the noises. Please review v3 directly. By the way, It seems Andrew start to integrate (v3) series. I personally still hope v3 (or perhaps v4) is going to be merged in 5.14 cycle :) Thanks, Gavin