From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73684C4332F for ; Wed, 1 Nov 2023 12:16:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7D058E0009; Wed, 1 Nov 2023 08:16:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2D1D8D0001; Wed, 1 Nov 2023 08:16:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1B2B8E0009; Wed, 1 Nov 2023 08:16:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 930EB8D0001 for ; Wed, 1 Nov 2023 08:16:48 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6BD80B5ECE for ; Wed, 1 Nov 2023 12:16:48 +0000 (UTC) X-FDA: 81409284096.13.E80802C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 8F9BC4001C for ; Wed, 1 Nov 2023 12:16:46 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DV2DffXq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of mpatocka@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mpatocka@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698841006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a5UIfMBVdGIbdKNzRDMLvhiScyxGbvuh4NifZMx02eQ=; b=OOMkjQ6QPt7DEdYOoVXCGxMD4Ex7wMz8EIIml40S/O18DYLqd4HEbYcpNt4pp42FTtkXEr KHq4oRxdDiIrdcYDDLKvve5zmIXzQn4Ua+WRe12wBK03ef981lrPsN/yT/UdFRrwpFjPKp KC/CBiaX4RGZOjBpb5z5PJG6vVAA3M0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DV2DffXq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of mpatocka@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mpatocka@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698841006; a=rsa-sha256; cv=none; b=Jv9K/GrO27cfYuopZGJAfVT92g1eEy62j8QpRC3CFJ4k+hh4r84sjqkrWK/lUKNK9YvPAa 53BLSb2D6I8hQ3BwJWx4SlMG5T53NNOah38Ew3B5Aka1hKKkX0KFbR8GipKWprS+WhF0+X byz5qAm+bOXsATYTrWIcHnY66OUVq0U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698841005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a5UIfMBVdGIbdKNzRDMLvhiScyxGbvuh4NifZMx02eQ=; b=DV2DffXqywM/IIfx+ILsEqcNp8cxnxnWCEtFTew/QMdcx8i6Gr4abtG4VB2FZdoax9D6DJ wdVnIt6iijy+M0K6kWALTYCQBoHo+peSDIV3OiZ89Gfk2DfxwdQK1ICVUcWUyVK21M2i05 OsMBt0OfD4ompNH/ZprEmF+lmhRZHG4= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-rsj5tSE7PqiyMazlfvH37A-1; Wed, 01 Nov 2023 08:16:40 -0400 X-MC-Unique: rsj5tSE7PqiyMazlfvH37A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1C7E02803022; Wed, 1 Nov 2023 12:16:38 +0000 (UTC) Received: from file1-rdu.file-001.prod.rdu2.dc.redhat.com (unknown [10.11.5.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA5C11121309; Wed, 1 Nov 2023 12:16:37 +0000 (UTC) Received: by file1-rdu.file-001.prod.rdu2.dc.redhat.com (Postfix, from userid 12668) id D85C230C2A86; Wed, 1 Nov 2023 12:16:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by file1-rdu.file-001.prod.rdu2.dc.redhat.com (Postfix) with ESMTP id D3EFE3FB77; Wed, 1 Nov 2023 13:16:37 +0100 (CET) Date: Wed, 1 Nov 2023 13:16:37 +0100 (CET) From: Mikulas Patocka To: Hannes Reinecke cc: Ming Lei , =?ISO-8859-15?Q?Marek_Marczykowski-G=F3recki?= , Jan Kara , Vlastimil Babka , Andrew Morton , Matthew Wilcox , Michal Hocko , stable@vger.kernel.org, regressions@lists.linux.dev, Alasdair Kergon , Mike Snitzer , dm-devel@lists.linux.dev, linux-mm@kvack.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, ming.lei@redhat.com Subject: Re: Intermittent storage (dm-crypt?) freeze - regression 6.4->6.5 In-Reply-To: Message-ID: References: <20231030155603.k3kejytq2e4vnp7z@quack3> <98aefaa9-1ac-a0e4-fb9a-89ded456750@redhat.com> <20231031140136.25bio5wajc5pmdtl@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Rspamd-Queue-Id: 8F9BC4001C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: i4bfiay5it6ew8xm63i3f3z9fre76q4s X-HE-Tag: 1698841006-735405 X-HE-Meta: U2FsdGVkX19Fzvfu/VFwfWL91T+QaJi8/Z29R+/tyRuZ2OqgQ4MMCv2jJ1O4axha730W0O2kIFafY3gRuBVlsmhSEL+Nz2beGLcy2Wy2fayU1yVcIye2HFKIe1R04grNf8Il8zCIEgyQtMy9mvkIjWKIoo2VTPd61arb7gH+/Y3lkkcJY0UmH6uq97VMmzkoF9ifGGqKO6hOUq8EOAfst/+73rXFsbM/KSOF5Og19NT6lQ03Os96HrLwyzOF+DXAeTTaZi7GiInro43FNisoUMmV44nKHBX80us04nsT4DkAfaZfB1PgXTms5ZmMWEURMXOerdjTr2CERlcJ9tcSNjFc7vA52TIOCvYIMcYNU3UJXdoQzizNZPfr3LbBhYc7XyEF8/jj46G/Zed4M3TWah6yBAw4Nvs+vzhr6O7ZHRUr00PtCUbCtKP+pWhZWFQRIDuCFbQc0bR8b6cH0MFouNOUCkAaXvCrcgYpldf3aLec8QsvGuQkS0TYLj2mYtJVm7BY2aCou36janEyiZQDHYQQTC+t8pBhJQ7HCKQv6SToYC8i0N6hoC7ZkC59OPijkgMwQa4964Orhb2Be8k7Ay30mSXsp5ZZufIWyIN94jStQLJppnwT6gqz/TmZsO0Yb65DzAd2yyM3STXfc7/tcJ5ayrdCWyHg7XY/IIYsxtgeaKeurPuUr71WGUW/aaiLeW0oZB9hUIjfekW0L9DOahkACPx7I7jcIVIWRrwK4nK+GV3440ShV1ykAatitrjUOpKHCvo7tK/strsVKd6oBQ3JRh2F9XPZAwcdPXvZTJGaQ5c6qUAEn2rbvjlyM/FNhdKeZzb5NASRYdXcKsoi0/U/Ca/eUrO2pcMXqKhmN3x9FmdlNZfuTMSoafOj+OQ4NDEXxtY5x2062UnUySpaAPEaCQGV7zx5BtEACHjBJe1truL2bCMH4zwb1N94V4RrBmjay+iv1Vdjq3PDVQ4 +w64S043 NKaW8VmxUN16CCjRSBbP/h3f5BsxY8bJajMaGtjyJoXvVNo5gGRBHa2TVjDLLalsWIJqPJOLuMNs9u0idqq/6g6xbr78R7Vy/2ZCrewJLLp6UljCw3IGXur9TftXJ5o5jwFdm3x+DFJ5CkpKxClDYrg9BZqhbelEvl5DWcGIvK1MPhV2JJL2eOceExw30miqvVBPgBjN/nW2Ak4J2f7x0YYKIp4zG6i+2GmNmCjbFuZqmERpTOx283ID15Gl/7iTzP8cSdV9wawmd1Zh1s5G44SzNow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 1 Nov 2023, Hannes Reinecke wrote: > And that is something I've been wondering (for quite some time now): > What _is_ the appropriate error handling for -ENOMEM? > At this time, we assume it to be a retryable error and re-run the queue > in the hope that things will sort itself out. > But if they don't we're stuck. > Can we somehow figure out if we make progress during submission, and (at > least) issue a warning once we detect a stall? The appropriate way is to use mempools. mempool_alloc (with __GFP_DIRECT_RECLAIM) can't ever fail. But some kernel code does GFP_NOIO allocations in the I/O path and the authors hope that they get away with it. Mikulas