From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CF6CC4707C for ; Thu, 11 Jan 2024 03:31:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA7B26B0092; Wed, 10 Jan 2024 22:31:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D57986B0095; Wed, 10 Jan 2024 22:31:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1F466B0096; Wed, 10 Jan 2024 22:31:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B2FF06B0092 for ; Wed, 10 Jan 2024 22:31:26 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 69A2812097B for ; Thu, 11 Jan 2024 03:31:26 +0000 (UTC) X-FDA: 81665604972.15.E473B58 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) by imf12.hostedemail.com (Postfix) with ESMTP id E931440005 for ; Thu, 11 Jan 2024 03:31:22 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sFkAxDeI; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of gang.li@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704943883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K0dgdoE6OzasbBRrKE1GhrUB+ZWb0Jou+J+d3JWPw3A=; b=0SapMxIOYFQdlkVPthN1GLnCzzbUTe5xMFqv6lNijogNPv8VVigROn5tuyDpFi5PRkPJK/ rWrxV2uDPH/3bQ+h+47RtBx8cXh25ZgItIvK5ttsdmOz/1gufASCHbTKdVxfuU4NT9ixVs r5LrZmijrjylAwy2Qx5pbRtuUggL+6k= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sFkAxDeI; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of gang.li@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704943883; a=rsa-sha256; cv=none; b=5ILr0PM7Px5g0Vu8Twv8RehdIKTl7Ee7WYjeAA19tFqv7haisUa+gQ5yBRDUXhfgR4cCC8 k0uEwU1PoU/gwZUYFweUP3n15yfTXUUJq5QF+5P9sjcReL5id5IRwsyyyLfcxxnHRqmGwb dTpDYIcLQy4CjfTl83sZerHrGDKOUpY= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1704943880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K0dgdoE6OzasbBRrKE1GhrUB+ZWb0Jou+J+d3JWPw3A=; b=sFkAxDeItSQnYqjjK7nh77pjlOZPi4bghgbIuwWh+6moNF/AdeGybgkMoLeIUVU57ogIrO xH7JiAyPRSSWZ6GbuIcVnfrsDIHfCmdmRi2Hf//9g6BB5HB71u93xl7MpWbZV3yz4NEsLh n0G5Q0kDJc3ytVFSQsFOdWyTKRFYnhY= Date: Thu, 11 Jan 2024 11:30:52 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v3 1/7] hugetlb: code clean for hugetlb_hstate_alloc_pages Content-Language: en-US To: Muchun Song Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com, David Hildenbrand , David Rientjes , Mike Kravetz , Andrew Morton , Tim Chen References: <20240102131249.76622-1-gang.li@linux.dev> <20240102131249.76622-2-gang.li@linux.dev> <73111be3-3077-4821-8c2f-9c5564cb2bb7@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Gang Li In-Reply-To: <73111be3-3077-4821-8c2f-9c5564cb2bb7@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E931440005 X-Stat-Signature: rsphkbxtw4n8zgzimcbqdmt6xm7edpmg X-HE-Tag: 1704943882-988559 X-HE-Meta: U2FsdGVkX1+MetdmGSFeaO9G6G99FT/R4LNAvA5d7+J53lm09DWAbKAW5X6zOraVu32EEpjlJVG5fjTP1bBDcsAUOF8+mb6FR5YLcHFmxMwOqq6rEBaM443zN8TS8MtHusfHJRyqK7k9PzX2ramVqLmobE4Jk9EtbcGOmj8WoCD9v0YcBPrYO6IDa22dyqSnjAi9pekbyulNFSAo10exeIaPXep35pqoZe6fb4lXC6Wfgx52wR3NBONkJngmRWO1Pe6JDEugTmmt6yfwrsGq/H9mbbGKSyNEx/9pinf5OOO8y2Wk9SHW2dy6MKBTDvO7ex1RZ/GTfzlWEnikkFkoqgJL/fXMZyQ0j5q5BwypybMEeyomZKjfM377E5BYzkqYEEdQhdLkTr/LVnni5zjG3GkLHVawdDZn0YUMpCJj4FO1jJHb+/Dyp95geiaESqF6EvOJfetJcgHN4+H4DBx5tEOUX1WJx9tm/jdJZZAXEZY6hx61dIDBYUspaYwK2b40blJ18SwYKJt58NdofcwypZHj3/kq/xlLnTwtuhc+KEYYlfBjdHkfCaZneD5wrKIVgxCjDuQjh164fOEUkEwZHiBSGWAGDTv6ZoxetFPrT7eOpULDJRpPpUYnx332un36joBAqpGp5gLCtOPQCeTUHRPODdkBYCYnY/W9OmOeOSmME9l2J7z/Id5HOH4R/unllPHrCkXWYN3whIRKCRtYrxlv2g8b5Q1PTb2n4u5M9rM4bQbTArHZ/bw18Uk5suqkBwndjqU0wOMRc+kOlyX9N7bJHEKu45ROZQgx6mHUcqrUFPKqaSTtOxb7fwgN15jRUpyCeDVM1fhbK/E593ISy3OZ7haZ2vlWztofrxRelJyY1OCzhJDbv0mxUACHIR0npj2QjnlV/qubQcv/2hdUsxLZlDKbGjKEL1Z4TxutLmiBh6nTs9rINULSW8BBElskZf6OZvSSNJyMC6Azb5d 2974tUQg O89UrWfe7DrEFBQSx95+oNY9YByignKI3aE6RYCwbKDEu7K/6Bitw4j22W0ZXhy+4TIF7FLcv42EYmPAUQ/u3t7wlYUD3WZLnPTQIc6n6My5Chnmg2SxZ3siDKm+0S5gGPUMmVbQUY+dNSEg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/10 18:19, Muchun Song wrote: > > > On 2024/1/2 21:12, Gang Li wrote: >> The readability of `hugetlb_hstate_alloc_pages` is poor. By cleaning the >> code, its readability can be improved, facilitating future modifications. >> >> This patch extracts two functions to reduce the complexity of >> `hugetlb_hstate_alloc_pages` and has no functional changes. >> >> - hugetlb_hstate_alloc_pages_node_specific() to handle iterates through >>    each online node and performs allocation if necessary. >> - hugetlb_hstate_alloc_pages_report() report error during allocation. >>    And the value of h->max_huge_pages is updated accordingly. >> >> Signed-off-by: Gang Li >> --- >>   mm/hugetlb.c | 46 +++++++++++++++++++++++++++++----------------- >>   1 file changed, 29 insertions(+), 17 deletions(-) >> >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index ed1581b670d42..2606135ec55e6 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -3482,6 +3482,33 @@ static void __init >> hugetlb_hstate_alloc_pages_onenode(struct hstate *h, int nid) >>       h->max_huge_pages_node[nid] = i; >>   } >> +static bool __init hugetlb_hstate_alloc_pages_node_specific(struct >> hstate *h) > > I'd like to rename this to hugetlb_hstate_alloc_pages_specific_nodes. > > Otherwise, LGTM. > > Reviewed-by: Muchun Song > Thanks! I will adjust it in the next version.