From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED744C001B0 for ; Mon, 10 Jul 2023 03:05:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70B9E6B0074; Sun, 9 Jul 2023 23:05:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BC606B0075; Sun, 9 Jul 2023 23:05:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55CBA6B0078; Sun, 9 Jul 2023 23:05:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 469536B0074 for ; Sun, 9 Jul 2023 23:05:16 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 156A81A01AB for ; Mon, 10 Jul 2023 03:05:16 +0000 (UTC) X-FDA: 80994211032.11.A468A5E Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf14.hostedemail.com (Postfix) with ESMTP id 42042100012 for ; Mon, 10 Jul 2023 03:05:12 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=mD83rxRy; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf14.hostedemail.com: domain of sathyanarayanan.kuppuswamy@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=sathyanarayanan.kuppuswamy@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688958313; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WJWu20B7OQxInVF51Ookeob6kyfPzx+3V4l4Wy5Dckg=; b=T4k4B226jKHmbeJDKjKGSbP/8TT0Kiose9coL6aASZpZusxaQW2dY2La6Rfjrfh5BI/2ae t2lAEplIHMYXKkqmEoPTJTAeUzrZVC4UOPeROINbR5kbly4yjTWVtXFu/MUAaoqQb5bhld 3Zqkf+51/c3VVGYIVW7Z1BycnfJU7ZI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=mD83rxRy; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf14.hostedemail.com: domain of sathyanarayanan.kuppuswamy@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=sathyanarayanan.kuppuswamy@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688958313; a=rsa-sha256; cv=none; b=WjNVxQTArtYz6uGYSYPv9RqkF3dIq4vDKCyJt9Z05sDy0lFRvEnevxL/QcwEwKG5NPrbCU MHZJpyCWXWT4Cu2U6Kxox2tobs6+mTaplTvZzfgsw3vvKtcRyVp2mQX2Eq+o0uYTpcgXt8 m4rk7lWXBoPxnm84s+1oQKCi3C/yoxQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688958313; x=1720494313; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=RDmc0GZUWAA3G5ck7OlGOYb7bZsUDXGbc8q2Xk1f4ws=; b=mD83rxRyNiKP2V4esc/zkH8765Ipp/Yw+PZSlMHelW0NOiSzU7mZ2N1d VYbr5uauCHU/WOdn3EeNt+M4t2Qsjl7AyxNqxtB16EJVWc4v9SOQRciYe sjJD2V8tvF5GjLZBd1xcvtswejfR74jgxOI4PwwrqtXj5UawwNmcPIDmq 3OQID25nDRsAhqQxSqqA67DN72wk5CWvhJZk/MARhf2QFUzUXOzcIqJ6t d3V/LUMJnzUc4iWmWqFVa9gOorcFWRgKj+Gb0bjcCyEVMCwrmpRh2OXkk hGnV+gj32Fylg4T1oWPP3uG7k4Ldk6FdezlyC3r1GWY2Imu8Y+rqDutES g==; X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="354103776" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="354103776" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2023 20:05:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="697856804" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="697856804" Received: from krtulig-mobl45.amr.corp.intel.com (HELO [10.212.175.70]) ([10.212.175.70]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2023 20:05:10 -0700 Message-ID: Date: Sun, 9 Jul 2023 20:05:09 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.0 Subject: Re: [PATCH RFC v9 05/51] x86/coco: move CONFIG_HAS_CC_PLATFORM check down into coco/Makefile To: Michael Roth , kvm@vger.kernel.org Cc: linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, "Kirill A . Shutemov" References: <20230612042559.375660-1-michael.roth@amd.com> <20230612042559.375660-6-michael.roth@amd.com> Content-Language: en-US From: Sathyanarayanan Kuppuswamy In-Reply-To: <20230612042559.375660-6-michael.roth@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: sfgs5zxhbjh8fmceq3d36drax78zwqwm X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 42042100012 X-HE-Tag: 1688958312-965306 X-HE-Meta: U2FsdGVkX19iNTETRz1weEDw5cNBd7Mf2w/iC+SqXA33ddwrBVhp2jPaTw5NKLjHS9gDm2B++7t5Kq3AxAxgQEqdcv5UKM2hh6Z3iZX9euReFuR7qHdckNUpS/WTgSpsDtz9gePQMzV4j+9jMjiHNzaq2qvYsYORc3wF+omZnYWlzR12hgmjfvUnq51pc8LX23xt2T190/eLy6oH7FMNiW6rEcbpuJwTd3ZUmk/5jjaXicwNdBDMKHqxyAlQO9JQ7O6poUXTYgWJt9LKnKu3xv+GXSiTXq9n2r2nTpWV0xRNMvA6yLuMSFnupLyf8l55ZM4LpJ23ngjhQeRFDcwvUf4kV9SUVGdqhNSAZM5BD+19Xox6Nk7BA/3qjEfFTiN7Ichv9opg4UBNAv2BRdmPiKZ0A1jMdZ8LEEJHR1gFAYWCQnZjvmU4yGn6yW467w2Bnz7wiVU832byA9PTgbX+mBfpS1VATKQh6O9BwVA4q0k4IplPNi8tLtvYF/uL+Dr9+J73iVFUqnjBYnExDZDjwZYRFllcrJ8qGJ6NVZpuELLXaA4h1Pme0Ht5oOJk7Ah/7zfSCr7QcIB1l9k4RUUDCJvmzTV3AtiHFsDOtLerQZaoHwjD0RcUUbwIx8vAPnlXwlRpz2iHcXdG2YgoKYoSrwzDa725hEKwWfUcCXNkt/vl2uH9zKOhjAnw2mXcF5ogSF+u3yCk0yJTB05hjYQoSixwvCynnPUTGikPt8xyxJoDYENsHbljGwnyBvmfv0icAtktPRQsDXbBDxTYGGGXv2qaBln91zvRX/qAo/cbAHL9OC6BA/K617vrFYV6B88+dqABiwtQfHLCWyPRDmEeP6POhxtJsbM8krJ1Z2LOt20Bu+sj39rkVYexo/qOMTPErJZvn1UPH0k3oEaJCsqW/OQ+HtFhcSdxTU2i01SQHBRl41fTDTqrKeHWDtdic47M+1akLoSNedvShz0E983 5QOGObu0 93gftjwvgW2D6ftwGlEnMm1CIdQjvI2jszeQ5/+WcDKBhoasq/vOdjFCkLRVgdvg4Z4UYV5qe70S75lYZ2k8fJaXM5eX1X76gZ7A2Bdnk0IypV+hpgOtZ9BKsAIyrCNVnjyD0bAeKOnL6gjPlYOq1ufBFCdHenqc1pOVrv7qA4XMbdZEG9KiKtMIkBQKwRpwMxzAJ1ufbaUmVzmxMxoO7INBkOYz4/0Lasjne X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 6/11/23 9:25 PM, Michael Roth wrote: > Currently CONFIG_HAS_CC_PLATFORM is a prereq for building anything in > arch/x86/coco, but that is generally only applicable for guest support.> > For SEV-SNP, helpers related purely to host support will also live in > arch/x86/coco. To allow for CoCo-related host support code in > arch/x86/coco, move that check down into the Makefile and check for it > specifically when needed. I think CONFIG_HAS_CC_PLATFORM is not meant to be guest specific (otherwise, we could have named it CONFIG_HAS_CC_GUEST). Will it create any issue if we enable it in host? > > Cc: Kirill A. Shutemov > Suggested-by: Tom Lendacky > Signed-off-by: Michael Roth > --- > arch/x86/Kbuild | 2 +- > arch/x86/coco/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/Kbuild b/arch/x86/Kbuild > index 5a83da703e87..1889cef48b58 100644 > --- a/arch/x86/Kbuild > +++ b/arch/x86/Kbuild > @@ -1,5 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > -obj-$(CONFIG_ARCH_HAS_CC_PLATFORM) += coco/ > +obj-y += coco/ > > obj-y += entry/ > > diff --git a/arch/x86/coco/Makefile b/arch/x86/coco/Makefile > index c816acf78b6a..6aa52e719bf5 100644 > --- a/arch/x86/coco/Makefile > +++ b/arch/x86/coco/Makefile > @@ -3,6 +3,6 @@ CFLAGS_REMOVE_core.o = -pg > KASAN_SANITIZE_core.o := n > CFLAGS_core.o += -fno-stack-protector > > -obj-y += core.o > +obj-$(CONFIG_ARCH_HAS_CC_PLATFORM) += core.o > > obj-$(CONFIG_INTEL_TDX_GUEST) += tdx/ -- Sathyanarayanan Kuppuswamy Linux Kernel Developer