From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F863C433EF for ; Wed, 15 Jun 2022 06:06:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CC536B0071; Wed, 15 Jun 2022 02:06:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97B8A6B0072; Wed, 15 Jun 2022 02:06:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 843036B0073; Wed, 15 Jun 2022 02:06:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 74B7A6B0071 for ; Wed, 15 Jun 2022 02:06:25 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1ED822149C for ; Wed, 15 Jun 2022 06:06:25 +0000 (UTC) X-FDA: 79579435530.01.FCB30C1 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf08.hostedemail.com (Postfix) with ESMTP id 7495B160080 for ; Wed, 15 Jun 2022 06:06:23 +0000 (UTC) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LNFBF3SXlzgZMG; Wed, 15 Jun 2022 14:04:21 +0800 (CST) Received: from kwepemm600016.china.huawei.com (7.193.23.20) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 15 Jun 2022 14:06:19 +0800 Received: from [10.174.177.130] (10.174.177.130) by kwepemm600016.china.huawei.com (7.193.23.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 15 Jun 2022 14:06:18 +0800 Subject: Re: Re: [PATCH] mm/swapfile: release swap info when swap device is unpluged To: Andrew Morton CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "ying.huang@intel.com" , "willy@infradead.org" , "vbabka@suse.cz" , "surenb@google.com" , "peterx@redhat.com" , "neilb@suse.de" , "naoya.horiguchi@nec.com" , "minchan@kernel.org" , linmiaohe , Louhongxiang , linfeilong References: <20220528084941.28391-1-liubo254@huawei.com> <80d54ab2864e4011a9f5e5b198ccfe8e@huawei.com> <20220613144651.8f54b3da0c2e013d9db89f02@linux-foundation.org> From: "liubo (AW)" Message-ID: Date: Wed, 15 Jun 2022 14:06:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20220613144651.8f54b3da0c2e013d9db89f02@linux-foundation.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.130] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600016.china.huawei.com (7.193.23.20) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655273184; a=rsa-sha256; cv=none; b=WUvidmlbo0lv8ejdqTbES3EbFA0z+n02wp8r4jhSPG06Gr5VsaOWq0z/NhmK5YfIkc7a/9 wgychtTA6cZ0dAzds9PDthN+bI7UzpgcKVJKL4+kyFEc333ngOW6eJTvnN7vp9FjqidLB/ +1/92ZB7DlG0752EIVb5SjqoCegjlCo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655273184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9B66X1j5DZ6frQLBHQxtBaXwZqA4Wot2np2Bv0q5SGw=; b=RZN/GZtBGWBIh37jiJEtgWrMPnWWpZoPIlj614Uc+f41SdTZnRbL8IOHXoZLi1+gDkOB+J jsg0CYD5KuG/jsZ8Iex9MGryZPpl1fYW5q9i6vpRnG6AS/Ig2NbegX3/qnRqIQCLLco57p tcDYgV+TiX3XW0LFvikRufMp1Dae3uM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of liubo254@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=liubo254@huawei.com Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of liubo254@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=liubo254@huawei.com X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7495B160080 X-Stat-Signature: kfggeb9ncgqiw8ezq7cdxewcqjt5ioci X-HE-Tag: 1655273183-191099 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/14 5:46, Andrew Morton wrote: > On Mon, 30 May 2022 13:00:24 +0000 "liubo (AW)" wrote: > >> friendly ping. > I was hoping that someone might weigh in and review this, but no joy. > > The patch does quite a large amount of code movement, which makes it > quite hard to review - to see what functionally changed. Is it possible to turn > this into a two patch series? The first does the code movement with no > functional changes and the second is the actual fix? Thanks a lot for your comments, We'll do it in the next version.