From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACE8AC83F34 for ; Thu, 17 Jul 2025 20:14:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F49C6B00E8; Thu, 17 Jul 2025 16:14:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A40C6B00E9; Thu, 17 Jul 2025 16:14:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 171996B00EB; Thu, 17 Jul 2025 16:14:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 045916B00E8 for ; Thu, 17 Jul 2025 16:14:43 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 679FF1A020F for ; Thu, 17 Jul 2025 20:14:42 +0000 (UTC) X-FDA: 83674859604.30.B79FA31 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id EEF121C000E for ; Thu, 17 Jul 2025 20:14:39 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CDRwIJK8; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752783280; a=rsa-sha256; cv=none; b=CcNpxopvuZtjBMhY8mAMgJWZmi33GI8LRkv8ntabJZUYpRcWnGIUhEUlgOJZQ5TJ5n9Etz ZfJloEIApYg1A3Hj9zT1K45ZcMYNLHecmn3SxqNx/FLS5hgLzYSDIItTSwXKJQKDrIwqYO DjduSi1deLwlI8NoifSe7Mn0wVdsHhE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CDRwIJK8; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752783280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QlYYu3k/BYRc6Kiix2dPUNypQutbN2D0tRZWGefeAe0=; b=vONi9eumQkUqlJLsovYXrw4NYNMqGhnxtCcTjgkp76pNDZ/YUhk7JFUPF03pi1RaSAMAV8 kXSQ+FPoxclNbBbkkgarnZUp9ITUA7LcKPl6vq4EmvFWU9+s20GG4fZMu/QpsdNdYUK5Xu GDho09smTCEQp66NUH/J1mC3a1QWXdA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752783279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QlYYu3k/BYRc6Kiix2dPUNypQutbN2D0tRZWGefeAe0=; b=CDRwIJK8ExvupyRFOJgHsDXJRunhlV05GKSz7HULnosxB+9rqwzsjvGxr2RvKJHGdQS4Lj sbsktbcG/mGlT5EkD4O8AL98s/SOnicQDlye42V6o/wXyDSRSBtrxUJuPpKojq3bIGjrAi wxve42Lpe1Ve8SnJc5Qy5i8Ms9ok98A= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-55-sB5G4eVpP96e-stxCA7g4w-1; Thu, 17 Jul 2025 16:14:37 -0400 X-MC-Unique: sB5G4eVpP96e-stxCA7g4w-1 X-Mimecast-MFC-AGG-ID: sB5G4eVpP96e-stxCA7g4w_1752783276 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a50049f8eeso703552f8f.3 for ; Thu, 17 Jul 2025 13:14:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752783276; x=1753388076; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=QlYYu3k/BYRc6Kiix2dPUNypQutbN2D0tRZWGefeAe0=; b=cl8GVKTp5Ylb9gi011Q2Sws41OSm0wPq+LoCxKGKKVQ0tMNBbREQs/UeCFOaw/y3oj q1i2aMgxdaCFkp/99owDJ6UJQjPKavc5+GzVp6m+MpOtkyuTD77+ZAj1XJ1ccqv7ty8l 9ZdO+pnkLzODOTl/gnofovcR6N01IBAGpda/Q/mw+TZ7oGsFvaTWiTIW3SXbj66+8ac7 rc/aZmjwEQ6Rj6uMUmveFfBm2GSY7jt3nBrngqlHGHziICBWBobCexaB2M7Q93eaUWVh i6U6LIIs5Lz6mEznbGsObem8/eS3LnOHHpsxZjrUKhE++JFUiWqkwBszJi0RvCqAejJG FcfA== X-Forwarded-Encrypted: i=1; AJvYcCVRqlF9pxGaYrq6+RAiDnrouMzgWltfbjrW2Vy0YYl04UuXTSGXlds/goW/iOn8wsvngkaYoCUoQQ==@kvack.org X-Gm-Message-State: AOJu0YwZzQONgCTMMufpTXeCMzI8cP53JKMufV1CekJDQyHZwHBatpfB 0SpALWxCrCAoekZPvwTa9/52xrxepc6NKQonvWgMgHA6cHBnpjW4ifPmct7yHaRD+ygzmSVO66F vgWsJyQ119a8+TNMvkXm/elyNms6WLExxVOnD3IY3bvLcIaA1h/lq X-Gm-Gg: ASbGncuDbIGoXR7QDZaHqmZ3VZeShFvm6t13AkfZeQcgACfv4QduUw6FrY6I0WSGZRi BGuEh8NEmx6f60e07HEZMns2K/46IouyBWIYmyagkyQJbmOF5x8bi8x5i4XIkgKlAv3TrpuzypM ndWZu+3PT8Vl40X3fL9k6EP7ONXiHAhl+gNYw+yB6tR/whSbMXwVM96PH56uiXPwZuzqJ7ZM9Oy XDKmNZNTEzcd5v6xlZQ3SNnPPeuk8xOmVooWnMMg0WpsZibhmtjRsik0fJTIkg8eRo0c870mcUo m89Fv72EdNevQG4pKgqx7v3V5hhDI9kYrp5OiXyc4a/EoRrxtdJtlpagpQ3klx5GOJv/4n8B2mb Mok7GtpRqK05r5gDNFXCH9leM17btjJfQvQpBxlDbT7n2CSs2tzjl7VZA8+yuLkvs X-Received: by 2002:a05:6000:992:b0:3a4:f663:acb9 with SMTP id ffacd0b85a97d-3b61b0ec0dbmr197225f8f.9.1752783276430; Thu, 17 Jul 2025 13:14:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEXZyoKOBqIpYS/jO2KmsvWvIMoN9zXhccC8DWWsod9nvdf0NNHfT+L/AueK3GG0g1XLIDWaQ== X-Received: by 2002:a05:6000:992:b0:3a4:f663:acb9 with SMTP id ffacd0b85a97d-3b61b0ec0dbmr197194f8f.9.1752783275956; Thu, 17 Jul 2025 13:14:35 -0700 (PDT) Received: from ?IPV6:2003:d8:2f35:2b00:b1a5:704a:6a0c:9ae? (p200300d82f352b00b1a5704a6a0c09ae.dip0.t-ipconnect.de. [2003:d8:2f35:2b00:b1a5:704a:6a0c:9ae]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4562e8026e4sm59374615e9.11.2025.07.17.13.14.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 13:14:35 -0700 (PDT) Message-ID: Date: Thu, 17 Jul 2025 22:14:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 8/9] mm: introduce and use vm_normal_page_pud() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Jann Horn , Pedro Falcato , Hugh Dickins , Oscar Salvador , Lance Yang References: <20250717115212.1825089-1-david@redhat.com> <20250717115212.1825089-9-david@redhat.com> <4750f39e-279b-4806-9eee-73f9fcc58187@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <4750f39e-279b-4806-9eee-73f9fcc58187@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cP1-ozsKJzm1innOBQvjY4MXOkwFaCOkQEYA5HJnk0Y_1752783276 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: xk8xq1w6nnih8naofoigrimikn7mybp1 X-Rspam-User: X-Rspamd-Queue-Id: EEF121C000E X-Rspamd-Server: rspam02 X-HE-Tag: 1752783279-409532 X-HE-Meta: U2FsdGVkX1+NpB13kuD9UL2Ho4BG+IsmayigKJUfGMLsPsXBIp1/EvVTT5vFFhxiYIxFruiBWfRr8b8wG1sGXhQte5ypLXTcLpYM4lZHmkSzrEnr3bn+Poxi0oTQ/86+Nh5d5gy0/tk1Ljl6StpUmHr7g9qRgpzu0EkF1FqKJ3OfwUOYUaSvqFcamRs1KdkinejYZ2lNrDqj3ltz8u2nXff2VsfK1lfMTintFlSmGJ9aMrCnptVWGP9BcjuOb4/11Kp3CSFB/9EVAx/VSAvckBrhCHlxG0HwwU6XbsYwchO2xlw4ve1nziB8YWpr9Qrb5YL56VUzbMVe6YdBTK/edrQnkOE+vgEHvwfFuLHrxkSi5IwMb6YfYi1DysNDpE7qH2axf3TiN8lQOW264Gcbnl8BTjS+yAE0/FnOP5YQ+4fUhQkha/SJMuH2d5r5TDOEREimqUxAu6XrjR1+9nVQGL+RYNYFtXqyCrTVAf18/P68Tk5afCe9xVWIEt77vHHAtKE5TIrrFj5NlxE4V0awphBWiQccQ/Z6AslXXNackCJRhDQD/htZ2rGLhd1tDIB4v7w5M5/12O91m1OiDq4Zdl4vHC5DuBhSWhxtNGnekAmSSXVHk+7I0nHz7JomD8H/dcV7ke8mFZq1PWBO7Hv5j3R6m854qZO/NZipmmYiPUREv+1pFwpjnHGr/KHPxAhy5yCbvBlKcaCJwKkGqoV8PdGQeG3RVongHnCIW8PxmQsr/5Hh6T316PAST5Am7iD88swabemHJ4Z6EYfm+cQy4JWoh2QDCVy3zp3/GiX0ryETxxPrayEaKMkwh3CCy8b/H5dQYCq6PWnUU5mHn96i4bOS3tIJWMidT1gGhRH3N0hdAkvitMKUE14hGI49JzKNqahvp4/46N4kFuUPrCYVOyVS9AdcgsLmzWpNCI0f63K/H92x85t4+CmbCKIU7fCJ2IFB7tmNCN86juDM+qR VV31MihN Gc0Z6ZrbYgLND+rRoHeMD6JkhcrzflEhv0LZ2eskXoGbleYiVDklTI1DV88Cv/ZdZf0TTP8yGzpf66ILsNoKHqf7azMUYr4IVrX2KwLQQ0ek1/iMQrgabwwieFriL8w6u9g5+p7iHZBvaf3OnKYHh8Cy43fjWlNwQGcL32UNGQ7zaDMG6Vf2HCzfk2j5ZdnqFIxYNlPIdP3S9dZD0f1yt/teDIXVUjtakMPs3VZGfm/i5PxGhYEY3kQ1Ioqm/o+xJq4bS2NJgSV4a5NyM5mLzDhxS0+P+m8oArkE4Bgja6DETUyc7/SJGaA+szuB1/nu/0nDY70dirkvuzz8xasBLUc/oFtICx1soIk6RTzsPlnGOg8wh94UJxzMh2zNeZSGUyCWAFSK5tlTHfewwx7iJYJVVB//S6WUA3P12miIlnqa5fg44h6u12FJiMIMvIXCjfVXNAQXV8GiKwOTanmaByowvDww8Ys7QhqHzmj7TmaOmfLoZYUvqJPd6WaxvJokI3pAG6DuH3syCDxs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.07.25 22:03, Lorenzo Stoakes wrote: > On Thu, Jul 17, 2025 at 01:52:11PM +0200, David Hildenbrand wrote: >> Let's introduce vm_normal_page_pud(), which ends up being fairly simple >> because of our new common helpers and there not being a PUD-sized zero >> folio. >> >> Use vm_normal_page_pud() in folio_walk_start() to resolve a TODO, >> structuring the code like the other (pmd/pte) cases. Defer >> introducing vm_normal_folio_pud() until really used. > > I mean fine :P but does anybody really use this? This is a unified PFN walker (!hugetlb + hugetlb), so you can easily run into hugetlb PUDs, DAX PUDs and huge pfnmap (vfio) PUDs :) -- Cheers, David / dhildenb