From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Jiangshan Yi <yijiangshan@kylinos.cn>,
akpm@linux-foundation.org, shuah@kernel.org
Cc: ljs@kernel.org, liam@infradead.org, vbabka@kernel.org,
rppt@kernel.org, surenb@google.com, mhocko@suse.com,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, 13667453960@163.com
Subject: Re: [PATCH] selftests/mm: make libnuma-dependent tests optional
Date: Thu, 30 Jul 2026 16:43:12 +0200 [thread overview]
Message-ID: <fdfdf7ac-8ef5-457a-ad9e-c92f6df33ab1@kernel.org> (raw)
In-Reply-To: <20260730142722.874189-1-yijiangshan@kylinos.cn>
On 7/30/26 16:27, Jiangshan Yi wrote:
> The mm selftests Makefile unconditionally builds three test binaries
> that depend on libnuma (migration, ksm_tests, rmap). When libnuma-dev
> is not installed, the build fails with a hard error, inconsistent with
> how the optional liburing dependency is already handled via
> check_config.sh.
>
> These three tests hard-depend on libnuma at both compile time
> (#include <numa.h>) and link time (-lnuma), confirmed by grepping all
> .c files under tools/testing/selftests/mm/ for numa.h/numaif.h, which
> matches exactly ksm_tests.c, migration.c, and rmap.c.
Hi!
IIRC, liburing was not universally easily available when we added these changes.
libnuma is fairly old. (I might have added that :) )
So why should we bother about setups that don't just want to install libnuma +
headers? The real motivation is lacking.
--
Cheers,
David
next prev parent reply other threads:[~2026-07-30 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 14:27 [PATCH] selftests/mm: make libnuma-dependent tests optional Jiangshan Yi
2026-07-30 14:43 ` David Hildenbrand (Arm) [this message]
2026-07-30 15:33 ` Jiangshan Yi
2026-07-30 16:52 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdfdf7ac-8ef5-457a-ad9e-c92f6df33ab1@kernel.org \
--to=david@kernel.org \
--cc=13667453960@163.com \
--cc=akpm@linux-foundation.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=yijiangshan@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox