From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DF5DC3DA59 for ; Tue, 16 Jul 2024 10:47:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E71A46B0085; Tue, 16 Jul 2024 06:47:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E21786B0088; Tue, 16 Jul 2024 06:47:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D104A6B0089; Tue, 16 Jul 2024 06:47:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B251B6B0085 for ; Tue, 16 Jul 2024 06:47:29 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 28E96804C1 for ; Tue, 16 Jul 2024 10:47:29 +0000 (UTC) X-FDA: 82345289418.29.206ABC6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 63F5540018 for ; Tue, 16 Jul 2024 10:47:27 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721126828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GKEMtOKAMOqkQyw6LoD35DB+4DOL/h7VsxJ3h+utSBE=; b=kkvDEl0uUpb/o8RZUDDl4izNP2mqVY1jbu8l1KVC1se7Gz4GwRWC8o0be/cqyAeuvI81QD EshNDJja0tgslLeKFkhodQlnMdr0/e8q965ylZmovqMwRoKVlK9BtIS+Hr7l2nwkooKRGy dpdgKpwAC7iLFpDmvzBcLMTDZWZYiPs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721126828; a=rsa-sha256; cv=none; b=hAEXkgL34C9rPE+yFFBBi67UZ3azQ3/JsAY8aYtrIZYGRViCGcqgLzByZoYrOSha4lLydr XuIOxxFk8y5vdk3jcn5tSLTnwoiPI7VaDCsGzvsy1H2BX0y47A/0LKpVaN4BwuZzzG9Ldv V+GLXbVxsGsovpPy1/x/yH4Vlbe1vPM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E3E6B1063; Tue, 16 Jul 2024 03:47:51 -0700 (PDT) Received: from [10.163.52.225] (unknown [10.163.52.225]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9F1E83F762; Tue, 16 Jul 2024 03:47:16 -0700 (PDT) Message-ID: Date: Tue, 16 Jul 2024 16:17:12 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 19/29] arm64: enable PKEY support for CPUs with S1POE To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-20-joey.gouly@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20240503130147.1154804-20-joey.gouly@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 63F5540018 X-Stat-Signature: jhg1n4f1oagfucm8zz883ctfosan9ymd X-HE-Tag: 1721126847-526070 X-HE-Meta: U2FsdGVkX1/mqL3XF0i9Rt8LCJPaQPd61xXrcTWljrSExfkd4a0N5N+9vu2/dwfclf968+sjgXKz8AOdm+cErnetFmgWtQgq/8GgBkMzjZa+jNDxTcx9aagKt9y8wwMeOOmoTZiLGyOuosUNuJMh2wG4XTh0I2DX23lURIZo+pLAqQ7FoiFvS5fkl008ydWu0umB+ZiwyywxKyLAnJ8lwom+q6I2L7HV4ac95TwDLbpgiLjF5pHwA4hc9wEPVW5/kfoQVH0AkXWGbqa13BFBHWkxaCMU4usXkGEFr/Wu3ML24xzEcylT0PchhFOpX1yIvglEaHl48aGBeIs/IQucia0D75Xe7+8QRuuJ1ulz0bk8rrIufgHhnuwl5NoU9YFPtpk+IwA7M0i27ff8malh8chsw07kupNJLw2rsX7rizKxEPP4enPmC0/16qmCyJAm76/AdY9H869XK0GyuyU7yyUFpG7Z1mSZILS5H2lXQwvKEJZsgubKMlyMJEXJZk6EA5pH+qm5CINkrcbdmD5HxxXE+fyakY/lougbTRdKDlEXn2n5NsYI11KvasYQoePXK5hPZTc4Cgm3cYsaZSQyndsI52ZTzecuRt5Bb2hV1kcohoQw2RxJGExGMUTN5ZcMLAOr7k9n152k7P5cf5sdN0FWNZL5fmxuf8l+essCUdfynUg4/itkOpD3uHrVHr8RD4TK/VbZ/CnUoIiEwhSpDBsrqLtr4luzrPbwp9miaPpg/dbJRP/aDuWmfaiyhTmXn+hRSYpz2B6MoEk/cyFu4Wa043QHvkMo35Iy/FfMmw6XMxXZlizJCLrJ9rLtTDwQZ005hakgFh2LiuqUzm9S5XsxYQl1uV9mfONQGQ7YiHkC9ZNxuMuS/G3i+5cYpMKNbEYVfzdrBCGVpvFqr9ZOj2ST5nVaK4LDRy046MyAOTsr5O1RBwc6II3mjVNBXGnDUOiaeOkM5WivSLR2pq6 4eYYRAL6 yrcBRNelWUp5EiMlkzYt33VQjjg0q/nP9yWuvL0DNzQaCZ3S1LKYEgi6Be+pqs0esu3t0+wPn+lCg0uRuRiJP/PBSlayZCwTQnZXJQh7lU8kn90Hn5jzJJtY1AECrbCuYE7Sbs4fJRQGsjmtXDEI4UEh9OEOrud0kVUgrTArgyqTkcT+UXxJwB79+h+6YRtfkJB+6RivJZBPY9TmTym6HpybV8xLlMBjYfA2jQ3+hr9oL1Fg9w2OVxoDZB4mkzglH0UeXA1KVYbnXsQc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/3/24 18:31, Joey Gouly wrote: > Now that PKEYs support has been implemented, enable it for CPUs that > support S1POE. > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon > Acked-by: Catalin Marinas Reviewed-by: Anshuman Khandual > --- > arch/arm64/include/asm/pkeys.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/pkeys.h b/arch/arm64/include/asm/pkeys.h > index a284508a4d02..3ea928ec94c0 100644 > --- a/arch/arm64/include/asm/pkeys.h > +++ b/arch/arm64/include/asm/pkeys.h > @@ -17,7 +17,7 @@ int arch_set_user_pkey_access(struct task_struct *tsk, int pkey, > > static inline bool arch_pkeys_enabled(void) > { > - return false; > + return system_supports_poe(); > } > > static inline int vma_pkey(struct vm_area_struct *vma) Small nit. Would it better to be consistently using system_supports_poe() helper rather than arch_pkeys_enabled() inside arch/arm64/ platform code like - during POE fault handling i.e inside fault_from_pkey().