From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4774CC43334 for ; Sun, 5 Jun 2022 09:48:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51C588D0002; Sun, 5 Jun 2022 05:48:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A4888D0001; Sun, 5 Jun 2022 05:48:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 343538D0002; Sun, 5 Jun 2022 05:48:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 24D878D0001 for ; Sun, 5 Jun 2022 05:48:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id E0F07120212 for ; Sun, 5 Jun 2022 09:48:45 +0000 (UTC) X-FDA: 79543707810.02.90B6AB5 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id ED68340005 for ; Sun, 5 Jun 2022 09:48:35 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1AB5DD6E; Sun, 5 Jun 2022 02:48:44 -0700 (PDT) Received: from [10.163.37.253] (unknown [10.163.37.253]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 241D53F73D; Sun, 5 Jun 2022 02:48:35 -0700 (PDT) Message-ID: Date: Sun, 5 Jun 2022 15:18:35 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 6/6] openrisc/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT Content-Language: en-US To: Stafford Horne Cc: linux-mm@kvack.org, Catalin Marinas , Will Deacon , Michael Ellerman , Paul Mackerras , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Heiko Carstens , Vasily Gorbik , Thomas Bogendoerfer , Geert Uytterhoeven , Dinh Nguyen , Jonas Bonn , Andrew Morton , x86@kernel.org, openrisc@lists.librecores.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220603101411.488970-1-anshuman.khandual@arm.com> <20220603101411.488970-7-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: ED68340005 X-Stat-Signature: mc9enaax1tqmnsadmwy1xeqrnfsap7kj Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com X-HE-Tag: 1654422515-293469 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000059, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/5/22 11:37, Stafford Horne wrote: > On Fri, Jun 03, 2022 at 03:44:11PM +0530, Anshuman Khandual wrote: >> This defines and exports a platform specific custom vm_get_page_prot() via >> subscribing ARCH_HAS_VM_GET_PAGE_PROT. Subsequently all __SXXX and __PXXX >> macros can be dropped which are no longer needed. >> >> Cc: Jonas Bonn >> Cc: openrisc@lists.librecores.org >> Cc: linux-kernel@vger.kernel.org >> Acked-by: Stafford Horne >> Signed-off-by: Anshuman Khandual > > Is it possible to retract my Acked-by? I was following the discussion of this > new function actually being sub optimal. So as far as I am concerned all these > architecture patches should be nak'ed. Sure, alright. I am planning to redo these arch patches via making the protection_map[] array private to the platforms but possibly with a common look up function as Christophe had suggested earlier.