From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45520C636CD for ; Fri, 10 Feb 2023 03:26:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EF2A6B00DC; Thu, 9 Feb 2023 22:26:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 478246B00DD; Thu, 9 Feb 2023 22:26:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 318B36B00DE; Thu, 9 Feb 2023 22:26:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1D9F76B00DC for ; Thu, 9 Feb 2023 22:26:52 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DC0F4141265 for ; Fri, 10 Feb 2023 03:26:51 +0000 (UTC) X-FDA: 80449945422.28.A250D95 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id C875F1A0011 for ; Fri, 10 Feb 2023 03:26:48 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sCYgBida; spf=none (imf19.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675999610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rs1WJ//qF+XQHelWy/YwIQj2eaAlZxwFXDpZlnE8jIM=; b=t1jZr2EZXzMCV4EqcucqvIVbzezz8Cg4sRAhMzxJoTcBnbRVjB46VZsX8KkzQPsvxiRjAg NCzUca9i9AfvTV19K2e1CI7HPqPLd2esU6W9gAP1QBHFDCrfWr7x5AjQssUsZKqJTKeFBj tf51DtT3HYH44J8isRxL937LWPCSskA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sCYgBida; spf=none (imf19.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675999610; a=rsa-sha256; cv=none; b=YTePFgxDYN/3Y8URtdUb/MbVMGEWJK6xeK069ZXzVwQBLdU0xNm/FeUNesHVFrsp/0BQzh HlR/Dc5GdaA2P42L4NnQ4rM+Vs/wPxnt6peoeX+KQ46heTxkghaQzIx/eEnQU3316OJT5Z pXBCXyKKrAnLOcYaF7Hp0O57MsKwAV8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=rs1WJ//qF+XQHelWy/YwIQj2eaAlZxwFXDpZlnE8jIM=; b=sCYgBidaqOCxWEOCsPRVPWZ4L1 eKkyj1gik1qBri7xQZFfvZHeyWD+oN03Een6dB+Jhfa6rkvSWB1gFPIAatkKbZHZpGlMtBLdk4B9w +gevYCBMOmwwR0x1KV+17+KWLOQ8reFaE6MpG7jOBDmB80ElTfU/buQ1uMyEDZizEJVs2VHpziUC9 EuYvPzwR7u5RdY90W5aI1/652YiHezU/E5rjlOTLy4fmFNYti8/ucs6JqeAM3hDgd3OrUKaHewscb FRe/+wLvmhJkhj41p9YTv6wtEPPWKnU4hWfItyy5uuQsW7LGdidOOTC5N2T0RaxqVBAhSJhf8gB8Q q/Ou8bsw==; Received: from [2601:1c2:980:9ec0::df2f] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQK3g-0045To-Gf; Fri, 10 Feb 2023 03:26:44 +0000 Message-ID: Date: Thu, 9 Feb 2023 19:26:43 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 3/3] mm/damon/dbgfs: print DAMON debugfs interface deprecation message Content-Language: en-US To: SeongJae Park , Andrew Morton Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230209192009.7885-1-sj@kernel.org> <20230209192009.7885-4-sj@kernel.org> From: Randy Dunlap In-Reply-To: <20230209192009.7885-4-sj@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: tpsn5tx8sxdx8wik1h5igyqxf77st6ni X-Rspamd-Queue-Id: C875F1A0011 X-HE-Tag: 1675999608-594787 X-HE-Meta: U2FsdGVkX1+U1vK7xNmJ1qI4eBg114YKsHnYyo0CIgbcCA9aGRyoX5wVrhboL/nNhqdh24+vjSRAWAqazbt3w369QboGAEOUBrT4o+wDgaMyhv8hvdS4gGj/eb2Mptqx95xtUcxQ/Ng3Eee4OS6ShonOcQRb9y7dwafRsoSNsTM1m3gq2P6CQusHg2I7VDetqGGnoW8BEQluyhj03JOQVtsrAZLkpYb3pLp3HhnakzuX+Aji/Id9/Y577mx/NdQfRydH+a+2EgMXLgxGS5RJvOYkRk838pxWH59V6c+VMVmCvs3zEkU0nHxuSAGwu1gIWkc97BbWWPKxaI7qKEug0w+EM6W4L8Ceyg4ho2a3wbkS/mBxPbVG9OF+AvbS6vOmA997maa8s7CwVKTt+Tjb+yNwiNXR2Jl6ii0oq1vm0D6WhpTuqK/meNNxTsr9Wlkkdy8mzYdpV9ybnOo7WcuOI24Ln4QCTVoWK9j/jcg/Y40Fb1WxGhK/i8fH3oHJlPcjfRnN7YbJK99FWRBAAv1g7KruajjUqJWMbxZ2rEWVsa+XzjwKNVI85g4fQ/9OLZbZ1e6EMfChzzXqxL1lpssCccjGxDIIIRMNBxBszCahDO3z386S63gfGBhJ/08/6V16Uw7rtx1KagC3PliXaadklowAthD2Hr/pKsczodd9/wuHdrSAozxkMnPDKR/PKhIV+Tp8wI661tEmqSimb/J8lzz9/pbhGYrTp/uNtR6kixU55KOFqHjRpXAjUDjUqeDg7gwvbBGwQyV9luPuKODDwTUAhD/DwuYJC8KsAE6vlK47dsX47UqIQbF6UZ3/lOsHD3in0EbT4xH24OvF95wDe92Mm8up6R2Dyt1zVbtfsCnB2vrZ/Y7DVZ02El4POHaKy6fxSaprhy4HWWXSS0s+/oLyTOtN+/mrkwbLiRsI0MpeWXmuleZWSTN7lvtkul6wlShY1hK0PL1bfkLdVfp qf98/0Si K2MBkrWskit/TjZ1JheQSp52samcDy2/cZO4qwswqAt5FKKr8/wBNzwvZUhwX7LoIG1C5WbxDJYK0gCpRH7r8Jp9V1Eh17RkmZWdhxiTvUejYXx3ierkcfHrxaWVgKhM88j0ovmH0KRMDs8Ex74Rh4YGFD+NPCTvdTgQZUdXzq9PYcGABWkEjlLhe36CoNjhlezmvCP9k9UU7f+5UD3HJCaJX28tcUeia3KMbwvxxawTeVeUXNNTP/9MDcIcZBEQOsK1RzDWRLkZExp8MGCswX3LCktiP+BwtazWfrnjjbkgnVQqhORhATeWiTABRI3ZRFfJCOUViSnNZegw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 2/9/23 11:20, SeongJae Park wrote: > DAMON debugfs interface has announced to be deprecated after >v5.15 LTS > kernel is released. And, v6.1.y has announced to be an LTS[1]. > > Though the announcement was there for a while, some people might not > noticed that so far. Also, some users could depend on it and have > problems at movng to the alternative (DAMON sysfs interface). > > For such cases, warn DAMON debugfs interface deprecation with contacts > to ask helps when any DAMON debugfs interface file is opened. > > [1] https://git.kernel.org/pub/scm/docs/kernel/website.git/commit/?id=332e9121320bc7461b2d3a79665caf153e51732c > > Signed-off-by: SeongJae Park > --- > mm/damon/dbgfs.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c > index b3f454a5c682..e551a20b35e3 100644 > --- a/mm/damon/dbgfs.c > +++ b/mm/damon/dbgfs.c > @@ -20,6 +20,11 @@ static int dbgfs_nr_ctxs; > static struct dentry **dbgfs_dirs; > static DEFINE_MUTEX(damon_dbgfs_lock); > > +static void damon_dbgfs_warn_deprecation(void) > +{ > + pr_warn_once("DAMON debugfs interface is deprecated, so users should move to the sysfs interface (DAMON_SYSFS). If you depend on this and cannot move, please report your usecase to damon@lists.linux.dev and linux-mm@kvack.org.\n"); > +} Line length of 234 is a bit over the limit. I think it would be OK to split it at the end of the first sentence, like: pr_warn_once("DAMON debugfs interface is deprecated, so users should move to the sysfs interface (DAMON_SYSFS).\n"); pr_warn_once("If you depend on this and cannot move, please report your usecase to damon@lists.linux.dev and linux-mm@kvack.org.\n"); or would that [2 pr_warn_once() calls] not work for some reason? Or even: pr_warn_once( "DAMON debugfs interface is deprecated, so users should move to the sysfs interface (DAMON_SYSFS).\n"); pr_warn_once( "If you depend on this and cannot move, please report your usecase to damon@lists.linux.dev and linux-mm@kvack.org.\n"); although some people might gag at that one. -- ~Randy